diff mbox series

drm: use correct dev node location in comment

Message ID 20190722165648.7828-1-emil.l.velikov@gmail.com (mailing list archive)
State New, archived
Headers show
Series drm: use correct dev node location in comment | expand

Commit Message

Emil Velikov July 22, 2019, 4:56 p.m. UTC
From: Emil Velikov <emil.velikov@collabora.com>

Current comment mentions /dev/drm which hasn't been a thing even before
the code was merged into the kernel ;-)

Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
---
 drivers/gpu/drm/drm_file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sean Paul July 22, 2019, 5:31 p.m. UTC | #1
On Mon, Jul 22, 2019 at 05:56:48PM +0100, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov@collabora.com>
> 
> Current comment mentions /dev/drm which hasn't been a thing even before
> the code was merged into the kernel ;-)
> 
> Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
> ---
>  drivers/gpu/drm/drm_file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
> index ea34bc991858..5274b40eb5e3 100644
> --- a/drivers/gpu/drm/drm_file.c
> +++ b/drivers/gpu/drm/drm_file.c
> @@ -285,7 +285,7 @@ static int drm_cpu_valid(void)
>  }
>  
>  /*
> - * Called whenever a process opens /dev/drm.
> + * Called whenever a process opens /dev/dri/[number]

Well, /dev/dri/[number] also doesn't exist. You could change to:

+ * Called whenever a process opens /dev/dri/(card|render)[number]

or don't try to specify the exact path and say:

+ * Called whenever a process opens a drm node


Either way, 

Reviewed-by: Sean Paul <sean@poorly.run>


>   *
>   * \param filp file pointer.
>   * \param minor acquired minor-object.
> -- 
> 2.21.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox series

Patch

diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index ea34bc991858..5274b40eb5e3 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -285,7 +285,7 @@  static int drm_cpu_valid(void)
 }
 
 /*
- * Called whenever a process opens /dev/drm.
+ * Called whenever a process opens /dev/dri/[number]
  *
  * \param filp file pointer.
  * \param minor acquired minor-object.