| Message ID | 20190627222220.89175-1-nhuck@google.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 7114fbdaa2aad9ff00c4acc1fbba3eb07bac8889 |
| Headers | show |
| Series | clk: rockchip: Fix -Wunused-const-variable | expand |
On Thu, Jun 27, 2019 at 3:22 PM 'Nathan Huckleberry' via Clang Built Linux <clang-built-linux@googlegroups.com> wrote: > > Clang produces the following warning > > drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable > 'mux_pll_src_3plls_p' [-Wunused-const-variable] > PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" }; > > Looks like this variable was never used. Deleting it to remove the > warning. Indeed, looks like it was dead when introduced in: commit e44dde279492 ("clk: rockchip: add clock controller for rk1108") I don't see a pattern between when mux_pll_src_4plls_p vs mux_pll_src_2plls_p is used, so it's not clear where or even if mux_pll_src_3plls_p should be used. Given that there hasn't been a response to your original question (https://groups.google.com/forum/#!topic/clang-built-linux/NqJT9OPH5C8) and this patch is no functional change as the variable is already dead, I don't think it will hurt to remove it. It should also boost the signal to noise ratio of this warning. Thanks for looking into it, and the patch. Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > diff --git a/drivers/clk/rockchip/clk-rv1108.c b/drivers/clk/rockchip/clk-rv1108.c > index 96cc6af5632c..5947d3192866 100644 > --- a/drivers/clk/rockchip/clk-rv1108.c > +++ b/drivers/clk/rockchip/clk-rv1108.c > @@ -122,7 +122,6 @@ PNAME(mux_usb480m_pre_p) = { "usbphy", "xin24m" }; > PNAME(mux_hdmiphy_phy_p) = { "hdmiphy", "xin24m" }; > PNAME(mux_dclk_hdmiphy_pre_p) = { "dclk_hdmiphy_src_gpll", "dclk_hdmiphy_src_dpll" }; > PNAME(mux_pll_src_4plls_p) = { "dpll", "gpll", "hdmiphy", "usb480m" }; > -PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" }; Thanks, ~Nick Desaulniers
Quoting Nathan Huckleberry (2019-06-27 15:22:20) > Clang produces the following warning > > drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable > 'mux_pll_src_3plls_p' [-Wunused-const-variable] > PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" }; > > Looks like this variable was never used. Deleting it to remove the > warning. > > Cc: clang-built-linux@googlegroups.com > Link: https://github.com/ClangBuiltLinux/linux/issues/524 > Signed-off-by: Nathan Huckleberry <nhuck@google.com> > --- > drivers/clk/rockchip/clk-rv1108.c | 1 - > 1 file changed, 1 deletion(-) Heiko, can you pick this up? Looks like v5.4 material. > > diff --git a/drivers/clk/rockchip/clk-rv1108.c b/drivers/clk/rockchip/clk-rv1108.c > index 96cc6af5632c..5947d3192866 100644 > --- a/drivers/clk/rockchip/clk-rv1108.c > +++ b/drivers/clk/rockchip/clk-rv1108.c > @@ -122,7 +122,6 @@ PNAME(mux_usb480m_pre_p) = { "usbphy", "xin24m" }; > PNAME(mux_hdmiphy_phy_p) = { "hdmiphy", "xin24m" }; > PNAME(mux_dclk_hdmiphy_pre_p) = { "dclk_hdmiphy_src_gpll", "dclk_hdmiphy_src_dpll" }; > PNAME(mux_pll_src_4plls_p) = { "dpll", "gpll", "hdmiphy", "usb480m" }; > -PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" }; > PNAME(mux_pll_src_2plls_p) = { "dpll", "gpll" }; > PNAME(mux_pll_src_apll_gpll_p) = { "apll", "gpll" }; > PNAME(mux_aclk_peri_src_p) = { "aclk_peri_src_gpll", "aclk_peri_src_dpll" };
Hi Stephen, Am Montag, 22. Juli 2019, 23:35:18 CEST schrieb Stephen Boyd: > Quoting Nathan Huckleberry (2019-06-27 15:22:20) > > Clang produces the following warning > > > > drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable > > 'mux_pll_src_3plls_p' [-Wunused-const-variable] > > PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" }; > > > > Looks like this variable was never used. Deleting it to remove the > > warning. > > > > Cc: clang-built-linux@googlegroups.com > > Link: https://github.com/ClangBuiltLinux/linux/issues/524 > > Signed-off-by: Nathan Huckleberry <nhuck@google.com> > > --- > > drivers/clk/rockchip/clk-rv1108.c | 1 - > > 1 file changed, 1 deletion(-) > > Heiko, can you pick this up? Looks like v5.4 material. yep ... I'm planning to do that :-) Heiko > > diff --git a/drivers/clk/rockchip/clk-rv1108.c b/drivers/clk/rockchip/clk-rv1108.c > > index 96cc6af5632c..5947d3192866 100644 > > --- a/drivers/clk/rockchip/clk-rv1108.c > > +++ b/drivers/clk/rockchip/clk-rv1108.c > > @@ -122,7 +122,6 @@ PNAME(mux_usb480m_pre_p) = { "usbphy", "xin24m" }; > > PNAME(mux_hdmiphy_phy_p) = { "hdmiphy", "xin24m" }; > > PNAME(mux_dclk_hdmiphy_pre_p) = { "dclk_hdmiphy_src_gpll", "dclk_hdmiphy_src_dpll" }; > > PNAME(mux_pll_src_4plls_p) = { "dpll", "gpll", "hdmiphy", "usb480m" }; > > -PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" }; > > PNAME(mux_pll_src_2plls_p) = { "dpll", "gpll" }; > > PNAME(mux_pll_src_apll_gpll_p) = { "apll", "gpll" }; > > PNAME(mux_aclk_peri_src_p) = { "aclk_peri_src_gpll", "aclk_peri_src_dpll" };
Am Freitag, 28. Juni 2019, 00:22:20 CEST schrieb Nathan Huckleberry: > Clang produces the following warning > > drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable > 'mux_pll_src_3plls_p' [-Wunused-const-variable] > PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" }; > > Looks like this variable was never used. Deleting it to remove the > warning. > > Cc: clang-built-linux@googlegroups.com > Link: https://github.com/ClangBuiltLinux/linux/issues/524 > Signed-off-by: Nathan Huckleberry <nhuck@google.com> applied for 5.4 Thanks Heiko
Am Freitag, 28. Juni 2019, 00:32:38 CEST schrieb Nick Desaulniers: > On Thu, Jun 27, 2019 at 3:22 PM 'Nathan Huckleberry' via Clang Built > Linux <clang-built-linux@googlegroups.com> wrote: > > > > Clang produces the following warning > > > > drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable > > 'mux_pll_src_3plls_p' [-Wunused-const-variable] > > PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" }; > > > > Looks like this variable was never used. Deleting it to remove the > > warning. > > Indeed, looks like it was dead when introduced in: > commit e44dde279492 ("clk: rockchip: add clock controller for rk1108") > > I don't see a pattern between when mux_pll_src_4plls_p vs > mux_pll_src_2plls_p is used, so it's not clear where or even if > mux_pll_src_3plls_p should be used. The possible sources for a clock really differ often, so there is no general rule on when to use which sources ... except looking it up in the soc manual. And I guess any possible conflict will turn up when someone wants to use a clock that currently may reference the wrong sources.
diff --git a/drivers/clk/rockchip/clk-rv1108.c b/drivers/clk/rockchip/clk-rv1108.c index 96cc6af5632c..5947d3192866 100644 --- a/drivers/clk/rockchip/clk-rv1108.c +++ b/drivers/clk/rockchip/clk-rv1108.c @@ -122,7 +122,6 @@ PNAME(mux_usb480m_pre_p) = { "usbphy", "xin24m" }; PNAME(mux_hdmiphy_phy_p) = { "hdmiphy", "xin24m" }; PNAME(mux_dclk_hdmiphy_pre_p) = { "dclk_hdmiphy_src_gpll", "dclk_hdmiphy_src_dpll" }; PNAME(mux_pll_src_4plls_p) = { "dpll", "gpll", "hdmiphy", "usb480m" }; -PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" }; PNAME(mux_pll_src_2plls_p) = { "dpll", "gpll" }; PNAME(mux_pll_src_apll_gpll_p) = { "apll", "gpll" }; PNAME(mux_aclk_peri_src_p) = { "aclk_peri_src_gpll", "aclk_peri_src_dpll" };
Clang produces the following warning drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable 'mux_pll_src_3plls_p' [-Wunused-const-variable] PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" }; Looks like this variable was never used. Deleting it to remove the warning. Cc: clang-built-linux@googlegroups.com Link: https://github.com/ClangBuiltLinux/linux/issues/524 Signed-off-by: Nathan Huckleberry <nhuck@google.com> --- drivers/clk/rockchip/clk-rv1108.c | 1 - 1 file changed, 1 deletion(-)