| Message ID | 20190703011020.151615-6-saravanak@google.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Introduce Bandwidth OPPs for interconnect paths | expand |
On Tue, Jul 02, 2019 at 06:10:19PM -0700, Saravana Kannan wrote: > Add support for listing bandwidth OPP tables for each interconnect path > listed using the interconnects property. > > Signed-off-by: Saravana Kannan <saravanak@google.com> > --- > .../devicetree/bindings/interconnect/interconnect.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/interconnect/interconnect.txt b/Documentation/devicetree/bindings/interconnect/interconnect.txt > index 6f5d23a605b7..fc5b75b76a2c 100644 > --- a/Documentation/devicetree/bindings/interconnect/interconnect.txt > +++ b/Documentation/devicetree/bindings/interconnect/interconnect.txt > @@ -55,10 +55,18 @@ interconnect-names : List of interconnect path name strings sorted in the same > * dma-mem: Path from the device to the main memory of > the system > > +interconnect-opp-table: List of phandles to OPP tables (bandwidth OPP tables) > + that specify the OPPs for the interconnect paths listed > + in the interconnects property. This property can only > + point to OPP tables that belong to the device and are > + listed in the device's operating-points-v2 property. > + IMO, there's no need for this property. Which OPP is which should be defined already as part of the device's binding. That's enough for the driver to know which OPP applies to the interconnect. > Example: > > sdhci@7864000 { > + operating-points-v2 = <&sdhc_opp_table>, <&sdhc_mem_opp_table>; > ... > interconnects = <&pnoc MASTER_SDCC_1 &bimc SLAVE_EBI_CH0>; > interconnect-names = "sdhc-mem"; > + interconnect-opp-table = <&sdhc_mem_opp_table>; > }; > -- > 2.22.0.410.gd8fdbe21b5-goog >
On Mon, Jul 22, 2019 at 4:39 PM Rob Herring <robh@kernel.org> wrote: > > On Tue, Jul 02, 2019 at 06:10:19PM -0700, Saravana Kannan wrote: > > Add support for listing bandwidth OPP tables for each interconnect path > > listed using the interconnects property. > > > > Signed-off-by: Saravana Kannan <saravanak@google.com> > > --- > > .../devicetree/bindings/interconnect/interconnect.txt | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/interconnect/interconnect.txt b/Documentation/devicetree/bindings/interconnect/interconnect.txt > > index 6f5d23a605b7..fc5b75b76a2c 100644 > > --- a/Documentation/devicetree/bindings/interconnect/interconnect.txt > > +++ b/Documentation/devicetree/bindings/interconnect/interconnect.txt > > @@ -55,10 +55,18 @@ interconnect-names : List of interconnect path name strings sorted in the same > > * dma-mem: Path from the device to the main memory of > > the system > > > > +interconnect-opp-table: List of phandles to OPP tables (bandwidth OPP tables) > > + that specify the OPPs for the interconnect paths listed > > + in the interconnects property. This property can only > > + point to OPP tables that belong to the device and are > > + listed in the device's operating-points-v2 property. > > + > > IMO, there's no need for this property. Which OPP is which should be > defined already as part of the device's binding. That's enough for the > driver to know which OPP applies to the interconnect. Sure, I don't mind dropping this. -Saravana
On 22-07-19, 17:39, Rob Herring wrote: > On Tue, Jul 02, 2019 at 06:10:19PM -0700, Saravana Kannan wrote: > > Add support for listing bandwidth OPP tables for each interconnect path > > listed using the interconnects property. > > > > Signed-off-by: Saravana Kannan <saravanak@google.com> > > --- > > .../devicetree/bindings/interconnect/interconnect.txt | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/interconnect/interconnect.txt b/Documentation/devicetree/bindings/interconnect/interconnect.txt > > index 6f5d23a605b7..fc5b75b76a2c 100644 > > --- a/Documentation/devicetree/bindings/interconnect/interconnect.txt > > +++ b/Documentation/devicetree/bindings/interconnect/interconnect.txt > > @@ -55,10 +55,18 @@ interconnect-names : List of interconnect path name strings sorted in the same > > * dma-mem: Path from the device to the main memory of > > the system > > > > +interconnect-opp-table: List of phandles to OPP tables (bandwidth OPP tables) > > + that specify the OPPs for the interconnect paths listed > > + in the interconnects property. This property can only > > + point to OPP tables that belong to the device and are > > + listed in the device's operating-points-v2 property. > > + > > IMO, there's no need for this property. Which OPP is which should be > defined already as part of the device's binding. That's enough for the > driver to know which OPP applies to the interconnect. And if there is confusion we can actually use the compatible property to have another string which highlights that it is an interconnect OPP ?
diff --git a/Documentation/devicetree/bindings/interconnect/interconnect.txt b/Documentation/devicetree/bindings/interconnect/interconnect.txt index 6f5d23a605b7..fc5b75b76a2c 100644 --- a/Documentation/devicetree/bindings/interconnect/interconnect.txt +++ b/Documentation/devicetree/bindings/interconnect/interconnect.txt @@ -55,10 +55,18 @@ interconnect-names : List of interconnect path name strings sorted in the same * dma-mem: Path from the device to the main memory of the system +interconnect-opp-table: List of phandles to OPP tables (bandwidth OPP tables) + that specify the OPPs for the interconnect paths listed + in the interconnects property. This property can only + point to OPP tables that belong to the device and are + listed in the device's operating-points-v2 property. + Example: sdhci@7864000 { + operating-points-v2 = <&sdhc_opp_table>, <&sdhc_mem_opp_table>; ... interconnects = <&pnoc MASTER_SDCC_1 &bimc SLAVE_EBI_CH0>; interconnect-names = "sdhc-mem"; + interconnect-opp-table = <&sdhc_mem_opp_table>; };
Add support for listing bandwidth OPP tables for each interconnect path listed using the interconnects property. Signed-off-by: Saravana Kannan <saravanak@google.com> --- .../devicetree/bindings/interconnect/interconnect.txt | 8 ++++++++ 1 file changed, 8 insertions(+)