| Message ID | 20190717095436.28154-1-l.stach@pengutronix.de (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 8d0148473dece51675d11dd59b8db5fe4b5d2e7e |
| Headers | show |
| Series | arm64: dts: imx8mq: fix SAI compatible | expand |
Add Daniel for comment. On Wed, Jul 17, 2019 at 11:54:36AM +0200, Lucas Stach wrote: > The i.MX8M SAI block is not compatible with the i.MX6SX one, as the > register layout has changed due to two version registers being added > at the beginning of the address map. Remove the bogus compatible. > > Fixes: 8c61538dc945 "arm64: dts: imx8mq: Add SAI2 node" The format should be the following. I can fix it when applying though. Fixes: 8c61538dc945 ("arm64: dts: imx8mq: Add SAI2 node") Shawn > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > --- > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index 9326bd4150a3..0c533c66b340 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -718,8 +718,7 @@ > > sai2: sai@308b0000 { > #sound-dai-cells = <0>; > - compatible = "fsl,imx8mq-sai", > - "fsl,imx6sx-sai"; > + compatible = "fsl,imx8mq-sai"; > reg = <0x308b0000 0x10000>; > interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&clk IMX8MQ_CLK_SAI2_IPG>, > -- > 2.20.1 >
On Tue, 2019-07-23 at 15:33 +0800, Shawn Guo wrote: > Add Daniel for comment. > > On Wed, Jul 17, 2019 at 11:54:36AM +0200, Lucas Stach wrote: > > The i.MX8M SAI block is not compatible with the i.MX6SX one, as the > > register layout has changed due to two version registers being > > added > > at the beginning of the address map. Remove the bogus compatible. > > > > Fixes: 8c61538dc945 "arm64: dts: imx8mq: Add SAI2 node" > > The format should be the following. I can fix it when applying > though. > > Fixes: 8c61538dc945 ("arm64: dts: imx8mq: Add SAI2 node") > > Shawn > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
On Wed, Jul 17, 2019 at 11:54:36AM +0200, Lucas Stach wrote: > The i.MX8M SAI block is not compatible with the i.MX6SX one, as the > register layout has changed due to two version registers being added > at the beginning of the address map. Remove the bogus compatible. > > Fixes: 8c61538dc945 "arm64: dts: imx8mq: Add SAI2 node" > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Applied, thanks.
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index 9326bd4150a3..0c533c66b340 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi @@ -718,8 +718,7 @@ sai2: sai@308b0000 { #sound-dai-cells = <0>; - compatible = "fsl,imx8mq-sai", - "fsl,imx6sx-sai"; + compatible = "fsl,imx8mq-sai"; reg = <0x308b0000 0x10000>; interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clk IMX8MQ_CLK_SAI2_IPG>,
The i.MX8M SAI block is not compatible with the i.MX6SX one, as the register layout has changed due to two version registers being added at the beginning of the address map. Remove the bogus compatible. Fixes: 8c61538dc945 "arm64: dts: imx8mq: Add SAI2 node" Signed-off-by: Lucas Stach <l.stach@pengutronix.de> --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)