| Message ID | 20190724100335.GA7373@amd (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | coresight: fix typos | expand |
On 24/07/2019 11:03, Pavel Machek wrote: > > Fix typos in comments. > > Signed-off-by: Pavel Machek <pavel@denx.de> > > diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c > index 55db77f641..1d66191 100644 > --- a/drivers/hwtracing/coresight/coresight.c > +++ b/drivers/hwtracing/coresight/coresight.c > @@ -1001,7 +1001,7 @@ static int coresight_orphan_match(struct device *dev, void *data) > if (!i_csdev->orphan) > return 0; > /* > - * Circle throuch all the connection of that component. If we find > + * Circle through all the connections of that component. If we find > * an orphan connection whose name matches @csdev, link it. We have stopped using name to match the csdev and switched to fwnode handles. Please could you update the comment to reflect this, while you are at it ? Otherwise looks fine to me. Suzuki
On Wed 2019-07-24 11:36:23, Suzuki K Poulose wrote: > > > On 24/07/2019 11:03, Pavel Machek wrote: > > > >Fix typos in comments. > > > >Signed-off-by: Pavel Machek <pavel@denx.de> > > > >diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c > >index 55db77f641..1d66191 100644 > >--- a/drivers/hwtracing/coresight/coresight.c > >+++ b/drivers/hwtracing/coresight/coresight.c > >@@ -1001,7 +1001,7 @@ static int coresight_orphan_match(struct device *dev, void *data) > > if (!i_csdev->orphan) > > return 0; > > /* > >- * Circle throuch all the connection of that component. If we find > >+ * Circle through all the connections of that component. If we find > > * an orphan connection whose name matches @csdev, link it. > > We have stopped using name to match the csdev and switched to fwnode > handles. Please could you update the comment to reflect this, while you are > at it ? > Otherwise looks fine to me. I guess best way would be to apply this and then fix up the facts in a comment... or feel free to just fix it up. I am not best person to fix facts there... Best regards, Pavel
diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c index 55db77f641..1d66191 100644 --- a/drivers/hwtracing/coresight/coresight.c +++ b/drivers/hwtracing/coresight/coresight.c @@ -1001,7 +1001,7 @@ static int coresight_orphan_match(struct device *dev, void *data) if (!i_csdev->orphan) return 0; /* - * Circle throuch all the connection of that component. If we find + * Circle through all the connections of that component. If we find * an orphan connection whose name matches @csdev, link it. */ for (i = 0; i < i_csdev->pdata->nr_outport; i++) { @@ -1021,7 +1021,7 @@ static int coresight_orphan_match(struct device *dev, void *data) i_csdev->orphan = still_orphan; /* - * Returning '0' ensures that all known component on the + * Returning '0' ensures that all known components on the * bus will be checked. */ return 0;
Fix typos in comments. Signed-off-by: Pavel Machek <pavel@denx.de>