| Message ID | 20190709083258.57112-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | dmaengine: tegra210-adma: Fix unused function warnings | expand |
On 09/07/2019 09:32, YueHaibing wrote: > If CONFIG_PM is not set, build warnings: > > drivers/dma/tegra210-adma.c:747:12: warning: tegra_adma_runtime_resume defined but not used [-Wunused-function] > static int tegra_adma_runtime_resume(struct device *dev) > drivers/dma/tegra210-adma.c:715:12: warning: tegra_adma_runtime_suspend defined but not used [-Wunused-function] > static int tegra_adma_runtime_suspend(struct device *dev) > > Mark the two function as __maybe_unused. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/dma/tegra210-adma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c > index 2805853..b33cf6e 100644 > --- a/drivers/dma/tegra210-adma.c > +++ b/drivers/dma/tegra210-adma.c > @@ -712,7 +712,7 @@ static struct dma_chan *tegra_dma_of_xlate(struct of_phandle_args *dma_spec, > return chan; > } > > -static int tegra_adma_runtime_suspend(struct device *dev) > +static int __maybe_unused tegra_adma_runtime_suspend(struct device *dev) > { > struct tegra_adma *tdma = dev_get_drvdata(dev); > struct tegra_adma_chan_regs *ch_reg; > @@ -744,7 +744,7 @@ static int tegra_adma_runtime_suspend(struct device *dev) > return 0; > } > > -static int tegra_adma_runtime_resume(struct device *dev) > +static int __maybe_unused tegra_adma_runtime_resume(struct device *dev) > { > struct tegra_adma *tdma = dev_get_drvdata(dev); > struct tegra_adma_chan_regs *ch_reg; > Thanks! Acked-by: Jon Hunter <jonathanh@nvidia.com> Cheers Jon
On 09-07-19, 16:32, YueHaibing wrote: > If CONFIG_PM is not set, build warnings: > > drivers/dma/tegra210-adma.c:747:12: warning: tegra_adma_runtime_resume defined but not used [-Wunused-function] > static int tegra_adma_runtime_resume(struct device *dev) > drivers/dma/tegra210-adma.c:715:12: warning: tegra_adma_runtime_suspend defined but not used [-Wunused-function] > static int tegra_adma_runtime_suspend(struct device *dev) > > Mark the two function as __maybe_unused. Applied, thanks
diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c index 2805853..b33cf6e 100644 --- a/drivers/dma/tegra210-adma.c +++ b/drivers/dma/tegra210-adma.c @@ -712,7 +712,7 @@ static struct dma_chan *tegra_dma_of_xlate(struct of_phandle_args *dma_spec, return chan; } -static int tegra_adma_runtime_suspend(struct device *dev) +static int __maybe_unused tegra_adma_runtime_suspend(struct device *dev) { struct tegra_adma *tdma = dev_get_drvdata(dev); struct tegra_adma_chan_regs *ch_reg; @@ -744,7 +744,7 @@ static int tegra_adma_runtime_suspend(struct device *dev) return 0; } -static int tegra_adma_runtime_resume(struct device *dev) +static int __maybe_unused tegra_adma_runtime_resume(struct device *dev) { struct tegra_adma *tdma = dev_get_drvdata(dev); struct tegra_adma_chan_regs *ch_reg;
If CONFIG_PM is not set, build warnings: drivers/dma/tegra210-adma.c:747:12: warning: tegra_adma_runtime_resume defined but not used [-Wunused-function] static int tegra_adma_runtime_resume(struct device *dev) drivers/dma/tegra210-adma.c:715:12: warning: tegra_adma_runtime_suspend defined but not used [-Wunused-function] static int tegra_adma_runtime_suspend(struct device *dev) Mark the two function as __maybe_unused. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/dma/tegra210-adma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)