[0/2] mmc: tmio: remove Gen2+ workaround and fix up

Message

Ulrich Hecht July 16, 2019, 3:01 p.m. UTC

Hi!

The second patch in this series removes a workaround that forced eMMC devices
always on and that is no longer required.

Removing it does expose a bug, however, that leads to a clock imbalance due
to the clock being enabled by both PM and the hardware driver. (See
https://www.spinics.net/lists/linux-mmc/msg54009.html for discussion.)
This bug is taken care of by the first patch.

Tested on r8a7790 (Lager), r8a7795 and r8a7796 (Salvator-X) with SD and
eMMC, before and after suspend.

CU
Uli


Ulrich Hecht (2):
  mmc: tmio: leave clock handling to PM if enabled
  mmc: tmio: remove obsolete PM workaround

 drivers/mmc/host/tmio_mmc_core.c | 33 ++++++---------------------------
 1 file changed, 6 insertions(+), 27 deletions(-)

Comments

Niklas Söderlund July 25, 2019, 9:15 p.m. UTC | #1

Hi Ulrich,

Thanks for your work.

On 2019-07-16 17:01:02 +0200, Ulrich Hecht wrote:
> Hi!
> 
> The second patch in this series removes a workaround that forced eMMC devices
> always on and that is no longer required.
> 
> Removing it does expose a bug, however, that leads to a clock imbalance due
> to the clock being enabled by both PM and the hardware driver. (See
> https://www.spinics.net/lists/linux-mmc/msg54009.html for discussion.)
> This bug is taken care of by the first patch.
> 
> Tested on r8a7790 (Lager), r8a7795 and r8a7796 (Salvator-X) with SD and
> eMMC, before and after suspend.
> 
> CU
> Uli
> 
> 
> Ulrich Hecht (2):
>   mmc: tmio: leave clock handling to PM if enabled
>   mmc: tmio: remove obsolete PM workaround

Tested-by: Niklas Söderlund <[e-mail]>

> 
>  drivers/mmc/host/tmio_mmc_core.c | 33 ++++++---------------------------
>  1 file changed, 6 insertions(+), 27 deletions(-)
> 
> -- 
> 2.7.4
>