| Message ID | 20190729172152.4874-1-ogay@logitech.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 5b6cc1277a0536dae20f37d531f29b3416cee670 |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | HID: logitech-dj: extend consumer usages range | expand |
Hi Oliver, On Mon, Jul 29, 2019 at 07:21:52PM +0200, Olivier Gay wrote: > Extend the range of usage codes in the consumer page descriptor of > the driver. Some Logitech HID devices send usages in that upper range. > > Signed-off-by: Olivier Gay <ogay@logitech.com> Tested-by: Benson Leung <bleung@chromium.org> Patch works for me on my sample when picked to the chromeos-kernel. Thanks! Benson > --- > drivers/hid/hid-logitech-dj.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c > index 6196217a7d93..0e058ddb8e1c 100644 > --- a/drivers/hid/hid-logitech-dj.c > +++ b/drivers/hid/hid-logitech-dj.c > @@ -380,9 +380,9 @@ static const char consumer_descriptor[] = { > 0x75, 0x10, /* REPORT_SIZE (16) */ > 0x95, 0x02, /* REPORT_COUNT (2) */ > 0x15, 0x01, /* LOGICAL_MIN (1) */ > - 0x26, 0x8C, 0x02, /* LOGICAL_MAX (652) */ > + 0x26, 0xFF, 0x02, /* LOGICAL_MAX (767) */ > 0x19, 0x01, /* USAGE_MIN (1) */ > - 0x2A, 0x8C, 0x02, /* USAGE_MAX (652) */ > + 0x2A, 0xFF, 0x02, /* USAGE_MAX (767) */ > 0x81, 0x00, /* INPUT (Data Ary Abs) */ > 0xC0, /* END_COLLECTION */ > }; /* */ > -- > 2.17.1 >
On Mon, 29 Jul 2019, Olivier Gay wrote: > Extend the range of usage codes in the consumer page descriptor of > the driver. Some Logitech HID devices send usages in that upper range. > > Signed-off-by: Olivier Gay <ogay@logitech.com> > --- > drivers/hid/hid-logitech-dj.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c > index 6196217a7d93..0e058ddb8e1c 100644 > --- a/drivers/hid/hid-logitech-dj.c > +++ b/drivers/hid/hid-logitech-dj.c > @@ -380,9 +380,9 @@ static const char consumer_descriptor[] = { > 0x75, 0x10, /* REPORT_SIZE (16) */ > 0x95, 0x02, /* REPORT_COUNT (2) */ > 0x15, 0x01, /* LOGICAL_MIN (1) */ > - 0x26, 0x8C, 0x02, /* LOGICAL_MAX (652) */ > + 0x26, 0xFF, 0x02, /* LOGICAL_MAX (767) */ > 0x19, 0x01, /* USAGE_MIN (1) */ > - 0x2A, 0x8C, 0x02, /* USAGE_MAX (652) */ > + 0x2A, 0xFF, 0x02, /* USAGE_MAX (767) */ > 0x81, 0x00, /* INPUT (Data Ary Abs) */ > 0xC0, /* END_COLLECTION */ Applied, thanks.
diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c index 6196217a7d93..0e058ddb8e1c 100644 --- a/drivers/hid/hid-logitech-dj.c +++ b/drivers/hid/hid-logitech-dj.c @@ -380,9 +380,9 @@ static const char consumer_descriptor[] = { 0x75, 0x10, /* REPORT_SIZE (16) */ 0x95, 0x02, /* REPORT_COUNT (2) */ 0x15, 0x01, /* LOGICAL_MIN (1) */ - 0x26, 0x8C, 0x02, /* LOGICAL_MAX (652) */ + 0x26, 0xFF, 0x02, /* LOGICAL_MAX (767) */ 0x19, 0x01, /* USAGE_MIN (1) */ - 0x2A, 0x8C, 0x02, /* USAGE_MAX (652) */ + 0x2A, 0xFF, 0x02, /* USAGE_MAX (767) */ 0x81, 0x00, /* INPUT (Data Ary Abs) */ 0xC0, /* END_COLLECTION */ }; /* */
Extend the range of usage codes in the consumer page descriptor of the driver. Some Logitech HID devices send usages in that upper range. Signed-off-by: Olivier Gay <ogay@logitech.com> --- drivers/hid/hid-logitech-dj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)