| Message ID | 20190730021540.66579-4-mbalant3@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/4] watchdog device drivers:pc87413_wdt:Rewriting of pc87413_wdt driver to utilize common watchdog interface | expand |
On 7/29/19 7:15 PM, Mark Balantzyan wrote: > There is a potential for the variable swc_base_addr in the call chain of the > driver initialization function (init) to be used before initialization. This > brought up the need for, by rewriting the driver to use the common watchdog > interface, ensuring to have all resources in place. This patch addresses this > need by rewriting into common watchdog interface utilization for the driver. > > Signed-off-by: Mark Balantzyan <mbalant3@gmail.com> > > --- > drivers/watchdog/pc87413_wdt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/watchdog/pc87413_wdt.c b/drivers/watchdog/pc87413_wdt.c > index bc6c4e19..6863145a 100644 > --- a/drivers/watchdog/pc87413_wdt.c > +++ b/drivers/watchdog/pc87413_wdt.c > @@ -370,7 +370,6 @@ reboot_unreg: > static void __exit pc87413_exit(void) > { > watchdog_unregister_device(&pc87413wdt_wdd); > - unregister_reboot_notifier(&pc87413_notifier); This needs to be in patch 2. > release_region(swc_base_addr, 0x20); > > pr_info("watchdog component driver removed\n"); >
diff --git a/drivers/watchdog/pc87413_wdt.c b/drivers/watchdog/pc87413_wdt.c index bc6c4e19..6863145a 100644 --- a/drivers/watchdog/pc87413_wdt.c +++ b/drivers/watchdog/pc87413_wdt.c @@ -370,7 +370,6 @@ reboot_unreg: static void __exit pc87413_exit(void) { watchdog_unregister_device(&pc87413wdt_wdd); - unregister_reboot_notifier(&pc87413_notifier); release_region(swc_base_addr, 0x20); pr_info("watchdog component driver removed\n");
There is a potential for the variable swc_base_addr in the call chain of the driver initialization function (init) to be used before initialization. This brought up the need for, by rewriting the driver to use the common watchdog interface, ensuring to have all resources in place. This patch addresses this need by rewriting into common watchdog interface utilization for the driver. Signed-off-by: Mark Balantzyan <mbalant3@gmail.com> --- drivers/watchdog/pc87413_wdt.c | 1 - 1 file changed, 1 deletion(-)