| Message ID | 20190730021540.66579-3-mbalant3@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/4] watchdog device drivers:pc87413_wdt:Rewriting of pc87413_wdt driver to utilize common watchdog interface | expand |
On 7/29/19 7:15 PM, Mark Balantzyan wrote: > There is a potential for the variable swc_base_addr in the call chain of the > driver initialization function (init) to be used before initialization. This > brought up the need for, by rewriting the driver to use the common watchdog > interface, ensuring to have all resources in place. This patch addresses this > need by rewriting into common watchdog interface utilization for the driver. > > Signed-off-by: Mark Balantzyan <mbalant3@gmail.com> > > --- > drivers/watchdog/pc87413_wdt.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/watchdog/pc87413_wdt.c b/drivers/watchdog/pc87413_wdt.c > index a9070a22..bc6c4e19 100644 > --- a/drivers/watchdog/pc87413_wdt.c > +++ b/drivers/watchdog/pc87413_wdt.c > @@ -392,9 +392,3 @@ module_param(timeout, int, 0); > MODULE_PARM_DESC(timeout, > "Watchdog timeout in minutes (default=" > __MODULE_STRING(DEFAULT_TIMEOUT) ")."); > - > -module_param(nowayout, bool, 0); > -MODULE_PARM_DESC(nowayout,watchdog_set_nowayout > - "Watchdog cannot be stopped once started (default=" > - __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); > - > Why would you no longer want this module parameter ? You should keep it and call watchdog_set_nowayout(wdev, nowayout); in the probe function. Guenter
diff --git a/drivers/watchdog/pc87413_wdt.c b/drivers/watchdog/pc87413_wdt.c index a9070a22..bc6c4e19 100644 --- a/drivers/watchdog/pc87413_wdt.c +++ b/drivers/watchdog/pc87413_wdt.c @@ -392,9 +392,3 @@ module_param(timeout, int, 0); MODULE_PARM_DESC(timeout, "Watchdog timeout in minutes (default=" __MODULE_STRING(DEFAULT_TIMEOUT) ")."); - -module_param(nowayout, bool, 0); -MODULE_PARM_DESC(nowayout, - "Watchdog cannot be stopped once started (default=" - __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); -
There is a potential for the variable swc_base_addr in the call chain of the driver initialization function (init) to be used before initialization. This brought up the need for, by rewriting the driver to use the common watchdog interface, ensuring to have all resources in place. This patch addresses this need by rewriting into common watchdog interface utilization for the driver. Signed-off-by: Mark Balantzyan <mbalant3@gmail.com> --- drivers/watchdog/pc87413_wdt.c | 6 ------ 1 file changed, 6 deletions(-)