| Message ID | 20190725145719.8344-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | HID: logitech-dj: Fix check of logi_dj_recv_query_paired_devices() | expand |
Hi, > In delayedwork_callback(), logi_dj_recv_query_paired_devices > may return positive value while success now, so check it > correctly. > Fixes: dbcbabf7da92 ("HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp_devices") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Petr Vorel <pvorel@suse.cz> Kind regards, Petr
Hi, > > In delayedwork_callback(), logi_dj_recv_query_paired_devices > > may return positive value while success now, so check it > > correctly. > > Fixes: dbcbabf7da92 ("HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp_devices") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > Reviewed-by: Petr Vorel <pvorel@suse.cz> OK, not only it didn't fix problems with logitech mouse (see below), but removing mouses USB dongle effectively crashes kernel, so this one probably shouldn't be applied :). [ 330.721629] logitech-djreceiver: probe of 0003:046D:C52F.0013 failed with error 7 [ 331.462335] hid 0003:046D:C52F.0013: delayedwork_callback: logi_dj_recv_query_paired_devices error: 7 Kind regards, Petr
Hi Petr, On 31-07-19 13:06, Petr Vorel wrote: > Hi, > >>> In delayedwork_callback(), logi_dj_recv_query_paired_devices >>> may return positive value while success now, so check it >>> correctly. > >>> Fixes: dbcbabf7da92 ("HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp_devices") >>> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> Reviewed-by: Petr Vorel <pvorel@suse.cz> > OK, not only it didn't fix problems with logitech mouse (see below), > but removing mouses USB dongle effectively crashes kernel, so this one probably > shouldn't be applied :). > > [ 330.721629] logitech-djreceiver: probe of 0003:046D:C52F.0013 failed with error 7 > [ 331.462335] hid 0003:046D:C52F.0013: delayedwork_callback: logi_dj_recv_query_paired_devices error: 7 Please test my patch titled: "HID: logitech-dj: Really fix return value of logi_dj_recv_query_hidpp_devices" which should fix this. Regards, Hans
On 2019/7/31 19:29, Hans de Goede wrote: > Hi Petr, > > On 31-07-19 13:06, Petr Vorel wrote: >> Hi, >> >>>> In delayedwork_callback(), logi_dj_recv_query_paired_devices >>>> may return positive value while success now, so check it >>>> correctly. >> >>>> Fixes: dbcbabf7da92 ("HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp_devices") >>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >>> Reviewed-by: Petr Vorel <pvorel@suse.cz> >> OK, not only it didn't fix problems with logitech mouse (see below), >> but removing mouses USB dongle effectively crashes kernel, so this one probably >> shouldn't be applied :). >> >> [ 330.721629] logitech-djreceiver: probe of 0003:046D:C52F.0013 failed with error 7 >> [ 331.462335] hid 0003:046D:C52F.0013: delayedwork_callback: logi_dj_recv_query_paired_devices error: 7 > > Please test my patch titled: "HID: logitech-dj: Really fix return value of logi_dj_recv_query_hidpp_devices" > which should fix this. Yes, this is better one, thanks! > > Regards, > > Hans > > . >
Hi Hans, > Please test my patch titled: "HID: logitech-dj: Really fix return value of logi_dj_recv_query_hidpp_devices" > which should fix this. Indeed, patch [1] fixed that, thanks :) > Regards, > Hans Kind regards, Petr [1] https://patchwork.kernel.org/patch/11064087/
On Wed, 31 Jul 2019, Hans de Goede wrote: > >>> In delayedwork_callback(), logi_dj_recv_query_paired_devices > >>> may return positive value while success now, so check it > >>> correctly. > > > >>> Fixes: dbcbabf7da92 ("HID: logitech-dj: fix return value of > >>> Fixes: logi_dj_recv_query_hidpp_devices") > >>> Signed-off-by: YueHaibing <yuehaibing@huawei.com> > >> Reviewed-by: Petr Vorel <pvorel@suse.cz> > > OK, not only it didn't fix problems with logitech mouse (see below), > > but removing mouses USB dongle effectively crashes kernel, so this one > > probably > > shouldn't be applied :). > > > > [ 330.721629] logitech-djreceiver: probe of 0003:046D:C52F.0013 failed with > > error 7 > > [ 331.462335] hid 0003:046D:C52F.0013: delayedwork_callback: > > logi_dj_recv_query_paired_devices error: 7 > > Please test my patch titled: "HID: logitech-dj: Really fix return value of > logi_dj_recv_query_hidpp_devices" > which should fix this. Hans, have I been CCed on that patch? I don't seem to see it in in inbox. Thanks,
Hi Jiri, On 05-08-19 10:51, Jiri Kosina wrote: > On Wed, 31 Jul 2019, Hans de Goede wrote: > >>>>> In delayedwork_callback(), logi_dj_recv_query_paired_devices >>>>> may return positive value while success now, so check it >>>>> correctly. >>> >>>>> Fixes: dbcbabf7da92 ("HID: logitech-dj: fix return value of >>>>> Fixes: logi_dj_recv_query_hidpp_devices") >>>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >>>> Reviewed-by: Petr Vorel <pvorel@suse.cz> >>> OK, not only it didn't fix problems with logitech mouse (see below), >>> but removing mouses USB dongle effectively crashes kernel, so this one >>> probably >>> shouldn't be applied :). >>> >>> [ 330.721629] logitech-djreceiver: probe of 0003:046D:C52F.0013 failed with >>> error 7 >>> [ 331.462335] hid 0003:046D:C52F.0013: delayedwork_callback: >>> logi_dj_recv_query_paired_devices error: 7 >> >> Please test my patch titled: "HID: logitech-dj: Really fix return value of >> logi_dj_recv_query_hidpp_devices" >> which should fix this. > > Hans, have I been CCed on that patch? I don't seem to see it in in inbox. I have "Jiri Kosina <jikos@kernel.org>" in the To: for the patch in the copy in my Inbox (I always Cc myself). Anyways, you can grab it here: https://patchwork.kernel.org/patch/11064087/ It has gathered 2 Tested-by-s and 2 Reviewed-by-s since posting, so assuming you like it too, this is ready for merging. Regards, Hans
Hi all, On Mon, Aug 5, 2019 at 10:55 AM Hans de Goede <hdegoede@redhat.com> wrote: > > Hi Jiri, > > On 05-08-19 10:51, Jiri Kosina wrote: > > On Wed, 31 Jul 2019, Hans de Goede wrote: > > > >>>>> In delayedwork_callback(), logi_dj_recv_query_paired_devices > >>>>> may return positive value while success now, so check it > >>>>> correctly. > >>> > >>>>> Fixes: dbcbabf7da92 ("HID: logitech-dj: fix return value of > >>>>> Fixes: logi_dj_recv_query_hidpp_devices") > >>>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com> > >>>> Reviewed-by: Petr Vorel <pvorel@suse.cz> > >>> OK, not only it didn't fix problems with logitech mouse (see below), > >>> but removing mouses USB dongle effectively crashes kernel, so this one > >>> probably > >>> shouldn't be applied :). > >>> > >>> [ 330.721629] logitech-djreceiver: probe of 0003:046D:C52F.0013 failed with > >>> error 7 > >>> [ 331.462335] hid 0003:046D:C52F.0013: delayedwork_callback: > >>> logi_dj_recv_query_paired_devices error: 7 > >> > >> Please test my patch titled: "HID: logitech-dj: Really fix return value of > >> logi_dj_recv_query_hidpp_devices" > >> which should fix this. > > > > Hans, have I been CCed on that patch? I don't seem to see it in in inbox. > > I have "Jiri Kosina <jikos@kernel.org>" in the To: for the patch in the > copy in my Inbox (I always Cc myself). > > Anyways, you can grab it here: > > https://patchwork.kernel.org/patch/11064087/ > > It has gathered 2 Tested-by-s and 2 Reviewed-by-s since posting, so > assuming you like it too, this is ready for merging. > Sorry for being silent on the mailing list. I have been 2 weeks on PTO, and when I came back, my server that shown a few corruptions here and there was completely broken. I spent the last week trying to revive it until I realized that I have a bad memory chip on it, which introduced random errors. Anyway, I think Hans' patch should go in, but I am not fully operational given that my test box is still recovering :( Cheers, Benjamin
diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c index 8cdf373..bf6b289 100644 --- a/drivers/hid/hid-logitech-dj.c +++ b/drivers/hid/hid-logitech-dj.c @@ -793,7 +793,7 @@ static void delayedwork_callback(struct work_struct *work) break; case WORKITEM_TYPE_UNKNOWN: retval = logi_dj_recv_query_paired_devices(djrcv_dev); - if (retval) { + if (retval < 0) { hid_err(djrcv_dev->hidpp, "%s: logi_dj_recv_query_paired_devices error: %d\n", __func__, retval); }
In delayedwork_callback(), logi_dj_recv_query_paired_devices may return positive value while success now, so check it correctly. Fixes: dbcbabf7da92 ("HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp_devices") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/hid/hid-logitech-dj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)