| Message ID | 20190729053243.9224-3-peterx@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: X86: Some tracepoint enhancements | expand |
On 07/28/2019 10:32 PM, Peter Xu wrote: > It's done by TP_printk() already. > > Signed-off-by: Peter Xu <peterx@redhat.com> > --- > arch/x86/kvm/trace.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h > index 26423d2e45df..76a39bc25b95 100644 > --- a/arch/x86/kvm/trace.h > +++ b/arch/x86/kvm/trace.h > @@ -1323,7 +1323,7 @@ TRACE_EVENT(kvm_avic_incomplete_ipi, > __entry->index = index; > ), > > - TP_printk("vcpu=%u, icrh:icrl=%#010x:%08x, id=%u, index=%u\n", > + TP_printk("vcpu=%u, icrh:icrl=%#010x:%08x, id=%u, index=%u", > __entry->vcpu, __entry->icrh, __entry->icrl, > __entry->id, __entry->index) > ); > @@ -1348,7 +1348,7 @@ TRACE_EVENT(kvm_avic_unaccelerated_access, > __entry->vec = vec; > ), > > - TP_printk("vcpu=%u, offset=%#x(%s), %s, %s, vec=%#x\n", > + TP_printk("vcpu=%u, offset=%#x(%s), %s, %s, vec=%#x", > __entry->vcpu, > __entry->offset, > __print_symbolic(__entry->offset, kvm_trace_symbol_apic), > @@ -1368,7 +1368,7 @@ TRACE_EVENT(kvm_hv_timer_state, > __entry->vcpu_id = vcpu_id; > __entry->hv_timer_in_use = hv_timer_in_use; > ), > - TP_printk("vcpu_id %x hv_timer %x\n", > + TP_printk("vcpu_id %x hv_timer %x", > __entry->vcpu_id, > __entry->hv_timer_in_use) > ); Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
On Mon, 29 Jul 2019 at 13:35, Peter Xu <zhexu@redhat.com> wrote: > > It's done by TP_printk() already. > > Signed-off-by: Peter Xu <peterx@redhat.com> > --- > arch/x86/kvm/trace.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h > index 26423d2e45df..76a39bc25b95 100644 > --- a/arch/x86/kvm/trace.h > +++ b/arch/x86/kvm/trace.h > @@ -1323,7 +1323,7 @@ TRACE_EVENT(kvm_avic_incomplete_ipi, > __entry->index = index; > ), > > - TP_printk("vcpu=%u, icrh:icrl=%#010x:%08x, id=%u, index=%u\n", > + TP_printk("vcpu=%u, icrh:icrl=%#010x:%08x, id=%u, index=%u", > __entry->vcpu, __entry->icrh, __entry->icrl, > __entry->id, __entry->index) > ); > @@ -1348,7 +1348,7 @@ TRACE_EVENT(kvm_avic_unaccelerated_access, > __entry->vec = vec; > ), > > - TP_printk("vcpu=%u, offset=%#x(%s), %s, %s, vec=%#x\n", > + TP_printk("vcpu=%u, offset=%#x(%s), %s, %s, vec=%#x", > __entry->vcpu, > __entry->offset, > __print_symbolic(__entry->offset, kvm_trace_symbol_apic), > @@ -1368,7 +1368,7 @@ TRACE_EVENT(kvm_hv_timer_state, > __entry->vcpu_id = vcpu_id; > __entry->hv_timer_in_use = hv_timer_in_use; > ), > - TP_printk("vcpu_id %x hv_timer %x\n", > + TP_printk("vcpu_id %x hv_timer %x", > __entry->vcpu_id, > __entry->hv_timer_in_use) The last one is handled by commit 7be373b6de503 . Regards, Wanpeng Li
On Thu, Aug 01, 2019 at 11:39:04AM +0800, Wanpeng Li wrote: > On Mon, 29 Jul 2019 at 13:35, Peter Xu <zhexu@redhat.com> wrote: > > > > It's done by TP_printk() already. > > > > Signed-off-by: Peter Xu <peterx@redhat.com> > > --- > > arch/x86/kvm/trace.h | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h > > index 26423d2e45df..76a39bc25b95 100644 > > --- a/arch/x86/kvm/trace.h > > +++ b/arch/x86/kvm/trace.h > > @@ -1323,7 +1323,7 @@ TRACE_EVENT(kvm_avic_incomplete_ipi, > > __entry->index = index; > > ), > > > > - TP_printk("vcpu=%u, icrh:icrl=%#010x:%08x, id=%u, index=%u\n", > > + TP_printk("vcpu=%u, icrh:icrl=%#010x:%08x, id=%u, index=%u", > > __entry->vcpu, __entry->icrh, __entry->icrl, > > __entry->id, __entry->index) > > ); > > @@ -1348,7 +1348,7 @@ TRACE_EVENT(kvm_avic_unaccelerated_access, > > __entry->vec = vec; > > ), > > > > - TP_printk("vcpu=%u, offset=%#x(%s), %s, %s, vec=%#x\n", > > + TP_printk("vcpu=%u, offset=%#x(%s), %s, %s, vec=%#x", > > __entry->vcpu, > > __entry->offset, > > __print_symbolic(__entry->offset, kvm_trace_symbol_apic), > > @@ -1368,7 +1368,7 @@ TRACE_EVENT(kvm_hv_timer_state, > > __entry->vcpu_id = vcpu_id; > > __entry->hv_timer_in_use = hv_timer_in_use; > > ), > > - TP_printk("vcpu_id %x hv_timer %x\n", > > + TP_printk("vcpu_id %x hv_timer %x", > > __entry->vcpu_id, > > __entry->hv_timer_in_use) > > The last one is handled by commit 7be373b6de503 . Right, I'll rebase. Thanks.
diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h index 26423d2e45df..76a39bc25b95 100644 --- a/arch/x86/kvm/trace.h +++ b/arch/x86/kvm/trace.h @@ -1323,7 +1323,7 @@ TRACE_EVENT(kvm_avic_incomplete_ipi, __entry->index = index; ), - TP_printk("vcpu=%u, icrh:icrl=%#010x:%08x, id=%u, index=%u\n", + TP_printk("vcpu=%u, icrh:icrl=%#010x:%08x, id=%u, index=%u", __entry->vcpu, __entry->icrh, __entry->icrl, __entry->id, __entry->index) ); @@ -1348,7 +1348,7 @@ TRACE_EVENT(kvm_avic_unaccelerated_access, __entry->vec = vec; ), - TP_printk("vcpu=%u, offset=%#x(%s), %s, %s, vec=%#x\n", + TP_printk("vcpu=%u, offset=%#x(%s), %s, %s, vec=%#x", __entry->vcpu, __entry->offset, __print_symbolic(__entry->offset, kvm_trace_symbol_apic), @@ -1368,7 +1368,7 @@ TRACE_EVENT(kvm_hv_timer_state, __entry->vcpu_id = vcpu_id; __entry->hv_timer_in_use = hv_timer_in_use; ), - TP_printk("vcpu_id %x hv_timer %x\n", + TP_printk("vcpu_id %x hv_timer %x", __entry->vcpu_id, __entry->hv_timer_in_use) );
It's done by TP_printk() already. Signed-off-by: Peter Xu <peterx@redhat.com> --- arch/x86/kvm/trace.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)