diff mbox series

[1/1] coresight: Fix DEBUG_LOCKS_WARN_ON for uninitialized attribute

Message ID 20190801172323.18359-2-mathieu.poirier@linaro.org (mailing list archive)
State Mainlined
Commit 5511c0c309db4c526a6e9f8b2b8a1483771574bc
Headers show
Series coresight: Fix for v5.3-rc3 | expand

Commit Message

Mathieu Poirier Aug. 1, 2019, 5:23 p.m. UTC 
From: Suzuki K Poulose <suzuki.poulose@arm.com>

While running the linux-next with CONFIG_DEBUG_LOCKS_ALLOC enabled,
I get the following splat.

 BUG: key ffffcb5636929298 has not been registered!
 ------------[ cut here ]------------
 DEBUG_LOCKS_WARN_ON(1)
 WARNING: CPU: 1 PID: 53 at kernel/locking/lockdep.c:3669 lockdep_init_map+0x164/0x1f0
 CPU: 1 PID: 53 Comm: kworker/1:1 Tainted: G        W         5.2.0-next-20190712-00015-g00ad4634222e-dirty #603
 Workqueue: events amba_deferred_retry_func
 pstate: 60c00005 (nZCv daif +PAN +UAO)
 pc : lockdep_init_map+0x164/0x1f0
 lr : lockdep_init_map+0x164/0x1f0

 [ trimmed ]

 Call trace:
  lockdep_init_map+0x164/0x1f0
  __kernfs_create_file+0x9c/0x158
  sysfs_add_file_mode_ns+0xa8/0x1d0
  sysfs_add_file_to_group+0x88/0xd8
  etm_perf_add_symlink_sink+0xcc/0x138
  coresight_register+0x110/0x280
  tmc_probe+0x160/0x420

 [ trimmed ]

 ---[ end trace ab4cc669615ba1b0 ]---

Fix this by initialising the dynamically allocated attribute properly.

Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Fixes: bb8e370bdc141ddf ("coresight: perf: Add "sinks" group to PMU directory")
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
[Fixed a typograhic error in the changelog]
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
 drivers/hwtracing/coresight/coresight-etm-perf.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Greg KH Aug. 1, 2019, 6:50 p.m. UTC | #1 
On Thu, Aug 01, 2019 at 11:23:23AM -0600, Mathieu Poirier wrote:
> From: Suzuki K Poulose <suzuki.poulose@arm.com>
> 
> While running the linux-next with CONFIG_DEBUG_LOCKS_ALLOC enabled,
> I get the following splat.
> 
>  BUG: key ffffcb5636929298 has not been registered!
>  ------------[ cut here ]------------
>  DEBUG_LOCKS_WARN_ON(1)
>  WARNING: CPU: 1 PID: 53 at kernel/locking/lockdep.c:3669 lockdep_init_map+0x164/0x1f0
>  CPU: 1 PID: 53 Comm: kworker/1:1 Tainted: G        W         5.2.0-next-20190712-00015-g00ad4634222e-dirty #603
>  Workqueue: events amba_deferred_retry_func
>  pstate: 60c00005 (nZCv daif +PAN +UAO)
>  pc : lockdep_init_map+0x164/0x1f0
>  lr : lockdep_init_map+0x164/0x1f0
> 
>  [ trimmed ]
> 
>  Call trace:
>   lockdep_init_map+0x164/0x1f0
>   __kernfs_create_file+0x9c/0x158
>   sysfs_add_file_mode_ns+0xa8/0x1d0
>   sysfs_add_file_to_group+0x88/0xd8
>   etm_perf_add_symlink_sink+0xcc/0x138
>   coresight_register+0x110/0x280
>   tmc_probe+0x160/0x420
> 
>  [ trimmed ]
> 
>  ---[ end trace ab4cc669615ba1b0 ]---
> 
> Fix this by initialising the dynamically allocated attribute properly.
> 
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Fixes: bb8e370bdc141ddf ("coresight: perf: Add "sinks" group to PMU directory")

That should be:
Fixes: bb8e370bdc14 ("coresight: perf: Add "sinks" group to PMU directory")

I can go fix it up...
Mathieu Poirier Aug. 1, 2019, 8:20 p.m. UTC | #2 
On Thu, 1 Aug 2019 at 12:50, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Aug 01, 2019 at 11:23:23AM -0600, Mathieu Poirier wrote:
> > From: Suzuki K Poulose <suzuki.poulose@arm.com>
> >
> > While running the linux-next with CONFIG_DEBUG_LOCKS_ALLOC enabled,
> > I get the following splat.
> >
> >  BUG: key ffffcb5636929298 has not been registered!
> >  ------------[ cut here ]------------
> >  DEBUG_LOCKS_WARN_ON(1)
> >  WARNING: CPU: 1 PID: 53 at kernel/locking/lockdep.c:3669 lockdep_init_map+0x164/0x1f0
> >  CPU: 1 PID: 53 Comm: kworker/1:1 Tainted: G        W         5.2.0-next-20190712-00015-g00ad4634222e-dirty #603
> >  Workqueue: events amba_deferred_retry_func
> >  pstate: 60c00005 (nZCv daif +PAN +UAO)
> >  pc : lockdep_init_map+0x164/0x1f0
> >  lr : lockdep_init_map+0x164/0x1f0
> >
> >  [ trimmed ]
> >
> >  Call trace:
> >   lockdep_init_map+0x164/0x1f0
> >   __kernfs_create_file+0x9c/0x158
> >   sysfs_add_file_mode_ns+0xa8/0x1d0
> >   sysfs_add_file_to_group+0x88/0xd8
> >   etm_perf_add_symlink_sink+0xcc/0x138
> >   coresight_register+0x110/0x280
> >   tmc_probe+0x160/0x420
> >
> >  [ trimmed ]
> >
> >  ---[ end trace ab4cc669615ba1b0 ]---
> >
> > Fix this by initialising the dynamically allocated attribute properly.
> >
> > Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> > Fixes: bb8e370bdc141ddf ("coresight: perf: Add "sinks" group to PMU directory")
>
> That should be:
> Fixes: bb8e370bdc14 ("coresight: perf: Add "sinks" group to PMU directory")

Apologies - I will catch those from hereon.

>
> I can go fix it up...

Or I can, depending on if you're going to pick the patch as a fix for
5.3 or you'll wait for the 5.4 cycle.

>
Greg KH Aug. 1, 2019, 8:26 p.m. UTC | #3 
On Thu, Aug 01, 2019 at 02:20:39PM -0600, Mathieu Poirier wrote:
> On Thu, 1 Aug 2019 at 12:50, Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Thu, Aug 01, 2019 at 11:23:23AM -0600, Mathieu Poirier wrote:
> > > From: Suzuki K Poulose <suzuki.poulose@arm.com>
> > >
> > > While running the linux-next with CONFIG_DEBUG_LOCKS_ALLOC enabled,
> > > I get the following splat.
> > >
> > >  BUG: key ffffcb5636929298 has not been registered!
> > >  ------------[ cut here ]------------
> > >  DEBUG_LOCKS_WARN_ON(1)
> > >  WARNING: CPU: 1 PID: 53 at kernel/locking/lockdep.c:3669 lockdep_init_map+0x164/0x1f0
> > >  CPU: 1 PID: 53 Comm: kworker/1:1 Tainted: G        W         5.2.0-next-20190712-00015-g00ad4634222e-dirty #603
> > >  Workqueue: events amba_deferred_retry_func
> > >  pstate: 60c00005 (nZCv daif +PAN +UAO)
> > >  pc : lockdep_init_map+0x164/0x1f0
> > >  lr : lockdep_init_map+0x164/0x1f0
> > >
> > >  [ trimmed ]
> > >
> > >  Call trace:
> > >   lockdep_init_map+0x164/0x1f0
> > >   __kernfs_create_file+0x9c/0x158
> > >   sysfs_add_file_mode_ns+0xa8/0x1d0
> > >   sysfs_add_file_to_group+0x88/0xd8
> > >   etm_perf_add_symlink_sink+0xcc/0x138
> > >   coresight_register+0x110/0x280
> > >   tmc_probe+0x160/0x420
> > >
> > >  [ trimmed ]
> > >
> > >  ---[ end trace ab4cc669615ba1b0 ]---
> > >
> > > Fix this by initialising the dynamically allocated attribute properly.
> > >
> > > Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> > > Fixes: bb8e370bdc141ddf ("coresight: perf: Add "sinks" group to PMU directory")
> >
> > That should be:
> > Fixes: bb8e370bdc14 ("coresight: perf: Add "sinks" group to PMU directory")
> 
> Apologies - I will catch those from hereon.
> 
> >
> > I can go fix it up...
> 
> Or I can, depending on if you're going to pick the patch as a fix for
> 5.3 or you'll wait for the 5.4 cycle.

It's already queued up for my next round of patches to Linus to be
during the 5.3-rc cycle.

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
index 5c1ca0df5cb0..84f1dcb69827 100644
--- a/drivers/hwtracing/coresight/coresight-etm-perf.c
+++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
@@ -544,6 +544,7 @@  int etm_perf_add_symlink_sink(struct coresight_device *csdev)
 	/* See function coresight_get_sink_by_id() to know where this is used */
 	hash = hashlen_hash(hashlen_string(NULL, name));
 
+	sysfs_attr_init(&ea->attr.attr);
 	ea->attr.attr.name = devm_kstrdup(dev, name, GFP_KERNEL);
 	if (!ea->attr.attr.name)
 		return -ENOMEM;