| Message ID | 20190731223233.GA15900@taurus.defre.kleine-koenig.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 644763224169e9ca2e3010c24bf4b81a6be64959 |
| Headers | show |
| Series | [v2] ARM: kirkwood: ts219: disable the SoC's RTC | expand |
* Uwe Kleine-König <uwe@kleine-koenig.org> [2019-08-01 00:32]: > The internal RTC doesn't work, loading the driver only yields > > rtc-mv f1010300.rtc: internal RTC not ticking > > . So disable it. > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> Acked-by: Martin Michlmayr <tbm@cyrius.com> This solves an issue I reported back in 2009, as Oliver Hartkopp pointed out to my privately: https://linux-arm-kernel.infradead.narkive.com/jySn4Wsw/patch-kirkwood-don-t-initialize-marvell-rtc-for-all-boards (I contributed to the QNAP board support file in past but that was replaced by the DT files.)
On 01/08/2019 00:32:33+0200, Uwe Kleine-König wrote: > The internal RTC doesn't work, loading the driver only yields > > rtc-mv f1010300.rtc: internal RTC not ticking > > . So disable it. > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > --- > Hello, > > This patch is (one) result of a discussion on the rtc list. v1 was sent > there only. This v2 is just a resend to the mvebu maintainers. > > Alexandre Belloni said to v1: Seems good to me then. > > This sounds a bit like an ack, but I didn't add it as it was not > explicit. > > Best regards > Uwe > > arch/arm/boot/dts/kirkwood-ts219.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi > index a88eb22070a1..994cabcf4b51 100644 > --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi > +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi > @@ -104,3 +104,11 @@ > &pcie0 { > status = "okay"; > }; > + > +&rtc { > + /* > + * There is a s35390a available on the i2c bus, the internal rtc isn't > + * working (probably no crystal assembled). > + */ > + status = "disabled"; > +}; > -- > 2.20.1
Hi Uwe Kleine-König, > The internal RTC doesn't work, loading the driver only yields > > rtc-mv f1010300.rtc: internal RTC not ticking > > . So disable it. > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> Applied on mvebu/dt with both acked-by Thanks, Gregory > --- > Hello, > > This patch is (one) result of a discussion on the rtc list. v1 was sent > there only. This v2 is just a resend to the mvebu maintainers. > > Alexandre Belloni said to v1: Seems good to me then. > > This sounds a bit like an ack, but I didn't add it as it was not > explicit. > > Best regards > Uwe > > arch/arm/boot/dts/kirkwood-ts219.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi > index a88eb22070a1..994cabcf4b51 100644 > --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi > +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi > @@ -104,3 +104,11 @@ > &pcie0 { > status = "okay"; > }; > + > +&rtc { > + /* > + * There is a s35390a available on the i2c bus, the internal rtc isn't > + * working (probably no crystal assembled). > + */ > + status = "disabled"; > +}; > -- > 2.20.1
diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi index a88eb22070a1..994cabcf4b51 100644 --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi @@ -104,3 +104,11 @@ &pcie0 { status = "okay"; }; + +&rtc { + /* + * There is a s35390a available on the i2c bus, the internal rtc isn't + * working (probably no crystal assembled). + */ + status = "disabled"; +};