| Message ID | 20190802012248.GA22622@embeddedor (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | PCI: Mark expected switch fall-through | expand |
On Thu, Aug 01, 2019 at 08:22:48PM -0500, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: allmodconfig i386): > > drivers/pci/hotplug/ibmphp_res.c: In function ‘update_bridge_ranges’: > drivers/pci/hotplug/ibmphp_res.c:1943:16: warning: this statement may fall through [-Wimplicit-fallthrough=] > function = 0x8; > ~~~~~~~~~^~~~~ > drivers/pci/hotplug/ibmphp_res.c:1944:6: note: here > case PCI_HEADER_TYPE_MULTIBRIDGE: > ^~~~ > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Reviewed-by: Kees Cook <keescook@chromium.org> -Kees > --- > drivers/pci/hotplug/ibmphp_res.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/hotplug/ibmphp_res.c b/drivers/pci/hotplug/ibmphp_res.c > index 5e8caf7a4452..1e1ba66cfd1e 100644 > --- a/drivers/pci/hotplug/ibmphp_res.c > +++ b/drivers/pci/hotplug/ibmphp_res.c > @@ -1941,6 +1941,7 @@ static int __init update_bridge_ranges(struct bus_node **bus) > break; > case PCI_HEADER_TYPE_BRIDGE: > function = 0x8; > + /* Fall through */ > case PCI_HEADER_TYPE_MULTIBRIDGE: > /* We assume here that only 1 bus behind the bridge > TO DO: add functionality for several: > -- > 2.22.0 >
On Thu, Aug 01, 2019 at 08:22:48PM -0500, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: allmodconfig i386): > > drivers/pci/hotplug/ibmphp_res.c: In function ‘update_bridge_ranges’: > drivers/pci/hotplug/ibmphp_res.c:1943:16: warning: this statement may fall through [-Wimplicit-fallthrough=] > function = 0x8; > ~~~~~~~~~^~~~~ > drivers/pci/hotplug/ibmphp_res.c:1944:6: note: here > case PCI_HEADER_TYPE_MULTIBRIDGE: > ^~~~ > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Applied with Kees' reviewed-by to pci/misc for v5.4, thanks, Gustavo! > --- > drivers/pci/hotplug/ibmphp_res.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/hotplug/ibmphp_res.c b/drivers/pci/hotplug/ibmphp_res.c > index 5e8caf7a4452..1e1ba66cfd1e 100644 > --- a/drivers/pci/hotplug/ibmphp_res.c > +++ b/drivers/pci/hotplug/ibmphp_res.c > @@ -1941,6 +1941,7 @@ static int __init update_bridge_ranges(struct bus_node **bus) > break; > case PCI_HEADER_TYPE_BRIDGE: > function = 0x8; > + /* Fall through */ > case PCI_HEADER_TYPE_MULTIBRIDGE: > /* We assume here that only 1 bus behind the bridge > TO DO: add functionality for several: > -- > 2.22.0 >
diff --git a/drivers/pci/hotplug/ibmphp_res.c b/drivers/pci/hotplug/ibmphp_res.c index 5e8caf7a4452..1e1ba66cfd1e 100644 --- a/drivers/pci/hotplug/ibmphp_res.c +++ b/drivers/pci/hotplug/ibmphp_res.c @@ -1941,6 +1941,7 @@ static int __init update_bridge_ranges(struct bus_node **bus) break; case PCI_HEADER_TYPE_BRIDGE: function = 0x8; + /* Fall through */ case PCI_HEADER_TYPE_MULTIBRIDGE: /* We assume here that only 1 bus behind the bridge TO DO: add functionality for several:
Mark switch cases where we are expecting to fall through. This patch fixes the following warning (Building: allmodconfig i386): drivers/pci/hotplug/ibmphp_res.c: In function ‘update_bridge_ranges’: drivers/pci/hotplug/ibmphp_res.c:1943:16: warning: this statement may fall through [-Wimplicit-fallthrough=] function = 0x8; ~~~~~~~~~^~~~~ drivers/pci/hotplug/ibmphp_res.c:1944:6: note: here case PCI_HEADER_TYPE_MULTIBRIDGE: ^~~~ Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/pci/hotplug/ibmphp_res.c | 1 + 1 file changed, 1 insertion(+)