| Message ID | 20190722154538.5314-2-david@lechnology.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | new driver for TI eQEP | expand |
On Mon, 22 Jul 2019 10:45:35 -0500 David Lechner <david@lechnology.com> wrote: > This documents device tree binding for the Texas Instruments Enhanced > Quadrature Encoder Pulse (eQEP) Module found in various TI SoCs. > > Signed-off-by: David Lechner <david@lechnology.com> Up to William given it is a counter binding, (unless Rob overrules) but new bindings are generally preferred as yaml. Content looks fine to me. Thanks, Jonathan > --- > .../devicetree/bindings/counter/ti-eqep.txt | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > create mode 100644 Documentation/devicetree/bindings/counter/ti-eqep.txt > > diff --git a/Documentation/devicetree/bindings/counter/ti-eqep.txt b/Documentation/devicetree/bindings/counter/ti-eqep.txt > new file mode 100644 > index 000000000000..fbcebc2c2cc2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/counter/ti-eqep.txt > @@ -0,0 +1,18 @@ > +Texas Instruments Enhanced Quadrature Encoder Pulse (eQEP) Module > + > +Required properties: > +- compatible: Must be "ti,am3352-eqep". > +- reg: Physical base address and size of the registers map. > +- clocks: Handle to the PWM's functional clock. > +- clock-names: Must be "fck". > +- interrupts: Handle to the eQEP event interrupt > + > +Example: > + > + eqep0: eqep@180 { > + compatible = "ti,am3352-eqep"; > + reg = <0x180 0x80>; > + clocks = <&l4ls_gclk>; > + clock-names = "fck"; > + interrupts = <79>; > + };
On Sat, Jul 27, 2019 at 08:48:36PM +0100, Jonathan Cameron wrote: > On Mon, 22 Jul 2019 10:45:35 -0500 > David Lechner <david@lechnology.com> wrote: > > > This documents device tree binding for the Texas Instruments Enhanced > > Quadrature Encoder Pulse (eQEP) Module found in various TI SoCs. > > > > Signed-off-by: David Lechner <david@lechnology.com> > > Up to William given it is a counter binding, (unless Rob overrules) > but new bindings are generally preferred as yaml. > > Content looks fine to me. > > Thanks, > > Jonathan Rob, Would you prefer these bindings as yaml, or shall I accept them as they are now? William Breathitt Gray > > > --- > > .../devicetree/bindings/counter/ti-eqep.txt | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/counter/ti-eqep.txt > > > > diff --git a/Documentation/devicetree/bindings/counter/ti-eqep.txt b/Documentation/devicetree/bindings/counter/ti-eqep.txt > > new file mode 100644 > > index 000000000000..fbcebc2c2cc2 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/counter/ti-eqep.txt > > @@ -0,0 +1,18 @@ > > +Texas Instruments Enhanced Quadrature Encoder Pulse (eQEP) Module > > + > > +Required properties: > > +- compatible: Must be "ti,am3352-eqep". > > +- reg: Physical base address and size of the registers map. > > +- clocks: Handle to the PWM's functional clock. > > +- clock-names: Must be "fck". > > +- interrupts: Handle to the eQEP event interrupt > > + > > +Example: > > + > > + eqep0: eqep@180 { > > + compatible = "ti,am3352-eqep"; > > + reg = <0x180 0x80>; > > + clocks = <&l4ls_gclk>; > > + clock-names = "fck"; > > + interrupts = <79>; > > + }; >
On Fri, Aug 2, 2019 at 1:25 AM William Breathitt Gray <vilhelm.gray@gmail.com> wrote: > > On Sat, Jul 27, 2019 at 08:48:36PM +0100, Jonathan Cameron wrote: > > On Mon, 22 Jul 2019 10:45:35 -0500 > > David Lechner <david@lechnology.com> wrote: > > > > > This documents device tree binding for the Texas Instruments Enhanced > > > Quadrature Encoder Pulse (eQEP) Module found in various TI SoCs. > > > > > > Signed-off-by: David Lechner <david@lechnology.com> > > > > Up to William given it is a counter binding, (unless Rob overrules) > > but new bindings are generally preferred as yaml. > > > > Content looks fine to me. > > > > Thanks, > > > > Jonathan > > Rob, > > Would you prefer these bindings as yaml, or shall I accept them as they > are now? Still up to you at this point, but I certainly prefer them to be DT schema. Rob
On Fri, Aug 02, 2019 at 07:34:42AM -0600, Rob Herring wrote: > On Fri, Aug 2, 2019 at 1:25 AM William Breathitt Gray > <vilhelm.gray@gmail.com> wrote: > > > > On Sat, Jul 27, 2019 at 08:48:36PM +0100, Jonathan Cameron wrote: > > > On Mon, 22 Jul 2019 10:45:35 -0500 > > > David Lechner <david@lechnology.com> wrote: > > > > > > > This documents device tree binding for the Texas Instruments Enhanced > > > > Quadrature Encoder Pulse (eQEP) Module found in various TI SoCs. > > > > > > > > Signed-off-by: David Lechner <david@lechnology.com> > > > > > > Up to William given it is a counter binding, (unless Rob overrules) > > > but new bindings are generally preferred as yaml. > > > > > > Content looks fine to me. > > > > > > Thanks, > > > > > > Jonathan > > > > Rob, > > > > Would you prefer these bindings as yaml, or shall I accept them as they > > are now? > > Still up to you at this point, but I certainly prefer them to be DT schema. > > Rob I think YAML would be a good idea, it's simple and expressive enough while still being human-readable, and if new bindings in other subsystems are switching to yaml then we may as well. David, resubmit this as yaml in version 2 and I'll pick it up. Thanks, William Breathitt Gray
diff --git a/Documentation/devicetree/bindings/counter/ti-eqep.txt b/Documentation/devicetree/bindings/counter/ti-eqep.txt new file mode 100644 index 000000000000..fbcebc2c2cc2 --- /dev/null +++ b/Documentation/devicetree/bindings/counter/ti-eqep.txt @@ -0,0 +1,18 @@ +Texas Instruments Enhanced Quadrature Encoder Pulse (eQEP) Module + +Required properties: +- compatible: Must be "ti,am3352-eqep". +- reg: Physical base address and size of the registers map. +- clocks: Handle to the PWM's functional clock. +- clock-names: Must be "fck". +- interrupts: Handle to the eQEP event interrupt + +Example: + + eqep0: eqep@180 { + compatible = "ti,am3352-eqep"; + reg = <0x180 0x80>; + clocks = <&l4ls_gclk>; + clock-names = "fck"; + interrupts = <79>; + };
This documents device tree binding for the Texas Instruments Enhanced Quadrature Encoder Pulse (eQEP) Module found in various TI SoCs. Signed-off-by: David Lechner <david@lechnology.com> --- .../devicetree/bindings/counter/ti-eqep.txt | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/counter/ti-eqep.txt