diff mbox series

[2/2] drm/omap: dmm_tiler: Remove the dma_async_issue_pending() call

Message ID 20190731094233.13890-3-peter.ujfalusi@ti.com (mailing list archive)
State New, archived
Headers show
Series drm/omap: dmm_tiler: Small fixes for i878 workaround | expand

Commit Message

Peter Ujfalusi July 31, 2019, 9:42 a.m. UTC
dma_sync_wait() is calling it so no need to call it in the driver.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Laurent Pinchart Aug. 4, 2019, 12:39 p.m. UTC | #1
Hi Peter,

Thank you for the patch.

On Wed, Jul 31, 2019 at 12:42:33PM +0300, Peter Ujfalusi wrote:
> dma_sync_wait() is calling it so no need to call it in the driver.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> index 77728eaa1a6f..42ec51bb7b1b 100644
> --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> @@ -98,7 +98,6 @@ static int dmm_dma_copy(struct dmm *dmm, dma_addr_t src, dma_addr_t dst)
>  		return -EIO;
>  	}
>  
> -	dma_async_issue_pending(dmm->wa_dma_chan);
>  	status = dma_sync_wait(dmm->wa_dma_chan, cookie);
>  	if (status != DMA_COMPLETE)
>  		dev_err(dmm->dev, "i878 wa DMA copy failure\n");
diff mbox series

Patch

diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
index 77728eaa1a6f..42ec51bb7b1b 100644
--- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
+++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
@@ -98,7 +98,6 @@  static int dmm_dma_copy(struct dmm *dmm, dma_addr_t src, dma_addr_t dst)
 		return -EIO;
 	}
 
-	dma_async_issue_pending(dmm->wa_dma_chan);
 	status = dma_sync_wait(dmm->wa_dma_chan, cookie);
 	if (status != DMA_COMPLETE)
 		dev_err(dmm->dev, "i878 wa DMA copy failure\n");