| Message ID | 20190805122513.8399-1-jmaneyrol@invensense.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: imu: inv_mpu6050: add header include protection macro | expand |
On Mon, 5 Aug 2019 12:25:43 +0000 Jean-Baptiste Maneyrol <JManeyrol@invensense.com> wrote: > Signed-off-by: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com> No problem with adding this, but why specifically did you do so? Thanks, Jonathan > --- > drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h > index db1c6904388b..e64eb978e810 100644 > --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h > +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h > @@ -2,6 +2,10 @@ > /* > * Copyright (C) 2012 Invensense, Inc. > */ > + > +#ifndef INV_MPU_IIO_H_ > +#define INV_MPU_IIO_H_ > + > #include <linux/i2c.h> > #include <linux/i2c-mux.h> > #include <linux/mutex.h> > @@ -342,3 +346,5 @@ void inv_mpu_acpi_delete_mux_client(struct i2c_client *client); > int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name, > int (*inv_mpu_bus_setup)(struct iio_dev *), int chip_type); > extern const struct dev_pm_ops inv_mpu_pmops; > + > +#endif
Hi Jonathan, this is required for further patches coming soon. I am planning to add support for full 9-axis on MPU9250, using the chip i2c master to drive the integrated magnetometer and retrieve all data in the MPU FIFO. It will be behind a kernel config option to not break existing support driving the magnetometer from the kernel. Hope to have this cleaned-up and ready soon. Best regards, JB From: linux-iio-owner@vger.kernel.org <linux-iio-owner@vger.kernel.org> on behalf of Jonathan Cameron <jic23@jic23.retrosnub.co.uk> Sent: Monday, August 5, 2019 18:32 To: Jean-Baptiste Maneyrol <JManeyrol@invensense.com> Cc: linux-iio@vger.kernel.org <linux-iio@vger.kernel.org> Subject: Re: [PATCH] iio: imu: inv_mpu6050: add header include protection macro CAUTION: This email originated from outside of the organization. Please make sure the sender is who they say they are and do not click links or open attachments unless you recognize the sender and know the content is safe. On Mon, 5 Aug 2019 12:25:43 +0000 Jean-Baptiste Maneyrol <JManeyrol@invensense.com> wrote: > Signed-off-by: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com> No problem with adding this, but why specifically did you do so? Thanks, Jonathan > --- > drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h > index db1c6904388b..e64eb978e810 100644 > --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h > +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h > @@ -2,6 +2,10 @@ > /* > * Copyright (C) 2012 Invensense, Inc. > */ > + > +#ifndef INV_MPU_IIO_H_ > +#define INV_MPU_IIO_H_ > + > #include <linux/i2c.h> > #include <linux/i2c-mux.h> > #include <linux/mutex.h> > @@ -342,3 +346,5 @@ void inv_mpu_acpi_delete_mux_client(struct i2c_client *client); > int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name, > int (*inv_mpu_bus_setup)(struct iio_dev *), int chip_type); > extern const struct dev_pm_ops inv_mpu_pmops; > + > +#endif
On Tue, 6 Aug 2019 08:05:09 +0000 Jean-Baptiste Maneyrol <JManeyrol@invensense.com> wrote: > Hi Jonathan, > > this is required for further patches coming soon. > > I am planning to add support for full 9-axis on MPU9250, using the chip i2c master to drive the integrated magnetometer and retrieve all data in the MPU FIFO. It will be behind a kernel config option to not break existing support driving the magnetometer from the kernel. > > Hope to have this cleaned-up and ready soon. OK. Just send this one as a precursor in that series as then the purpose should be obvious. Thanks, Jonathan > > Best regards, > JB > > From: linux-iio-owner@vger.kernel.org <linux-iio-owner@vger.kernel.org> on behalf of Jonathan Cameron <jic23@jic23.retrosnub.co.uk> > > Sent: Monday, August 5, 2019 18:32 > > To: Jean-Baptiste Maneyrol <JManeyrol@invensense.com> > > Cc: linux-iio@vger.kernel.org <linux-iio@vger.kernel.org> > > Subject: Re: [PATCH] iio: imu: inv_mpu6050: add header include protection macro > > > > > CAUTION: This email originated from outside of the organization. Please make sure the sender is who they say they are and do not click links or open attachments unless you recognize the sender and know the content is safe. > > > > On Mon, 5 Aug 2019 12:25:43 +0000 > > Jean-Baptiste Maneyrol <JManeyrol@invensense.com> wrote: > > > > > Signed-off-by: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com> > > No problem with adding this, but why specifically did you do so? > > > > Thanks, > > > > Jonathan > > > > > --- > > > drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h > > > index db1c6904388b..e64eb978e810 100644 > > > --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h > > > +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h > > > @@ -2,6 +2,10 @@ > > > /* > > > * Copyright (C) 2012 Invensense, Inc. > > > */ > > > + > > > +#ifndef INV_MPU_IIO_H_ > > > +#define INV_MPU_IIO_H_ > > > + > > > #include <linux/i2c.h> > > > #include <linux/i2c-mux.h> > > > #include <linux/mutex.h> > > > @@ -342,3 +346,5 @@ void inv_mpu_acpi_delete_mux_client(struct i2c_client *client); > > > int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name, > > > int (*inv_mpu_bus_setup)(struct iio_dev *), int chip_type); > > > extern const struct dev_pm_ops inv_mpu_pmops; > > > + > > > +#endif > > >
diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h index db1c6904388b..e64eb978e810 100644 --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h @@ -2,6 +2,10 @@ /* * Copyright (C) 2012 Invensense, Inc. */ + +#ifndef INV_MPU_IIO_H_ +#define INV_MPU_IIO_H_ + #include <linux/i2c.h> #include <linux/i2c-mux.h> #include <linux/mutex.h> @@ -342,3 +346,5 @@ void inv_mpu_acpi_delete_mux_client(struct i2c_client *client); int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name, int (*inv_mpu_bus_setup)(struct iio_dev *), int chip_type); extern const struct dev_pm_ops inv_mpu_pmops; + +#endif
Signed-off-by: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com> --- drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 6 ++++++ 1 file changed, 6 insertions(+)