| Message ID | 20190802065905.45239-3-parav@mellanox.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Simplify mtty driver and mdev core | expand |
On Fri, 2 Aug 2019 01:59:05 -0500 Parav Pandit <parav@mellanox.com> wrote: > There is no single production driver who is interested in mdev device > name. > Additionally mdev device name is already available using core kernel > API dev_name(). The patch description is a bit confusing: You talk about removing an api to access the device name, but what you are actually removing is the api to access the device's uuid. That uuid is, of course, used to generate the device name, but the two are not the same. Using dev_name() gives you a string containing the uuid, not the uuid. > > Hence removed unused exported symbol. I'm not really against removing this api if no driver has interest in the device's uuid (and I'm currently not seeing why they would need it; we can easily add it back, should the need arise); but this needs a different description. > > Signed-off-by: Parav Pandit <parav@mellanox.com> > --- > drivers/vfio/mdev/mdev_core.c | 6 ------ > include/linux/mdev.h | 1 - > 2 files changed, 7 deletions(-) > > diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c > index b558d4cfd082..c2b809cbe59f 100644 > --- a/drivers/vfio/mdev/mdev_core.c > +++ b/drivers/vfio/mdev/mdev_core.c > @@ -57,12 +57,6 @@ struct mdev_device *mdev_from_dev(struct device *dev) > } > EXPORT_SYMBOL(mdev_from_dev); > > -const guid_t *mdev_uuid(struct mdev_device *mdev) > -{ > - return &mdev->uuid; > -} > -EXPORT_SYMBOL(mdev_uuid); > - > /* Should be called holding parent_list_lock */ > static struct mdev_parent *__find_parent_device(struct device *dev) > { > diff --git a/include/linux/mdev.h b/include/linux/mdev.h > index 0ce30ca78db0..375a5830c3d8 100644 > --- a/include/linux/mdev.h > +++ b/include/linux/mdev.h > @@ -131,7 +131,6 @@ struct mdev_driver { > > void *mdev_get_drvdata(struct mdev_device *mdev); > void mdev_set_drvdata(struct mdev_device *mdev, void *data); > -const guid_t *mdev_uuid(struct mdev_device *mdev); > > extern struct bus_type mdev_bus_type; >
> -----Original Message----- > From: Cornelia Huck <cohuck@redhat.com> > Sent: Tuesday, August 6, 2019 1:59 PM > To: Parav Pandit <parav@mellanox.com> > Cc: kvm@vger.kernel.org; wankhede@nvidia.com; linux- > kernel@vger.kernel.org; alex.williamson@redhat.com; cjia@nvidia.com > Subject: Re: [PATCH 2/2] vfio/mdev: Removed unused and redundant API for > mdev name > > On Fri, 2 Aug 2019 01:59:05 -0500 > Parav Pandit <parav@mellanox.com> wrote: > > > There is no single production driver who is interested in mdev device > > name. > > Additionally mdev device name is already available using core kernel > > API dev_name(). > > The patch description is a bit confusing: You talk about removing an api to > access the device name, but what you are actually removing is the api to access > the device's uuid. That uuid is, of course, used to generate the device name, but > the two are not the same. Using > dev_name() gives you a string containing the uuid, not the uuid. > > > > > Hence removed unused exported symbol. > > I'm not really against removing this api if no driver has interest in the device's > uuid (and I'm currently not seeing why they would need it; we can easily add it > back, should the need arise); but this needs a different description. > Ok. I understand that uuid and dev_name() are not same. I will update the commit description. Sending v1. > > > > Signed-off-by: Parav Pandit <parav@mellanox.com> > > --- > > drivers/vfio/mdev/mdev_core.c | 6 ------ > > include/linux/mdev.h | 1 - > > 2 files changed, 7 deletions(-) > > > > diff --git a/drivers/vfio/mdev/mdev_core.c > > b/drivers/vfio/mdev/mdev_core.c index b558d4cfd082..c2b809cbe59f > > 100644 > > --- a/drivers/vfio/mdev/mdev_core.c > > +++ b/drivers/vfio/mdev/mdev_core.c > > @@ -57,12 +57,6 @@ struct mdev_device *mdev_from_dev(struct device > > *dev) } EXPORT_SYMBOL(mdev_from_dev); > > > > -const guid_t *mdev_uuid(struct mdev_device *mdev) -{ > > - return &mdev->uuid; > > -} > > -EXPORT_SYMBOL(mdev_uuid); > > - > > /* Should be called holding parent_list_lock */ static struct > > mdev_parent *__find_parent_device(struct device *dev) { diff --git > > a/include/linux/mdev.h b/include/linux/mdev.h index > > 0ce30ca78db0..375a5830c3d8 100644 > > --- a/include/linux/mdev.h > > +++ b/include/linux/mdev.h > > @@ -131,7 +131,6 @@ struct mdev_driver { > > > > void *mdev_get_drvdata(struct mdev_device *mdev); void > > mdev_set_drvdata(struct mdev_device *mdev, void *data); -const guid_t > > *mdev_uuid(struct mdev_device *mdev); > > > > extern struct bus_type mdev_bus_type; > >
diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c index b558d4cfd082..c2b809cbe59f 100644 --- a/drivers/vfio/mdev/mdev_core.c +++ b/drivers/vfio/mdev/mdev_core.c @@ -57,12 +57,6 @@ struct mdev_device *mdev_from_dev(struct device *dev) } EXPORT_SYMBOL(mdev_from_dev); -const guid_t *mdev_uuid(struct mdev_device *mdev) -{ - return &mdev->uuid; -} -EXPORT_SYMBOL(mdev_uuid); - /* Should be called holding parent_list_lock */ static struct mdev_parent *__find_parent_device(struct device *dev) { diff --git a/include/linux/mdev.h b/include/linux/mdev.h index 0ce30ca78db0..375a5830c3d8 100644 --- a/include/linux/mdev.h +++ b/include/linux/mdev.h @@ -131,7 +131,6 @@ struct mdev_driver { void *mdev_get_drvdata(struct mdev_device *mdev); void mdev_set_drvdata(struct mdev_device *mdev, void *data); -const guid_t *mdev_uuid(struct mdev_device *mdev); extern struct bus_type mdev_bus_type;
There is no single production driver who is interested in mdev device name. Additionally mdev device name is already available using core kernel API dev_name(). Hence removed unused exported symbol. Signed-off-by: Parav Pandit <parav@mellanox.com> --- drivers/vfio/mdev/mdev_core.c | 6 ------ include/linux/mdev.h | 1 - 2 files changed, 7 deletions(-)