| Message ID | 20190805170451.26009-4-joel@joelfernandes.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v4,1/5] mm/page_idle: Add per-pid idle page tracking using virtual indexing | expand |
On Mon 05-08-19 13:04:50, Joel Fernandes (Google) wrote: > During idle tracking, we see that sometimes faulted anon pages are in > pagevec but are not drained to LRU. Idle tracking considers pages only > on LRU. Drain all CPU's LRU before starting idle tracking. Please expand on why does this matter enough to introduce a potentially expensinve draining which has to schedule a work on each CPU and wait for them to finish. > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> > --- > mm/page_idle.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/mm/page_idle.c b/mm/page_idle.c > index a5b00d63216c..2972367a599f 100644 > --- a/mm/page_idle.c > +++ b/mm/page_idle.c > @@ -180,6 +180,8 @@ static ssize_t page_idle_bitmap_read(struct file *file, struct kobject *kobj, > unsigned long pfn, end_pfn; > int bit, ret; > > + lru_add_drain_all(); > + > ret = page_idle_get_frames(pos, count, NULL, &pfn, &end_pfn); > if (ret == -ENXIO) > return 0; /* Reads beyond max_pfn do nothing */ > @@ -211,6 +213,8 @@ static ssize_t page_idle_bitmap_write(struct file *file, struct kobject *kobj, > unsigned long pfn, end_pfn; > int bit, ret; > > + lru_add_drain_all(); > + > ret = page_idle_get_frames(pos, count, NULL, &pfn, &end_pfn); > if (ret) > return ret; > @@ -428,6 +432,8 @@ ssize_t page_idle_proc_generic(struct file *file, char __user *ubuff, > walk.private = &priv; > walk.mm = mm; > > + lru_add_drain_all(); > + > down_read(&mm->mmap_sem); > > /* > -- > 2.22.0.770.g0f2c4a37fd-goog
On Tue, Aug 06, 2019 at 10:43:57AM +0200, Michal Hocko wrote: > On Mon 05-08-19 13:04:50, Joel Fernandes (Google) wrote: > > During idle tracking, we see that sometimes faulted anon pages are in > > pagevec but are not drained to LRU. Idle tracking considers pages only > > on LRU. Drain all CPU's LRU before starting idle tracking. > > Please expand on why does this matter enough to introduce a potentially > expensinve draining which has to schedule a work on each CPU and wait > for them to finish. Sure, I can expand. I am able to find multiple issues involving this. One issue looks like idle tracking is completely broken. It shows up in my testing as if a page that is marked as idle is always "accessed" -- because it was never marked as idle (due to not draining of pagevec). The other issue shows up as a failure in my "swap test", with the following sequence: 1. Allocate some pages 2. Write to them 3. Mark them as idle <--- fails 4. Introduce some memory pressure to induce swapping. 5. Check the swap bit I introduced in this series. <--- fails to set idle bit in swap PTE. Draining the pagevec in advance fixes both of these issues. This operation even if expensive is only done once during the access of the page_idle file. Did you have a better fix in mind? thanks, - Joel > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> > > --- > > mm/page_idle.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/mm/page_idle.c b/mm/page_idle.c > > index a5b00d63216c..2972367a599f 100644 > > --- a/mm/page_idle.c > > +++ b/mm/page_idle.c > > @@ -180,6 +180,8 @@ static ssize_t page_idle_bitmap_read(struct file *file, struct kobject *kobj, > > unsigned long pfn, end_pfn; > > int bit, ret; > > > > + lru_add_drain_all(); > > + > > ret = page_idle_get_frames(pos, count, NULL, &pfn, &end_pfn); > > if (ret == -ENXIO) > > return 0; /* Reads beyond max_pfn do nothing */ > > @@ -211,6 +213,8 @@ static ssize_t page_idle_bitmap_write(struct file *file, struct kobject *kobj, > > unsigned long pfn, end_pfn; > > int bit, ret; > > > > + lru_add_drain_all(); > > + > > ret = page_idle_get_frames(pos, count, NULL, &pfn, &end_pfn); > > if (ret) > > return ret; > > @@ -428,6 +432,8 @@ ssize_t page_idle_proc_generic(struct file *file, char __user *ubuff, > > walk.private = &priv; > > walk.mm = mm; > > > > + lru_add_drain_all(); > > + > > down_read(&mm->mmap_sem); > > > > /* > > -- > > 2.22.0.770.g0f2c4a37fd-goog > > -- > Michal Hocko > SUSE Labs
On Tue 06-08-19 06:45:54, Joel Fernandes wrote: > On Tue, Aug 06, 2019 at 10:43:57AM +0200, Michal Hocko wrote: > > On Mon 05-08-19 13:04:50, Joel Fernandes (Google) wrote: > > > During idle tracking, we see that sometimes faulted anon pages are in > > > pagevec but are not drained to LRU. Idle tracking considers pages only > > > on LRU. Drain all CPU's LRU before starting idle tracking. > > > > Please expand on why does this matter enough to introduce a potentially > > expensinve draining which has to schedule a work on each CPU and wait > > for them to finish. > > Sure, I can expand. I am able to find multiple issues involving this. One > issue looks like idle tracking is completely broken. It shows up in my > testing as if a page that is marked as idle is always "accessed" -- because > it was never marked as idle (due to not draining of pagevec). > > The other issue shows up as a failure in my "swap test", with the following > sequence: > 1. Allocate some pages > 2. Write to them > 3. Mark them as idle <--- fails > 4. Introduce some memory pressure to induce swapping. > 5. Check the swap bit I introduced in this series. <--- fails to set idle > bit in swap PTE. > > Draining the pagevec in advance fixes both of these issues. This belongs to the changelog. > This operation even if expensive is only done once during the access of the > page_idle file. Did you have a better fix in mind? Can we set the idle bit also for non-lru pages as long as they are reachable via pte?
On Tue, Aug 06, 2019 at 12:51:49PM +0200, Michal Hocko wrote: > On Tue 06-08-19 06:45:54, Joel Fernandes wrote: > > On Tue, Aug 06, 2019 at 10:43:57AM +0200, Michal Hocko wrote: > > > On Mon 05-08-19 13:04:50, Joel Fernandes (Google) wrote: > > > > During idle tracking, we see that sometimes faulted anon pages are in > > > > pagevec but are not drained to LRU. Idle tracking considers pages only > > > > on LRU. Drain all CPU's LRU before starting idle tracking. > > > > > > Please expand on why does this matter enough to introduce a potentially > > > expensinve draining which has to schedule a work on each CPU and wait > > > for them to finish. > > > > Sure, I can expand. I am able to find multiple issues involving this. One > > issue looks like idle tracking is completely broken. It shows up in my > > testing as if a page that is marked as idle is always "accessed" -- because > > it was never marked as idle (due to not draining of pagevec). > > > > The other issue shows up as a failure in my "swap test", with the following > > sequence: > > 1. Allocate some pages > > 2. Write to them > > 3. Mark them as idle <--- fails > > 4. Introduce some memory pressure to induce swapping. > > 5. Check the swap bit I introduced in this series. <--- fails to set idle > > bit in swap PTE. > > > > Draining the pagevec in advance fixes both of these issues. > > This belongs to the changelog. Sure, will add. > > This operation even if expensive is only done once during the access of the > > page_idle file. Did you have a better fix in mind? > > Can we set the idle bit also for non-lru pages as long as they are > reachable via pte? Not at the moment with the current page idle tracking code. PageLRU(page) flag is checked in page_idle_get_page(). Even if we could set it for non-LRU, the idle bit (page flag) would not be cleared if page is not on LRU because page-reclaim code (page_referenced() I believe) would not clear it. This whole mechanism depends on page-reclaim. Or did I miss your point? thanks, - Joel
On Tue 06-08-19 07:19:21, Joel Fernandes wrote: > On Tue, Aug 06, 2019 at 12:51:49PM +0200, Michal Hocko wrote: > > On Tue 06-08-19 06:45:54, Joel Fernandes wrote: > > > On Tue, Aug 06, 2019 at 10:43:57AM +0200, Michal Hocko wrote: > > > > On Mon 05-08-19 13:04:50, Joel Fernandes (Google) wrote: > > > > > During idle tracking, we see that sometimes faulted anon pages are in > > > > > pagevec but are not drained to LRU. Idle tracking considers pages only > > > > > on LRU. Drain all CPU's LRU before starting idle tracking. > > > > > > > > Please expand on why does this matter enough to introduce a potentially > > > > expensinve draining which has to schedule a work on each CPU and wait > > > > for them to finish. > > > > > > Sure, I can expand. I am able to find multiple issues involving this. One > > > issue looks like idle tracking is completely broken. It shows up in my > > > testing as if a page that is marked as idle is always "accessed" -- because > > > it was never marked as idle (due to not draining of pagevec). > > > > > > The other issue shows up as a failure in my "swap test", with the following > > > sequence: > > > 1. Allocate some pages > > > 2. Write to them > > > 3. Mark them as idle <--- fails > > > 4. Introduce some memory pressure to induce swapping. > > > 5. Check the swap bit I introduced in this series. <--- fails to set idle > > > bit in swap PTE. > > > > > > Draining the pagevec in advance fixes both of these issues. > > > > This belongs to the changelog. > > Sure, will add. > > > > > This operation even if expensive is only done once during the access of the > > > page_idle file. Did you have a better fix in mind? > > > > Can we set the idle bit also for non-lru pages as long as they are > > reachable via pte? > > Not at the moment with the current page idle tracking code. PageLRU(page) > flag is checked in page_idle_get_page(). yes, I am aware of the current code. I strongly suspect that the PageLRU check was there to not mark arbitrary page looked up by pfn with the idle bit because that would be unexpected. But I might be easily wrong here. > Even if we could set it for non-LRU, the idle bit (page flag) would not be > cleared if page is not on LRU because page-reclaim code (page_referenced() I > believe) would not clear it. Yes, it is either reclaim when checking references as you say but also mark_page_accessed. I believe the later might still have the page on the pcp LRU add cache. Maybe I am missing something something but it seems that there is nothing fundamentally requiring the user mapped page to be on the LRU list when seting the idle bit. That being said, your big hammer approach will work more reliable but if you do not feel like changing the underlying PageLRU assumption then document that draining should be removed longterm.
On Tue, Aug 06, 2019 at 01:44:02PM +0200, Michal Hocko wrote: [snip] > > > > This operation even if expensive is only done once during the access of the > > > > page_idle file. Did you have a better fix in mind? > > > > > > Can we set the idle bit also for non-lru pages as long as they are > > > reachable via pte? > > > > Not at the moment with the current page idle tracking code. PageLRU(page) > > flag is checked in page_idle_get_page(). > > yes, I am aware of the current code. I strongly suspect that the PageLRU > check was there to not mark arbitrary page looked up by pfn with the > idle bit because that would be unexpected. But I might be easily wrong > here. Yes, quite possible. > > Even if we could set it for non-LRU, the idle bit (page flag) would not be > > cleared if page is not on LRU because page-reclaim code (page_referenced() I > > believe) would not clear it. > > Yes, it is either reclaim when checking references as you say but also > mark_page_accessed. I believe the later might still have the page on the > pcp LRU add cache. Maybe I am missing something something but it seems > that there is nothing fundamentally requiring the user mapped page to be > on the LRU list when seting the idle bit. > > That being said, your big hammer approach will work more reliable but if > you do not feel like changing the underlying PageLRU assumption then > document that draining should be removed longterm. Yes, at the moment I am in preference of keeping the underlying assumption same. I am Ok with adding of a comment on the drain call that it is to be removed longterm. thanks, - Joel
diff --git a/mm/page_idle.c b/mm/page_idle.c index a5b00d63216c..2972367a599f 100644 --- a/mm/page_idle.c +++ b/mm/page_idle.c @@ -180,6 +180,8 @@ static ssize_t page_idle_bitmap_read(struct file *file, struct kobject *kobj, unsigned long pfn, end_pfn; int bit, ret; + lru_add_drain_all(); + ret = page_idle_get_frames(pos, count, NULL, &pfn, &end_pfn); if (ret == -ENXIO) return 0; /* Reads beyond max_pfn do nothing */ @@ -211,6 +213,8 @@ static ssize_t page_idle_bitmap_write(struct file *file, struct kobject *kobj, unsigned long pfn, end_pfn; int bit, ret; + lru_add_drain_all(); + ret = page_idle_get_frames(pos, count, NULL, &pfn, &end_pfn); if (ret) return ret; @@ -428,6 +432,8 @@ ssize_t page_idle_proc_generic(struct file *file, char __user *ubuff, walk.private = &priv; walk.mm = mm; + lru_add_drain_all(); + down_read(&mm->mmap_sem); /*
During idle tracking, we see that sometimes faulted anon pages are in pagevec but are not drained to LRU. Idle tracking considers pages only on LRU. Drain all CPU's LRU before starting idle tracking. Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> --- mm/page_idle.c | 6 ++++++ 1 file changed, 6 insertions(+)