| Message ID | 20190704142032.10745-1-fugang.duan@nxp.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | a3c59cf2971088c4bf889d8c093990ebf59fb789 |
| Headers | show |
| Series | [nvmem,1/1] nvmem: imx: add i.MX8QM platform support | expand |
Ping... > From: Fugang Duan <fugang.duan@nxp.com> > > i.MX8QM efuse table has some difference with i.MX8QXP platform, so add > i.MX8QM platform support. > > Signed-off-by: Fugang Duan <fugang.duan@nxp.com> > --- > drivers/nvmem/imx-ocotp-scu.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/nvmem/imx-ocotp-scu.c b/drivers/nvmem/imx-ocotp-scu.c > index be2f5f0..0d78ab4 100644 > --- a/drivers/nvmem/imx-ocotp-scu.c > +++ b/drivers/nvmem/imx-ocotp-scu.c > @@ -16,6 +16,7 @@ > > enum ocotp_devtype { > IMX8QXP, > + IMX8QM, > }; > > struct ocotp_devtype_data { > @@ -39,6 +40,11 @@ static struct ocotp_devtype_data imx8qxp_data = { > .nregs = 800, > }; > > +static struct ocotp_devtype_data imx8qm_data = { > + .devtype = IMX8QM, > + .nregs = 800, > +}; > + > static int imx_sc_misc_otp_fuse_read(struct imx_sc_ipc *ipc, u32 word, > u32 *val) > { > @@ -118,6 +124,7 @@ static struct nvmem_config > imx_scu_ocotp_nvmem_config = { > > static const struct of_device_id imx_scu_ocotp_dt_ids[] = { > { .compatible = "fsl,imx8qxp-scu-ocotp", (void *)&imx8qxp_data }, > + { .compatible = "fsl,imx8qm-scu-ocotp", (void *)&imx8qm_data }, > { }, > }; > MODULE_DEVICE_TABLE(of, imx_scu_ocotp_dt_ids); > -- > 2.7.4
On Mon, Jul 15, 2019 at 05:34:47AM +0000, Andy Duan wrote:
> Ping...
It's the middle of the merge window, we can't do anything with any
patches until after that. Please be patient.
greg k-h
From: gregkh@linuxfoundation.org <gregkh@linuxfoundation.org> Sent: Monday, July 15, 2019 3:37 PM > On Mon, Jul 15, 2019 at 05:34:47AM +0000, Andy Duan wrote: > > Ping... > > It's the middle of the merge window, we can't do anything with any patches > until after that. Please be patient. > > greg k-h Thanks for kindly reminder !
On 04/07/2019 15:20, fugang.duan@nxp.com wrote: > From: Fugang Duan <fugang.duan@nxp.com> > > i.MX8QM efuse table has some difference with i.MX8QXP platform, > so add i.MX8QM platform support. > > Signed-off-by: Fugang Duan <fugang.duan@nxp.com> > --- > drivers/nvmem/imx-ocotp-scu.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/nvmem/imx-ocotp-scu.c b/drivers/nvmem/imx-ocotp-scu.c > index be2f5f0..0d78ab4 100644 > --- a/drivers/nvmem/imx-ocotp-scu.c > +++ b/drivers/nvmem/imx-ocotp-scu.c > @@ -16,6 +16,7 @@ > > enum ocotp_devtype { > IMX8QXP, > + IMX8QM, > }; > > struct ocotp_devtype_data { > @@ -39,6 +40,11 @@ static struct ocotp_devtype_data imx8qxp_data = { > .nregs = 800, > }; > > +static struct ocotp_devtype_data imx8qm_data = { > + .devtype = IMX8QM, > + .nregs = 800, > +}; > + > static int imx_sc_misc_otp_fuse_read(struct imx_sc_ipc *ipc, u32 word, > u32 *val) > { > @@ -118,6 +124,7 @@ static struct nvmem_config imx_scu_ocotp_nvmem_config = { > > static const struct of_device_id imx_scu_ocotp_dt_ids[] = { > { .compatible = "fsl,imx8qxp-scu-ocotp", (void *)&imx8qxp_data }, > + { .compatible = "fsl,imx8qm-scu-ocotp", (void *)&imx8qm_data }, > { }, Looks like you forgot to add this new compatible to device tree bindings at ./Documentation/devicetree/bindings/nvmem/imx-ocotp.txt or forgot to add me to CC. Please resend the patch with it, I can not apply this as it is. Thanks, srini > }; > MODULE_DEVICE_TABLE(of, imx_scu_ocotp_dt_ids); >
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Sent: Tuesday, August 6, 2019 6:04 PM > On 04/07/2019 15:20, fugang.duan@nxp.com wrote: > > From: Fugang Duan <fugang.duan@nxp.com> > > > > i.MX8QM efuse table has some difference with i.MX8QXP platform, so add > > i.MX8QM platform support. > > > > Signed-off-by: Fugang Duan <fugang.duan@nxp.com> > > --- > > drivers/nvmem/imx-ocotp-scu.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/nvmem/imx-ocotp-scu.c > > b/drivers/nvmem/imx-ocotp-scu.c index be2f5f0..0d78ab4 100644 > > --- a/drivers/nvmem/imx-ocotp-scu.c > > +++ b/drivers/nvmem/imx-ocotp-scu.c > > @@ -16,6 +16,7 @@ > > > > enum ocotp_devtype { > > IMX8QXP, > > + IMX8QM, > > }; > > > > struct ocotp_devtype_data { > > @@ -39,6 +40,11 @@ static struct ocotp_devtype_data imx8qxp_data = { > > .nregs = 800, > > }; > > > > +static struct ocotp_devtype_data imx8qm_data = { > > + .devtype = IMX8QM, > > + .nregs = 800, > > +}; > > + > > static int imx_sc_misc_otp_fuse_read(struct imx_sc_ipc *ipc, u32 word, > > u32 *val) > > { > > @@ -118,6 +124,7 @@ static struct nvmem_config > > imx_scu_ocotp_nvmem_config = { > > > > static const struct of_device_id imx_scu_ocotp_dt_ids[] = { > > { .compatible = "fsl,imx8qxp-scu-ocotp", (void *)&imx8qxp_data > > }, > > + { .compatible = "fsl,imx8qm-scu-ocotp", (void *)&imx8qm_data }, > > { }, > > Looks like you forgot to add this new compatible to device tree bindings > at ./Documentation/devicetree/bindings/nvmem/imx-ocotp.txt or forgot to > add me to CC. > > Please resend the patch with it, I can not apply this as it is. > > Thanks, > srini Thanks for your review. I will send the V2 version including the separated device tree bindings patch. > > > }; > > MODULE_DEVICE_TABLE(of, imx_scu_ocotp_dt_ids); > >
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Sent: Tuesday, August 6, 2019 6:04 PM > On 04/07/2019 15:20, fugang.duan@nxp.com wrote: > > From: Fugang Duan <fugang.duan@nxp.com> > > > > i.MX8QM efuse table has some difference with i.MX8QXP platform, so add > > i.MX8QM platform support. > > > > Signed-off-by: Fugang Duan <fugang.duan@nxp.com> > > --- > > drivers/nvmem/imx-ocotp-scu.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/nvmem/imx-ocotp-scu.c > > b/drivers/nvmem/imx-ocotp-scu.c index be2f5f0..0d78ab4 100644 > > --- a/drivers/nvmem/imx-ocotp-scu.c > > +++ b/drivers/nvmem/imx-ocotp-scu.c > > @@ -16,6 +16,7 @@ > > > > enum ocotp_devtype { > > IMX8QXP, > > + IMX8QM, > > }; > > > > struct ocotp_devtype_data { > > @@ -39,6 +40,11 @@ static struct ocotp_devtype_data imx8qxp_data = { > > .nregs = 800, > > }; > > > > +static struct ocotp_devtype_data imx8qm_data = { > > + .devtype = IMX8QM, > > + .nregs = 800, > > +}; > > + > > static int imx_sc_misc_otp_fuse_read(struct imx_sc_ipc *ipc, u32 word, > > u32 *val) > > { > > @@ -118,6 +124,7 @@ static struct nvmem_config > > imx_scu_ocotp_nvmem_config = { > > > > static const struct of_device_id imx_scu_ocotp_dt_ids[] = { > > { .compatible = "fsl,imx8qxp-scu-ocotp", (void *)&imx8qxp_data > > }, > > + { .compatible = "fsl,imx8qm-scu-ocotp", (void *)&imx8qm_data }, > > { }, > > Looks like you forgot to add this new compatible to device tree bindings > at ./Documentation/devicetree/bindings/nvmem/imx-ocotp.txt or forgot to > add me to CC. > > Please resend the patch with it, I can not apply this as it is. > > Thanks, > srini There have no separated binding documentation for imx-ocotp-scu.c driver. It is reasonable to add the new compatible string on below binding file "fsl,scu.txt": Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > }; > > MODULE_DEVICE_TABLE(of, imx_scu_ocotp_dt_ids); > >
diff --git a/drivers/nvmem/imx-ocotp-scu.c b/drivers/nvmem/imx-ocotp-scu.c index be2f5f0..0d78ab4 100644 --- a/drivers/nvmem/imx-ocotp-scu.c +++ b/drivers/nvmem/imx-ocotp-scu.c @@ -16,6 +16,7 @@ enum ocotp_devtype { IMX8QXP, + IMX8QM, }; struct ocotp_devtype_data { @@ -39,6 +40,11 @@ static struct ocotp_devtype_data imx8qxp_data = { .nregs = 800, }; +static struct ocotp_devtype_data imx8qm_data = { + .devtype = IMX8QM, + .nregs = 800, +}; + static int imx_sc_misc_otp_fuse_read(struct imx_sc_ipc *ipc, u32 word, u32 *val) { @@ -118,6 +124,7 @@ static struct nvmem_config imx_scu_ocotp_nvmem_config = { static const struct of_device_id imx_scu_ocotp_dt_ids[] = { { .compatible = "fsl,imx8qxp-scu-ocotp", (void *)&imx8qxp_data }, + { .compatible = "fsl,imx8qm-scu-ocotp", (void *)&imx8qm_data }, { }, }; MODULE_DEVICE_TABLE(of, imx_scu_ocotp_dt_ids);