| Message ID | 1564914022-3710-7-git-send-email-hao.wu@intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | FPGA DFL updates | expand |
On Sun, Aug 04, 2019 at 06:20:16PM +0800, Wu Hao wrote: > As these two functions are used by other private features. e.g. > in error reporting private feature, it requires to check port status > and reset port for error clearing. > > Signed-off-by: Xu Yilun <yilun.xu@intel.com> > Signed-off-by: Wu Hao <hao.wu@intel.com> > Acked-by: Moritz Fischer <mdf@kernel.org> > Acked-by: Alan Tull <atull@kernel.org> > Signed-off-by: Moritz Fischer <mdf@kernel.org> > --- > v2: rebased > --- > drivers/fpga/dfl-afu-main.c | 25 ++++++++++++++----------- > drivers/fpga/dfl-afu.h | 3 +++ > 2 files changed, 17 insertions(+), 11 deletions(-) > > diff --git a/drivers/fpga/dfl-afu-main.c b/drivers/fpga/dfl-afu-main.c > index e013afb..e312179 100644 > --- a/drivers/fpga/dfl-afu-main.c > +++ b/drivers/fpga/dfl-afu-main.c > @@ -22,14 +22,16 @@ > #include "dfl-afu.h" > > /** > - * port_enable - enable a port > + * __port_enable - enable a port > * @pdev: port platform device. > * > * Enable Port by clear the port soft reset bit, which is set by default. > * The AFU is unable to respond to any MMIO access while in reset. > - * port_enable function should only be used after port_disable function. > + * __port_enable function should only be used after __port_disable function. > + * > + * The caller needs to hold lock for protection. > */ > -static void port_enable(struct platform_device *pdev) > +void __port_enable(struct platform_device *pdev) worst global function name ever. Don't polute the global namespace like this for a single driver. If you REALLY need it, then use a prefix that shows it is your individual dfl_special_sauce_platform_device_only type thing. thanks, greg k-h
On Mon, Aug 05, 2019 at 05:52:40PM +0200, Greg KH wrote: > On Sun, Aug 04, 2019 at 06:20:16PM +0800, Wu Hao wrote: > > As these two functions are used by other private features. e.g. > > in error reporting private feature, it requires to check port status > > and reset port for error clearing. > > > > Signed-off-by: Xu Yilun <yilun.xu@intel.com> > > Signed-off-by: Wu Hao <hao.wu@intel.com> > > Acked-by: Moritz Fischer <mdf@kernel.org> > > Acked-by: Alan Tull <atull@kernel.org> > > Signed-off-by: Moritz Fischer <mdf@kernel.org> > > --- > > v2: rebased > > --- > > drivers/fpga/dfl-afu-main.c | 25 ++++++++++++++----------- > > drivers/fpga/dfl-afu.h | 3 +++ > > 2 files changed, 17 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/fpga/dfl-afu-main.c b/drivers/fpga/dfl-afu-main.c > > index e013afb..e312179 100644 > > --- a/drivers/fpga/dfl-afu-main.c > > +++ b/drivers/fpga/dfl-afu-main.c > > @@ -22,14 +22,16 @@ > > #include "dfl-afu.h" > > > > /** > > - * port_enable - enable a port > > + * __port_enable - enable a port > > * @pdev: port platform device. > > * > > * Enable Port by clear the port soft reset bit, which is set by default. > > * The AFU is unable to respond to any MMIO access while in reset. > > - * port_enable function should only be used after port_disable function. > > + * __port_enable function should only be used after __port_disable function. > > + * > > + * The caller needs to hold lock for protection. > > */ > > -static void port_enable(struct platform_device *pdev) > > +void __port_enable(struct platform_device *pdev) > > worst global function name ever. > > Don't polute the global namespace like this for a single driver. If you > REALLY need it, then use a prefix that shows it is your individual > dfl_special_sauce_platform_device_only type thing. Oh.. Sure.. Let me fix the naming in the next version. Thanks Hao > > thanks, > > greg k-h
diff --git a/drivers/fpga/dfl-afu-main.c b/drivers/fpga/dfl-afu-main.c index e013afb..e312179 100644 --- a/drivers/fpga/dfl-afu-main.c +++ b/drivers/fpga/dfl-afu-main.c @@ -22,14 +22,16 @@ #include "dfl-afu.h" /** - * port_enable - enable a port + * __port_enable - enable a port * @pdev: port platform device. * * Enable Port by clear the port soft reset bit, which is set by default. * The AFU is unable to respond to any MMIO access while in reset. - * port_enable function should only be used after port_disable function. + * __port_enable function should only be used after __port_disable function. + * + * The caller needs to hold lock for protection. */ -static void port_enable(struct platform_device *pdev) +void __port_enable(struct platform_device *pdev) { struct dfl_feature_platform_data *pdata = dev_get_platdata(&pdev->dev); void __iomem *base; @@ -52,13 +54,14 @@ static void port_enable(struct platform_device *pdev) #define RST_POLL_TIMEOUT 1000 /* us */ /** - * port_disable - disable a port + * __port_disable - disable a port * @pdev: port platform device. * - * Disable Port by setting the port soft reset bit, it puts the port into - * reset. + * Disable Port by setting the port soft reset bit, it puts the port into reset. + * + * The caller needs to hold lock for protection. */ -static int port_disable(struct platform_device *pdev) +int __port_disable(struct platform_device *pdev) { struct dfl_feature_platform_data *pdata = dev_get_platdata(&pdev->dev); void __iomem *base; @@ -104,9 +107,9 @@ static int __port_reset(struct platform_device *pdev) { int ret; - ret = port_disable(pdev); + ret = __port_disable(pdev); if (!ret) - port_enable(pdev); + __port_enable(pdev); return ret; } @@ -806,9 +809,9 @@ static int port_enable_set(struct platform_device *pdev, bool enable) mutex_lock(&pdata->lock); if (enable) - port_enable(pdev); + __port_enable(pdev); else - ret = port_disable(pdev); + ret = __port_disable(pdev); mutex_unlock(&pdata->lock); return ret; diff --git a/drivers/fpga/dfl-afu.h b/drivers/fpga/dfl-afu.h index 0c7630a..35e60c5 100644 --- a/drivers/fpga/dfl-afu.h +++ b/drivers/fpga/dfl-afu.h @@ -79,6 +79,9 @@ struct dfl_afu { struct dfl_feature_platform_data *pdata; }; +void __port_enable(struct platform_device *pdev); +int __port_disable(struct platform_device *pdev); + void afu_mmio_region_init(struct dfl_feature_platform_data *pdata); int afu_mmio_region_add(struct dfl_feature_platform_data *pdata, u32 region_index, u64 region_size, u64 phys, u32 flags);