| Message ID | 20190708110138.24657-1-masneyb@onstation.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | gpio: hierarchical IRQ improvements | expand |
On Mon, Jul 8, 2019 at 1:01 PM Brian Masney <masneyb@onstation.org> wrote: > This builds on top of Linus Walleij's existing patches that adds > hierarchical IRQ support to the GPIO core [1] so that Qualcomm's > spmi-gpio and ssbi-gpio can be converted to use these new helpers. > > Linus: Feel free to squash these into your existing patches if you'd > like to use any of this code. Just give me some kind of mention in the > commit description. > > [1] https://lore.kernel.org/linux-gpio/20190624132531.6184-1-linus.walleij@linaro.org/ > > Brian Masney (4): > gpio: introduce gpiochip_populate_parent_fwspec_{two,four}cell > functions > gpio: allow customizing hierarchical IRQ chips > gpio: use handler in gpio_irq_chip instead of handle_bad_irq > qcom: spmi-gpio: convert to hierarchical IRQ helpers in gpio core I solved things like this: - I kept patches 1 & 4 as-is - I squashed patches 2 and 3 into the main patch with minor modifications. - I added Co-developed-by: for your contributions Now I need to address Masahiro's comments on top and let's see if the result looks acceptable! Yours, Linus Walleij
On Wed, Aug 7, 2019 at 3:41 PM Linus Walleij <linus.walleij@linaro.org> wrote: > On Mon, Jul 8, 2019 at 1:01 PM Brian Masney <masneyb@onstation.org> wrote: > > > This builds on top of Linus Walleij's existing patches that adds > > hierarchical IRQ support to the GPIO core [1] so that Qualcomm's > > spmi-gpio and ssbi-gpio can be converted to use these new helpers. > > > > Linus: Feel free to squash these into your existing patches if you'd > > like to use any of this code. Just give me some kind of mention in the > > commit description. > > > > [1] https://lore.kernel.org/linux-gpio/20190624132531.6184-1-linus.walleij@linaro.org/ > > > > Brian Masney (4): > > gpio: introduce gpiochip_populate_parent_fwspec_{two,four}cell > > functions > > gpio: allow customizing hierarchical IRQ chips > > gpio: use handler in gpio_irq_chip instead of handle_bad_irq > > qcom: spmi-gpio: convert to hierarchical IRQ helpers in gpio core > > I solved things like this: > > - I kept patches 1 & 4 as-is Ooops had to squash patch 1 as well... Yours, Linus Walleij
On Wed, Aug 07, 2019 at 03:41:05PM +0200, Linus Walleij wrote: > On Mon, Jul 8, 2019 at 1:01 PM Brian Masney <masneyb@onstation.org> wrote: > > > This builds on top of Linus Walleij's existing patches that adds > > hierarchical IRQ support to the GPIO core [1] so that Qualcomm's > > spmi-gpio and ssbi-gpio can be converted to use these new helpers. > > > > Linus: Feel free to squash these into your existing patches if you'd > > like to use any of this code. Just give me some kind of mention in the > > commit description. > > > > [1] https://lore.kernel.org/linux-gpio/20190624132531.6184-1-linus.walleij@linaro.org/ > > > > Brian Masney (4): > > gpio: introduce gpiochip_populate_parent_fwspec_{two,four}cell > > functions > > gpio: allow customizing hierarchical IRQ chips > > gpio: use handler in gpio_irq_chip instead of handle_bad_irq > > qcom: spmi-gpio: convert to hierarchical IRQ helpers in gpio core > > I solved things like this: > > - I kept patches 1 & 4 as-is > - I squashed patches 2 and 3 into the main patch with minor modifications. > - I added Co-developed-by: for your contributions > > Now I need to address Masahiro's comments on top and let's see if the > result looks acceptable! > Ooops had to squash patch 1 as well... All of this sounds good. I'll retest once you send out the updated series. Brian
This builds on top of Linus Walleij's existing patches that adds hierarchical IRQ support to the GPIO core [1] so that Qualcomm's spmi-gpio and ssbi-gpio can be converted to use these new helpers. Linus: Feel free to squash these into your existing patches if you'd like to use any of this code. Just give me some kind of mention in the commit description. [1] https://lore.kernel.org/linux-gpio/20190624132531.6184-1-linus.walleij@linaro.org/ Brian Masney (4): gpio: introduce gpiochip_populate_parent_fwspec_{two,four}cell functions gpio: allow customizing hierarchical IRQ chips gpio: use handler in gpio_irq_chip instead of handle_bad_irq qcom: spmi-gpio: convert to hierarchical IRQ helpers in gpio core drivers/gpio/gpiolib.c | 78 ++++++++++++++++---- drivers/pinctrl/qcom/Kconfig | 1 + drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 92 +++++++----------------- include/linux/gpio/driver.h | 65 +++++++++++++++++ 4 files changed, 154 insertions(+), 82 deletions(-)