| Message ID | 20190807142101.251400-1-sean@poorly.run (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm-misc-next: Revert patches missing reviews | expand |
Hi, On Wed, Aug 07, 2019 at 10:20:53AM -0400, Sean Paul wrote: > From: Sean Paul <seanpaul@chromium.org> > > Hellooo, > This has been covered ad nauseam on the m-l and irc, but for the record: > > Reviews are a mandatory requirement for patches in drm-misc-next, it's > what keeps us all honest in the committer model. The most recent > drm-misc-next pull included a handful of patches that were missing > reviews. There was absolutely zero nefarious intent, but rules are > rules, so we're reverting them. > > I feel confident re-applying all of these with my SoB, so I plan on > doing that in the same push. > > Thanks to everyone for handling this so well, seriously awesome that > we can stay constructive as a community \o/. > > Lastly, this will be caught by our tooling in the future so this should > be the last time this happens (on accident). Thanks for taking care of this: Acked-by: Maxime Ripard <maxime.ripard@bootlin.com> Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
On Wed, 7 Aug 2019 at 15:21, Sean Paul <sean@poorly.run> wrote: > > From: Sean Paul <seanpaul@chromium.org> > > Hellooo, > This has been covered ad nauseam on the m-l and irc, but for the record: > > Reviews are a mandatory requirement for patches in drm-misc-next, it's > what keeps us all honest in the committer model. The most recent > drm-misc-next pull included a handful of patches that were missing > reviews. There was absolutely zero nefarious intent, but rules are > rules, so we're reverting them. > > I feel confident re-applying all of these with my SoB, so I plan on > doing that in the same push. > Thanks. > Thanks to everyone for handling this so well, seriously awesome that > we can stay constructive as a community \o/. > > Lastly, this will be caught by our tooling in the future so this should > be the last time this happens (on accident). > Hear, hear. > Sean > > Sean Paul (5): > Revert "drm/vgem: drop DRM_AUTH usage from the driver" > Revert "drm/msm: drop DRM_AUTH usage from the driver" > Revert "drm/nouveau: remove open-coded drm_invalid_op()" > For these three: Acked-by: Emil Velikov <emil.velikov@collabora.com> -Emil
On Wed, Aug 07, 2019 at 10:20:53AM -0400, Sean Paul wrote: > From: Sean Paul <seanpaul@chromium.org> > > Hellooo, > This has been covered ad nauseam on the m-l and irc, but for the record: > > Reviews are a mandatory requirement for patches in drm-misc-next, it's > what keeps us all honest in the committer model. The most recent > drm-misc-next pull included a handful of patches that were missing > reviews. There was absolutely zero nefarious intent, but rules are > rules, so we're reverting them. > > I feel confident re-applying all of these with my SoB, so I plan on > doing that in the same push. Applied to drm-misc-next with all patches re-applied. Sean > > Thanks to everyone for handling this so well, seriously awesome that > we can stay constructive as a community \o/. > > Lastly, this will be caught by our tooling in the future so this should > be the last time this happens (on accident). > > Sean > > Sean Paul (5): > Revert "Revert "drm/gem: Rename drm_gem_dumb_map_offset() to > drm_gem_map_offset()"" > Revert "Revert "drm/panfrost: Use drm_gem_map_offset()"" > Revert "drm/vgem: drop DRM_AUTH usage from the driver" > Revert "drm/msm: drop DRM_AUTH usage from the driver" > Revert "drm/nouveau: remove open-coded drm_invalid_op()" > > drivers/gpu/drm/drm_dumb_buffers.c | 4 ++-- > drivers/gpu/drm/drm_gem.c | 10 +++++++--- > drivers/gpu/drm/exynos/exynos_drm_gem.c | 3 +-- > drivers/gpu/drm/msm/msm_drv.c | 22 +++++++++++----------- > drivers/gpu/drm/nouveau/nouveau_abi16.c | 6 ++++++ > drivers/gpu/drm/nouveau/nouveau_abi16.h | 1 + > drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +- > drivers/gpu/drm/panfrost/panfrost_drv.c | 16 ++-------------- > drivers/gpu/drm/vgem/vgem_drv.c | 4 ++-- > include/drm/drm_gem.h | 4 ++-- > 10 files changed, 35 insertions(+), 37 deletions(-) > > -- > Sean Paul, Software Engineer, Google / Chromium OS >
From: Sean Paul <seanpaul@chromium.org> Hellooo, This has been covered ad nauseam on the m-l and irc, but for the record: Reviews are a mandatory requirement for patches in drm-misc-next, it's what keeps us all honest in the committer model. The most recent drm-misc-next pull included a handful of patches that were missing reviews. There was absolutely zero nefarious intent, but rules are rules, so we're reverting them. I feel confident re-applying all of these with my SoB, so I plan on doing that in the same push. Thanks to everyone for handling this so well, seriously awesome that we can stay constructive as a community \o/. Lastly, this will be caught by our tooling in the future so this should be the last time this happens (on accident). Sean Sean Paul (5): Revert "Revert "drm/gem: Rename drm_gem_dumb_map_offset() to drm_gem_map_offset()"" Revert "Revert "drm/panfrost: Use drm_gem_map_offset()"" Revert "drm/vgem: drop DRM_AUTH usage from the driver" Revert "drm/msm: drop DRM_AUTH usage from the driver" Revert "drm/nouveau: remove open-coded drm_invalid_op()" drivers/gpu/drm/drm_dumb_buffers.c | 4 ++-- drivers/gpu/drm/drm_gem.c | 10 +++++++--- drivers/gpu/drm/exynos/exynos_drm_gem.c | 3 +-- drivers/gpu/drm/msm/msm_drv.c | 22 +++++++++++----------- drivers/gpu/drm/nouveau/nouveau_abi16.c | 6 ++++++ drivers/gpu/drm/nouveau/nouveau_abi16.h | 1 + drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +- drivers/gpu/drm/panfrost/panfrost_drv.c | 16 ++-------------- drivers/gpu/drm/vgem/vgem_drv.c | 4 ++-- include/drm/drm_gem.h | 4 ++-- 10 files changed, 35 insertions(+), 37 deletions(-)