mbox series

[0/4] Use -EIO code for GuC initialization failures

Message ID 20190811195132.9660-1-michal.wajdeczko@intel.com (mailing list archive)
Headers show
Series Use -EIO code for GuC initialization failures | expand

Message

Michal Wajdeczko Aug. 11, 2019, 7:51 p.m. UTC 
Next portion of GuC/HuC improvements

Michal Wajdeczko (4):
  drm/i915/uc: Fail early if there is no GuC fw available
  drm/i915/uc: Include HuC firmware version in summary
  drm/i915/uc: Update messages from fw upload step
  drm/i915/uc: Use -EIO code for GuC initialization failures

 drivers/gpu/drm/i915/gt/uc/intel_uc.c    | 32 +++++++++++++++---------
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 14 +++--------
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h | 21 ++++++++++++++++
 drivers/gpu/drm/i915/i915_gem.c          | 14 ++++++-----
 4 files changed, 52 insertions(+), 29 deletions(-)

Comments

Chris Wilson Aug. 12, 2019, 8:45 a.m. UTC | #1 
Quoting Patchwork (2019-08-12 09:40:19)
> == Series Details ==
> 
> Series: Use -EIO code for GuC initialization failures (rev2)
> URL   : https://patchwork.freedesktop.org/series/65060/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_6681 -> Patchwork_13979
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_13979 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_13979, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13979/
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_13979:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@i915_module_load@reload:
>     - fi-kbl-7567u:       [PASS][1] -> [INCOMPLETE][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6681/fi-kbl-7567u/igt@i915_module_load@reload.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13979/fi-kbl-7567u/igt@i915_module_load@reload.html

Unrelated, so applying since this is just tweaking init paths that we
have sufficient coverage for from BAT.
-Chris
Michal Wajdeczko Aug. 12, 2019, 8:46 a.m. UTC | #2 
On Mon, 12 Aug 2019 10:40:19 +0200, Patchwork  
<patchwork@emeril.freedesktop.org> wrote:

> == Series Details ==
>
> Series: Use -EIO code for GuC initialization failures (rev2)
> URL   : https://patchwork.freedesktop.org/series/65060/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_6681 -> Patchwork_13979
> ====================================================
>
> Summary
> -------
>
>   **FAILURE**
>
>   Serious unknown changes coming with Patchwork_13979 absolutely need to  
> be
>   verified manually.
>  If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_13979, please notify your bug team to allow  
> them
>   to document this new failure mode, which will reduce false positives  
> in CI.
>
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13979/
>
> Possible new issues
> -------------------
>
>   Here are the unknown changes that may have been introduced in  
> Patchwork_13979:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
>   * igt@i915_module_load@reload:
>     - fi-kbl-7567u:       [PASS][1] -> [INCOMPLETE][2]
>    [1]:  
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6681/fi-kbl-7567u/igt@i915_module_load@reload.html
>    [2]:  
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13979/fi-kbl-7567u/igt@i915_module_load@reload.html
>

This run is without GuC:

<7>[    3.598778] i915 0000:00:02.0: [drm:intel_uc_init_early [i915]]  
enable_guc=0 (guc:no submission:no huc:no)

and crash is unrelated:

<1> [223.461459] BUG: kernel NULL pointer dereference, address:  
0000000000000629
<1> [223.461471] #PF: supervisor read access in kernel mode
<1> [223.461478] #PF: error_code(0x0000) - not-present page
<6> [223.461485] PGD 0 P4D 0
<4> [223.461492] Oops: 0000 [#1] PREEMPT SMP PTI
<4> [223.461501] CPU: 3 PID: 519 Comm: kworker/3:3 Tainted: G      
U            5.3.0-rc4-CI-Patchwork_13979+ #1
<4> [223.461513] Hardware name:  /NUC7i7BNB, BIOS  
BNKBL357.86A.0054.2017.1025.1822 10/25/2017
<4> [223.461528] Workqueue: events snd_hdac_bus_process_unsol_events  
[snd_hda_core]
<4> [223.461540] RIP: 0010:hdmi_unsol_event+0x7/0x120 [snd_hda_codec_hdmi]
<4> [223.461550] Code: 0f b7 d6 48 c7 c6 a0 70 1d a0 5d 41 5c 41 5d e9 d1  
58 4b e1 0f 1f 44 00 00 66 2e 0f 1f 84 00 00 00 00 00 48 8b 87 48 06 00 00  
<80> b8 29 06 00 00 00 74 02 f3 c3 41 54 41 89 f4 55 53 41 c1 ec 1a
<4> [223.461572] RSP: 0018:ffffc9000067fe50 EFLAGS: 00010286
<4> [223.461580] RAX: 0000000000000000 RBX: ffff88826f546ae0 RCX:  
0000000000000034
<4> [223.461589] RDX: ffffffffa02a6050 RSI: 00000000ffffffff RDI:  
ffff88825a95e7e8
<4> [223.461599] RBP: ffffc9000067fec8 R08: 0000000000000000 R09:  
0000000000000001
<4> [223.461608] R10: 000000009c3d0ecf R11: 000000001b84cafe R12:  
ffff888276bb9900
<4> [223.461618] R13: ffff888276bbdc00 R14: 0000000000000000 R15:  
0000000000000000
<4> [223.461627] FS:  0000000000000000(0000) GS:ffff888276b80000(0000)  
knlGS:0000000000000000
<4> [223.461639] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
<4> [223.461647] CR2: 0000000000000629 CR3: 000000026b59a005 CR4:  
00000000003606e0
<4> [223.461657] Call Trace:
<4> [223.461666]  snd_hdac_bus_process_unsol_events+0x5a/0x70  
[snd_hda_core]
<4> [223.461678]  process_one_work+0x245/0x610
<4> [223.461689]  worker_thread+0x37/0x380
<4> [223.461697]  ? process_one_work+0x610/0x610
<4> [223.461705]  kthread+0x119/0x130
<4> [223.461712]  ? kthread_park+0xa0/0xa0
<4> [223.461721]  ret_from_fork+0x3a/0x50