| Message ID | 20190530211516.1891-1-jernej.skrabec@siol.net (mailing list archive) |
|---|---|
| Headers | show |
| Series | media: cedrus: Improvements/cleanup | expand |
On 5/30/19 11:15 PM, Jernej Skrabec wrote: > Here is first batch of random Cedrus improvements/cleanups. Only patch 2 > has a change which raises a question about H264 controls. > > Changes were tested on H3 SoC using modified ffmpeg and Kodi. > > Please take a look. This has been sitting in patchwork for quite some time. I've updated the status of the various patches and most needed extra work. It seems that patches 4/7 and 5/7 are OK. Maxime, can you please confirm that these two are still valid? They apply cleanly on the latest master at least, but since they are a bit old I prefer to have confirmation that it's OK to merge them. Regards, Hans > > Best regards, > Jernej > > Jernej Skrabec (7): > media: cedrus: Disable engine after each slice decoding > media: cedrus: Fix H264 default reference index count > media: cedrus: Fix decoding for some H264 videos > media: cedrus: Remove dst_bufs from context > media: cedrus: Don't set chroma size for scale & rotation > media: cedrus: Add infra for extra buffers connected to capture > buffers > media: cedrus: Improve H264 memory efficiency > > drivers/staging/media/sunxi/cedrus/cedrus.h | 12 +- > .../staging/media/sunxi/cedrus/cedrus_h264.c | 115 ++++++++---------- > .../staging/media/sunxi/cedrus/cedrus_hw.c | 4 +- > .../staging/media/sunxi/cedrus/cedrus_video.c | 25 ++-- > 4 files changed, 68 insertions(+), 88 deletions(-) >
Dne ponedeljek, 12. avgust 2019 ob 14:12:21 CEST je Hans Verkuil napisal(a): > On 5/30/19 11:15 PM, Jernej Skrabec wrote: > > Here is first batch of random Cedrus improvements/cleanups. Only patch 2 > > has a change which raises a question about H264 controls. > > > > Changes were tested on H3 SoC using modified ffmpeg and Kodi. > > > > Please take a look. > > This has been sitting in patchwork for quite some time. I've updated the > status of the various patches and most needed extra work. > > It seems that patches 4/7 and 5/7 are OK. Maxime, can you please confirm > that these two are still valid? They apply cleanly on the latest master > at least, but since they are a bit old I prefer to have confirmation that > it's OK to merge them. I'm not sure about patch 4, IIRC Boris Brezillon also wants to improve that area in separate series, but patch 5 should be safe to merge. Anyway, I didn't post new version because I'm waiting on close-to-be-merged H264 and HEVC patch series to be actually merged. Best regards, Jernej > > Regards, > > Hans > > > Best regards, > > Jernej > > > > Jernej Skrabec (7): > > media: cedrus: Disable engine after each slice decoding > > media: cedrus: Fix H264 default reference index count > > media: cedrus: Fix decoding for some H264 videos > > media: cedrus: Remove dst_bufs from context > > media: cedrus: Don't set chroma size for scale & rotation > > media: cedrus: Add infra for extra buffers connected to capture > > > > buffers > > > > media: cedrus: Improve H264 memory efficiency > > > > drivers/staging/media/sunxi/cedrus/cedrus.h | 12 +- > > .../staging/media/sunxi/cedrus/cedrus_h264.c | 115 ++++++++---------- > > .../staging/media/sunxi/cedrus/cedrus_hw.c | 4 +- > > .../staging/media/sunxi/cedrus/cedrus_video.c | 25 ++-- > > 4 files changed, 68 insertions(+), 88 deletions(-)
Hi! On Mon, Aug 12, 2019 at 02:12:21PM +0200, Hans Verkuil wrote: > On 5/30/19 11:15 PM, Jernej Skrabec wrote: > > Here is first batch of random Cedrus improvements/cleanups. Only patch 2 > > has a change which raises a question about H264 controls. > > > > Changes were tested on H3 SoC using modified ffmpeg and Kodi. > > > > Please take a look. > > This has been sitting in patchwork for quite some time. I've updated the > status of the various patches and most needed extra work. > > It seems that patches 4/7 and 5/7 are OK. Maxime, can you please confirm > that these two are still valid? They apply cleanly on the latest master > at least, but since they are a bit old I prefer to have confirmation that > it's OK to merge them. Yes, you can definitely merge those. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Here is first batch of random Cedrus improvements/cleanups. Only patch 2 has a change which raises a question about H264 controls. Changes were tested on H3 SoC using modified ffmpeg and Kodi. Please take a look. Best regards, Jernej Jernej Skrabec (7): media: cedrus: Disable engine after each slice decoding media: cedrus: Fix H264 default reference index count media: cedrus: Fix decoding for some H264 videos media: cedrus: Remove dst_bufs from context media: cedrus: Don't set chroma size for scale & rotation media: cedrus: Add infra for extra buffers connected to capture buffers media: cedrus: Improve H264 memory efficiency drivers/staging/media/sunxi/cedrus/cedrus.h | 12 +- .../staging/media/sunxi/cedrus/cedrus_h264.c | 115 ++++++++---------- .../staging/media/sunxi/cedrus/cedrus_hw.c | 4 +- .../staging/media/sunxi/cedrus/cedrus_video.c | 25 ++-- 4 files changed, 68 insertions(+), 88 deletions(-)