| Message ID | 20190809103235.16338-1-tbogendoerfer@suse.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | Use MFD framework for SGI IOC3 drivers | expand |
On Fri, 9 Aug 2019 12:32:29 +0200, Thomas Bogendoerfer wrote: > SGI IOC3 chip has integrated ethernet, keyboard and mouse interface. > It also supports connecting a SuperIO chip for serial and parallel > interfaces. IOC3 is used inside various SGI systemboards and add-on > cards with different equipped external interfaces. > > Support for ethernet and serial interfaces were implemented inside > the network driver. This patchset moves out the not network related > parts to a new MFD driver, which takes care of card detection, > setup of platform devices and interrupt distribution for the subdevices. > > Serial portion: Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de> There are a lot of changes in the ethernet part which are not easy to explain by the introduction of the other MFD parts.. Could you possibly break this change up into smaller chunks? Also please don't use stdint types in the kernel, please try checkpatch to catch coding style issues.
On Fri, 9 Aug 2019 14:22:22 -0700 Jakub Kicinski <jakub.kicinski@netronome.com> wrote: > On Fri, 9 Aug 2019 12:32:29 +0200, Thomas Bogendoerfer wrote: > > SGI IOC3 chip has integrated ethernet, keyboard and mouse interface. > > It also supports connecting a SuperIO chip for serial and parallel > > interfaces. IOC3 is used inside various SGI systemboards and add-on > > cards with different equipped external interfaces. > > > > Support for ethernet and serial interfaces were implemented inside > > the network driver. This patchset moves out the not network related > > parts to a new MFD driver, which takes care of card detection, > > setup of platform devices and interrupt distribution for the subdevices. > > > > Serial portion: Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de> > > There are a lot of changes in the ethernet part which are not easy to > explain by the introduction of the other MFD parts.. Could you possibly > break this change up into smaller chunks? working on it > Also please don't use stdint types in the kernel, please try checkpatch > to catch coding style issues. my patch already reduces them and checkpatch only warns about usage of printk for the network part. Changing that to dev_warn/dev_err in the mfd patch didn't seem the right thing to do. As I'm splitting the conversion patch into a few steps I could also replace the printks. Thomas.
On Sun, 11 Aug 2019 09:32:12 +0200, Thomas Bogendoerfer wrote: > > Also please don't use stdint types in the kernel, please try checkpatch > > to catch coding style issues. > > my patch already reduces them and checkpatch only warns about usage of printk > for the network part. Changing that to dev_warn/dev_err in the mfd patch didn't > seem the right thing to do. As I'm splitting the conversion patch into a few > steps I could also replace the printks. Thanks for looking into it. I was referring to the use of uint32_t instead of u32. Perhaps checkpatch has to be motivated with the --strict option to point those out?