| Message ID | 20190813062840.2733-1-xiaowei.bao@nxp.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [PATCHv5,1/2] PCI: layerscape: Add the bar_fixed_64bit property in EP driver. | expand |
On 13/08/19 11:58 AM, Xiaowei Bao wrote: > The PCIe controller of layerscape just have 4 BARs, BAR0 and BAR1 > is 32bit, BAR2 and BAR4 is 64bit, this is determined by hardware, > so set the bar_fixed_64bit with 0x14. > > Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com> Acked-by: Kishon Vijay Abraham I <kishon@ti.com> > --- > v2: > - Replace value 0x14 with a macro. > v3: > - No change. > v4: > - send the patch again with '--to'. > v5: > - fix the commit message. > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c > index be61d96..ca9aa45 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > @@ -44,6 +44,7 @@ static const struct pci_epc_features ls_pcie_epc_features = { > .linkup_notifier = false, > .msi_capable = true, > .msix_capable = false, > + .bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4), > }; > > static const struct pci_epc_features* >
> -----Original Message----- > From: Kishon Vijay Abraham I <kishon@ti.com> > Sent: 2019年8月13日 15:30 > To: Xiaowei Bao <xiaowei.bao@nxp.com>; lorenzo.pieralisi@arm.com; > bhelgaas@google.com; M.h. Lian <minghuan.lian@nxp.com>; Mingkai Hu > <mingkai.hu@nxp.com>; Roy Zang <roy.zang@nxp.com>; > l.stach@pengutronix.de; tpiepho@impinj.com; Leonard Crestez > <leonard.crestez@nxp.com>; andrew.smirnov@gmail.com; > yue.wang@amlogic.com; hayashi.kunihiko@socionext.com; > dwmw@amazon.co.uk; jonnyc@amazon.com; linux-pci@vger.kernel.org; > linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > linux-arm-kernel@lists.infradead.org > Subject: [EXT] Re: [PATCHv5 1/2] PCI: layerscape: Add the bar_fixed_64bit > property in EP driver. > > Caution: EXT Email > > On 13/08/19 11:58 AM, Xiaowei Bao wrote: > > The PCIe controller of layerscape just have 4 BARs, BAR0 and BAR1 is > > 32bit, BAR2 and BAR4 is 64bit, this is determined by hardware, so set > > the bar_fixed_64bit with 0x14. > > > > Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com> > > Acked-by: Kishon Vijay Abraham I <kishon@ti.com> > > --- > > v2: > > - Replace value 0x14 with a macro. > > v3: > > - No change. > > v4: > > - send the patch again with '--to'. > > v5: > > - fix the commit message. > > > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c > > b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > index be61d96..ca9aa45 100644 > > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > @@ -44,6 +44,7 @@ static const struct pci_epc_features > ls_pcie_epc_features = { > > .linkup_notifier = false, > > .msi_capable = true, > > .msix_capable = false, > > + .bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4), > > }; > > > > static const struct pci_epc_features* I check other platforms, it is 'static const struct pci_epc_features', I can get the correct Value use this define way in pci-epf-test.c file. > >
You should fix your email client set-up to avoid sticking an [EXT] tag to your emails $SUBJECT. On Tue, Aug 13, 2019 at 07:39:48AM +0000, Xiaowei Bao wrote: > > > > -----Original Message----- > > From: Kishon Vijay Abraham I <kishon@ti.com> > > Sent: 2019年8月13日 15:30 > > To: Xiaowei Bao <xiaowei.bao@nxp.com>; lorenzo.pieralisi@arm.com; > > bhelgaas@google.com; M.h. Lian <minghuan.lian@nxp.com>; Mingkai Hu > > <mingkai.hu@nxp.com>; Roy Zang <roy.zang@nxp.com>; > > l.stach@pengutronix.de; tpiepho@impinj.com; Leonard Crestez > > <leonard.crestez@nxp.com>; andrew.smirnov@gmail.com; > > yue.wang@amlogic.com; hayashi.kunihiko@socionext.com; > > dwmw@amazon.co.uk; jonnyc@amazon.com; linux-pci@vger.kernel.org; > > linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > linux-arm-kernel@lists.infradead.org > > Subject: [EXT] Re: [PATCHv5 1/2] PCI: layerscape: Add the bar_fixed_64bit > > property in EP driver. > > > > Caution: EXT Email See above, this "Caution" stuff should disappear. Also, quoting the email header is useless, please configure your email client to remove it. Thanks, Lorenzo > > On 13/08/19 11:58 AM, Xiaowei Bao wrote: > > > The PCIe controller of layerscape just have 4 BARs, BAR0 and BAR1 is > > > 32bit, BAR2 and BAR4 is 64bit, this is determined by hardware, so set > > > the bar_fixed_64bit with 0x14. > > > > > > Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com> > > > > Acked-by: Kishon Vijay Abraham I <kishon@ti.com> > > > --- > > > v2: > > > - Replace value 0x14 with a macro. > > > v3: > > > - No change. > > > v4: > > > - send the patch again with '--to'. > > > v5: > > > - fix the commit message. > > > > > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c > > > b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > > index be61d96..ca9aa45 100644 > > > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > > > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > > @@ -44,6 +44,7 @@ static const struct pci_epc_features > > ls_pcie_epc_features = { > > > .linkup_notifier = false, > > > .msi_capable = true, > > > .msix_capable = false, > > > + .bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4), > > > }; > > > > > > static const struct pci_epc_features* > I check other platforms, it is 'static const struct pci_epc_features', I can get the correct > Value use this define way in pci-epf-test.c file. > > >
git log --oneline --follow drivers/pci/controller/dwc/pci-layerscape.c Do you see any commit with a $SUBJECT ending with a period ? There is not. So remove it from yours too. On Tue, Aug 13, 2019 at 02:28:39PM +0800, Xiaowei Bao wrote: > The PCIe controller of layerscape just have 4 BARs, BAR0 and BAR1 > is 32bit, BAR2 and BAR4 is 64bit, this is determined by hardware, > so set the bar_fixed_64bit with 0x14. > > Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com> > --- > v2: > - Replace value 0x14 with a macro. > v3: > - No change. > v4: > - send the patch again with '--to'. > v5: > - fix the commit message. > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + > 1 file changed, 1 insertion(+) scripts/get_maintainer.pl -f drivers/pci/controller/dwc/pci-layerscape-ep.c Now, with the output you get justify all the people you send this email to. So, again, trim the CC list and it is the last time I tell you. Before sending patches on mailing lists use git --dry-run to check the emails you are sending. Thanks, Lorenzo > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c > index be61d96..ca9aa45 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > @@ -44,6 +44,7 @@ static const struct pci_epc_features ls_pcie_epc_features = { > .linkup_notifier = false, > .msi_capable = true, > .msix_capable = false, > + .bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4), > }; > > static const struct pci_epc_features* > -- > 2.9.5 >
> -----Original Message----- > From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Sent: 2019年8月13日 18:04 > To: Xiaowei Bao <xiaowei.bao@nxp.com> > Cc: bhelgaas@google.com; M.h. Lian <minghuan.lian@nxp.com>; Mingkai Hu > <mingkai.hu@nxp.com>; Roy Zang <roy.zang@nxp.com>; > l.stach@pengutronix.de; kishon@ti.com; tpiepho@impinj.com; Leonard > Crestez <leonard.crestez@nxp.com>; andrew.smirnov@gmail.com; > yue.wang@amlogic.com; hayashi.kunihiko@socionext.com; > dwmw@amazon.co.uk; jonnyc@amazon.com; linux-pci@vger.kernel.org; > linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > linux-arm-kernel@lists.infradead.org > Subject: [EXT] Re: [PATCHv5 1/2] PCI: layerscape: Add the bar_fixed_64bit > property in EP driver. > > Caution: EXT Email > > git log --oneline --follow drivers/pci/controller/dwc/pci-layerscape.c > > Do you see any commit with a $SUBJECT ending with a period ? > > There is not. So remove it from yours too. OK, thanks a lot, I will remove it in the next version patch, I have to get the approved Form IT team of our company. > > On Tue, Aug 13, 2019 at 02:28:39PM +0800, Xiaowei Bao wrote: > > The PCIe controller of layerscape just have 4 BARs, BAR0 and BAR1 is > > 32bit, BAR2 and BAR4 is 64bit, this is determined by hardware, so set > > the bar_fixed_64bit with 0x14. > > > > Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com> > > --- > > v2: > > - Replace value 0x14 with a macro. > > v3: > > - No change. > > v4: > > - send the patch again with '--to'. > > v5: > > - fix the commit message. > > > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + > > 1 file changed, 1 insertion(+) > > scripts/get_maintainer.pl -f drivers/pci/controller/dwc/pci-layerscape-ep.c > Now, with the output you get justify all the people you send this email to. > > So, again, trim the CC list and it is the last time I tell you. Do you mean that I use scripts/get_maintainer.pl -f drivers/pci/controller/ dwc/pci-layerscape-ep.c to get the mail list who I need to send? I use the command of ' scripts/get_maintainer.pl *.patch' to get the mail list before. If yes, I will use the command that you provided. Thanks a lot. > > Before sending patches on mailing lists use git --dry-run to check the emails > you are sending. > > Thanks, > Lorenzo > > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c > > b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > index be61d96..ca9aa45 100644 > > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > @@ -44,6 +44,7 @@ static const struct pci_epc_features > ls_pcie_epc_features = { > > .linkup_notifier = false, > > .msi_capable = true, > > .msix_capable = false, > > + .bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4), > > }; > > > > static const struct pci_epc_features* > > -- > > 2.9.5 > >
diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c index be61d96..ca9aa45 100644 --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c @@ -44,6 +44,7 @@ static const struct pci_epc_features ls_pcie_epc_features = { .linkup_notifier = false, .msi_capable = true, .msix_capable = false, + .bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4), }; static const struct pci_epc_features*
The PCIe controller of layerscape just have 4 BARs, BAR0 and BAR1 is 32bit, BAR2 and BAR4 is 64bit, this is determined by hardware, so set the bar_fixed_64bit with 0x14. Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com> --- v2: - Replace value 0x14 with a macro. v3: - No change. v4: - send the patch again with '--to'. v5: - fix the commit message. drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + 1 file changed, 1 insertion(+)