mbox series

[0/3] Reduce the number of Valgrind reports in unit tests.

Message ID 1564502498-805893-1-git-send-email-andrey.shinkevich@virtuozzo.com (mailing list archive)
Headers show
Series Reduce the number of Valgrind reports in unit tests. | expand

Message

Andrey Shinkevich July 30, 2019, 4:01 p.m. UTC 
Running unit tests under the Valgrind may help to detect QEMU memory issues
(suggested by Denis V. Lunev). Some of the Valgrind reports relate to the
unit test code itself. Let's eliminate the detected memory issues to ease
locating critical ones.

Andrey Shinkevich (3):
  test-throttle: Fix uninitialized use of burst_length
  tests: Fix uninitialized byte in test_visitor_in_fuzz
  i386/kvm: initialize struct at full before ioctl call

 target/i386/kvm.c                 | 3 +++
 tests/test-string-input-visitor.c | 8 +++-----
 tests/test-throttle.c             | 2 ++
 3 files changed, 8 insertions(+), 5 deletions(-)

Comments

Andrey Shinkevich Aug. 13, 2019, 12:02 p.m. UTC | #1 
PINGING...

On 30/07/2019 19:01, Andrey Shinkevich wrote:
> Running unit tests under the Valgrind may help to detect QEMU memory issues
> (suggested by Denis V. Lunev). Some of the Valgrind reports relate to the
> unit test code itself. Let's eliminate the detected memory issues to ease
> locating critical ones.
> 
> Andrey Shinkevich (3):
>    test-throttle: Fix uninitialized use of burst_length
>    tests: Fix uninitialized byte in test_visitor_in_fuzz
>    i386/kvm: initialize struct at full before ioctl call
> 
>   target/i386/kvm.c                 | 3 +++
>   tests/test-string-input-visitor.c | 8 +++-----
>   tests/test-throttle.c             | 2 ++
>   3 files changed, 8 insertions(+), 5 deletions(-)
>
Paolo Bonzini Aug. 13, 2019, 12:05 p.m. UTC | #2 
On 13/08/19 14:02, Andrey Shinkevich wrote:
> PINGING...

I thought I had already said I queued the series?

Paolo

> On 30/07/2019 19:01, Andrey Shinkevich wrote:
>> Running unit tests under the Valgrind may help to detect QEMU memory issues
>> (suggested by Denis V. Lunev). Some of the Valgrind reports relate to the
>> unit test code itself. Let's eliminate the detected memory issues to ease
>> locating critical ones.
>>
>> Andrey Shinkevich (3):
>>    test-throttle: Fix uninitialized use of burst_length
>>    tests: Fix uninitialized byte in test_visitor_in_fuzz
>>    i386/kvm: initialize struct at full before ioctl call
>>
>>   target/i386/kvm.c                 | 3 +++
>>   tests/test-string-input-visitor.c | 8 +++-----
>>   tests/test-throttle.c             | 2 ++
>>   3 files changed, 8 insertions(+), 5 deletions(-)
>>
>
Andrey Shinkevich Aug. 13, 2019, 12:08 p.m. UTC | #3 
On 13/08/2019 15:05, Paolo Bonzini wrote:
> On 13/08/19 14:02, Andrey Shinkevich wrote:
>> PINGING...
> 
> I thought I had already said I queued the series?
> 
> Paolo
> 

Thank you Paolo.
I am clear now.

Andrey

>> On 30/07/2019 19:01, Andrey Shinkevich wrote:
>>> Running unit tests under the Valgrind may help to detect QEMU memory issues
>>> (suggested by Denis V. Lunev). Some of the Valgrind reports relate to the
>>> unit test code itself. Let's eliminate the detected memory issues to ease
>>> locating critical ones.
>>>
>>> Andrey Shinkevich (3):
>>>     test-throttle: Fix uninitialized use of burst_length
>>>     tests: Fix uninitialized byte in test_visitor_in_fuzz
>>>     i386/kvm: initialize struct at full before ioctl call
>>>
>>>    target/i386/kvm.c                 | 3 +++
>>>    tests/test-string-input-visitor.c | 8 +++-----
>>>    tests/test-throttle.c             | 2 ++
>>>    3 files changed, 8 insertions(+), 5 deletions(-)
>>>
>>
>