| Message ID | 1565713248-4906-7-git-send-email-wahrenst@gmx.net (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | ARM: Add minimal Raspberry Pi 4 support | expand |
Quoting Stefan Wahren (2019-08-13 09:20:41) > The VPU firmware assume that the PLLD_PER isn't modified by the ARM core. > Otherwise this could cause firmware lookups. So mark the clock as critical > to avoid this. > > Signed-off-by: Stefan Wahren <wahrenst@gmx.net> > --- > drivers/clk/bcm/clk-bcm2835.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c > index fdf672a..b62052e 100644 > --- a/drivers/clk/bcm/clk-bcm2835.c > +++ b/drivers/clk/bcm/clk-bcm2835.c > @@ -1785,7 +1785,7 @@ static const struct bcm2835_clk_desc clk_desc_array[] = { > .load_mask = CM_PLLD_LOADPER, > .hold_mask = CM_PLLD_HOLDPER, > .fixed_divider = 1, > - .flags = CLK_SET_RATE_PARENT), > + .flags = CLK_IS_CRITICAL | CLK_SET_RATE_PARENT), Please add a comment in the code to the effect that is in the commit text so we don't have to dig through commits to figure out why this special CLK_IS_CRITICAL flag is here. > [BCM2835_PLLD_DSI0] = REGISTER_PLL_DIV( > SOC_ALL, > .name = "plld_dsi0",
diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c index fdf672a..b62052e 100644 --- a/drivers/clk/bcm/clk-bcm2835.c +++ b/drivers/clk/bcm/clk-bcm2835.c @@ -1785,7 +1785,7 @@ static const struct bcm2835_clk_desc clk_desc_array[] = { .load_mask = CM_PLLD_LOADPER, .hold_mask = CM_PLLD_HOLDPER, .fixed_divider = 1, - .flags = CLK_SET_RATE_PARENT), + .flags = CLK_IS_CRITICAL | CLK_SET_RATE_PARENT), [BCM2835_PLLD_DSI0] = REGISTER_PLL_DIV( SOC_ALL, .name = "plld_dsi0",
The VPU firmware assume that the PLLD_PER isn't modified by the ARM core. Otherwise this could cause firmware lookups. So mark the clock as critical to avoid this. Signed-off-by: Stefan Wahren <wahrenst@gmx.net> --- drivers/clk/bcm/clk-bcm2835.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4