| Message ID | 20190622145516.3231-14-jic23@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: SPDX headers for core + non device driver parts. | expand |
On Sat, Jun 22, 2019 at 03:55:15PM +0100, jic23@kernel.org wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Not exactly standard license text, but clear in intent and it's > my copyright anyway. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/iio/trigger/iio-trig-loop.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/iio/trigger/iio-trig-loop.c b/drivers/iio/trigger/iio-trig-loop.c > index 9258d3cf149b..f0205a9e47d0 100644 > --- a/drivers/iio/trigger/iio-trig-loop.c > +++ b/drivers/iio/trigger/iio-trig-loop.c > @@ -1,8 +1,7 @@ > +// SPDX-License-Identifier: GPL-2.0 I think it should be: // SPDX-License-Identifier: GPL-2.0-only https://spdx.org/licenses/ https://spdx.org/licenses/GPL-2.0-only.html I don't know if `spdxcheck.py` points out about such a mismatch. Yes, documentation and sanity checkers needs to be updated. https://lore.kernel.org/lkml/CAHk-=wipjStEwJj2_iWxBdVC4oV8rY5NjrRb1tmWLUa0VrS_Eg@mail.gmail.com/ > /* > * Copyright 2016 Jonathan Cameron <jic23@kernel.org> > * > - * Licensed under the GPL-2. > - * > * Based on a mashup of the hrtimer trigger and continuous sampling proposal of > * Gregor Boirie <gregor.boirie@parrot.com> > * > -- > 2.22.0 >
On Wed, Jul 17, 2019 at 11:28:37PM +0530, Himanshu Jha wrote: > On Sat, Jun 22, 2019 at 03:55:15PM +0100, jic23@kernel.org wrote: > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > Not exactly standard license text, but clear in intent and it's > > my copyright anyway. > > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > --- > > drivers/iio/trigger/iio-trig-loop.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/iio/trigger/iio-trig-loop.c b/drivers/iio/trigger/iio-trig-loop.c > > index 9258d3cf149b..f0205a9e47d0 100644 > > --- a/drivers/iio/trigger/iio-trig-loop.c > > +++ b/drivers/iio/trigger/iio-trig-loop.c > > @@ -1,8 +1,7 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > I think it should be: > > // SPDX-License-Identifier: GPL-2.0-only > > https://spdx.org/licenses/ > https://spdx.org/licenses/GPL-2.0-only.html > > I don't know if `spdxcheck.py` points out about > such a mismatch. > > Yes, documentation and sanity checkers needs to be updated. > https://lore.kernel.org/lkml/CAHk-=wipjStEwJj2_iWxBdVC4oV8rY5NjrRb1tmWLUa0VrS_Eg@mail.gmail.com/ Please read the in-kernel documentation about this. We support both types of tags now and have done so since the beginning. thanks, greg k-h
> On Jul 17, 2019, at 3:12 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > > On Wed, Jul 17, 2019 at 11:28:37PM +0530, Himanshu Jha wrote: >> On Sat, Jun 22, 2019 at 03:55:15PM +0100, jic23@kernel.org wrote: >>> From: Jonathan Cameron <Jonathan.Cameron@huawei.com> >>> >>> Not exactly standard license text, but clear in intent and it's >>> my copyright anyway. >>> >>> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> >>> --- >>> drivers/iio/trigger/iio-trig-loop.c | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/drivers/iio/trigger/iio-trig-loop.c b/drivers/iio/trigger/iio-trig-loop.c >>> index 9258d3cf149b..f0205a9e47d0 100644 >>> --- a/drivers/iio/trigger/iio-trig-loop.c >>> +++ b/drivers/iio/trigger/iio-trig-loop.c >>> @@ -1,8 +1,7 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >> >> I think it should be: >> >> // SPDX-License-Identifier: GPL-2.0-only >> >> https://spdx.org/licenses/ >> https://spdx.org/licenses/GPL-2.0-only.html >> >> I don't know if `spdxcheck.py` points out about >> such a mismatch. >> >> Yes, documentation and sanity checkers needs to be updated. >> https://lore.kernel.org/lkml/CAHk-=wipjStEwJj2_iWxBdVC4oV8rY5NjrRb1tmWLUa0VrS_Eg@mail.gmail.com/ > > Please read the in-kernel documentation about this. We support both > types of tags now and have done so since the beginning. > > While I understand that the previous SPDX License List and current version identifiers are supported here, it would be really helpful more generally if we could use the current ones now and going forward. Thanks, Jilayne SPDX legal team co-lead
On Sat, Aug 17, 2019 at 01:08:44PM -0600, J Lovejoy wrote: > > > > On Jul 17, 2019, at 3:12 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > > > > On Wed, Jul 17, 2019 at 11:28:37PM +0530, Himanshu Jha wrote: > >> On Sat, Jun 22, 2019 at 03:55:15PM +0100, jic23@kernel.org wrote: > >>> From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > >>> > >>> Not exactly standard license text, but clear in intent and it's > >>> my copyright anyway. > >>> > >>> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > >>> --- > >>> drivers/iio/trigger/iio-trig-loop.c | 3 +-- > >>> 1 file changed, 1 insertion(+), 2 deletions(-) > >>> > >>> diff --git a/drivers/iio/trigger/iio-trig-loop.c b/drivers/iio/trigger/iio-trig-loop.c > >>> index 9258d3cf149b..f0205a9e47d0 100644 > >>> --- a/drivers/iio/trigger/iio-trig-loop.c > >>> +++ b/drivers/iio/trigger/iio-trig-loop.c > >>> @@ -1,8 +1,7 @@ > >>> +// SPDX-License-Identifier: GPL-2.0 > >> > >> I think it should be: > >> > >> // SPDX-License-Identifier: GPL-2.0-only > >> > >> https://spdx.org/licenses/ > >> https://spdx.org/licenses/GPL-2.0-only.html > >> > >> I don't know if `spdxcheck.py` points out about > >> such a mismatch. > >> > >> Yes, documentation and sanity checkers needs to be updated. > >> https://lore.kernel.org/lkml/CAHk-=wipjStEwJj2_iWxBdVC4oV8rY5NjrRb1tmWLUa0VrS_Eg@mail.gmail.com/ > > > > Please read the in-kernel documentation about this. We support both > > types of tags now and have done so since the beginning. > > > > > While I understand that the previous SPDX License List and current > version identifiers are supported here, it would be really helpful > more generally if we could use the current ones now and going forward. That is fine, but for now, both are acceptable, it's up to the submitter to pick which they want to use, we have much bigger things to worry about here :) thanks, greg k-h
diff --git a/drivers/iio/trigger/iio-trig-loop.c b/drivers/iio/trigger/iio-trig-loop.c index 9258d3cf149b..f0205a9e47d0 100644 --- a/drivers/iio/trigger/iio-trig-loop.c +++ b/drivers/iio/trigger/iio-trig-loop.c @@ -1,8 +1,7 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Copyright 2016 Jonathan Cameron <jic23@kernel.org> * - * Licensed under the GPL-2. - * * Based on a mashup of the hrtimer trigger and continuous sampling proposal of * Gregor Boirie <gregor.boirie@parrot.com> *