| Message ID | 20190813062712.24993-1-nishkadg.linux@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d777478599f781fc5162d1ae95dbee6e5ae05a41 |
| Headers | show |
| Series | drm/xen-front: Make structure fb_funcs constant | expand |
On 8/13/19 9:27 AM, Nishka Dasgupta wrote: > Static structure fb_funcs, of type drm_framebuffer_funcs, is used only > when it is passed to drm_gem_fb_create_with_funcs() as its last > argument. drm_gem_fb_create_with_funcs does not modify its lst argument > (fb_funcs) and hence fb_funcs is never modified. Therefore make fb_funcs > constant to protect it from further modification. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> > --- > drivers/gpu/drm/xen/xen_drm_front_kms.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xen/xen_drm_front_kms.c b/drivers/gpu/drm/xen/xen_drm_front_kms.c > index c2955d375394..4a984f45555e 100644 > --- a/drivers/gpu/drm/xen/xen_drm_front_kms.c > +++ b/drivers/gpu/drm/xen/xen_drm_front_kms.c > @@ -45,7 +45,7 @@ static void fb_destroy(struct drm_framebuffer *fb) > drm_gem_fb_destroy(fb); > } > > -static struct drm_framebuffer_funcs fb_funcs = { > +static const struct drm_framebuffer_funcs fb_funcs = { > .destroy = fb_destroy, > }; >
On Tue, Aug 13, 2019 at 10:32:00AM +0300, Oleksandr Andrushchenko wrote: > > On 8/13/19 9:27 AM, Nishka Dasgupta wrote: > > Static structure fb_funcs, of type drm_framebuffer_funcs, is used only > > when it is passed to drm_gem_fb_create_with_funcs() as its last > > argument. drm_gem_fb_create_with_funcs does not modify its lst argument > > (fb_funcs) and hence fb_funcs is never modified. Therefore make fb_funcs > > constant to protect it from further modification. > > Issue found with Coccinelle. > > > > Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> > Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> I'm assuming you'll apply this to drm-misc-next too? Good to state that, to avoid confusion and coordination issues. -Daniel > > --- > > drivers/gpu/drm/xen/xen_drm_front_kms.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/xen/xen_drm_front_kms.c b/drivers/gpu/drm/xen/xen_drm_front_kms.c > > index c2955d375394..4a984f45555e 100644 > > --- a/drivers/gpu/drm/xen/xen_drm_front_kms.c > > +++ b/drivers/gpu/drm/xen/xen_drm_front_kms.c > > @@ -45,7 +45,7 @@ static void fb_destroy(struct drm_framebuffer *fb) > > drm_gem_fb_destroy(fb); > > } > > -static struct drm_framebuffer_funcs fb_funcs = { > > +static const struct drm_framebuffer_funcs fb_funcs = { > > .destroy = fb_destroy, > > }; >
On 8/14/19 8:26 PM, Daniel Vetter wrote: > On Tue, Aug 13, 2019 at 10:32:00AM +0300, Oleksandr Andrushchenko wrote: >> On 8/13/19 9:27 AM, Nishka Dasgupta wrote: >>> Static structure fb_funcs, of type drm_framebuffer_funcs, is used only >>> when it is passed to drm_gem_fb_create_with_funcs() as its last >>> argument. drm_gem_fb_create_with_funcs does not modify its lst argument >>> (fb_funcs) and hence fb_funcs is never modified. Therefore make fb_funcs >>> constant to protect it from further modification. >>> Issue found with Coccinelle. >>> >>> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> >> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> > I'm assuming you'll apply this to drm-misc-next too? Good to state that, > to avoid confusion and coordination issues. > -Daniel > Sorry for the delay and confusion. Applied to drm-misc-next >>> --- >>> drivers/gpu/drm/xen/xen_drm_front_kms.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/xen/xen_drm_front_kms.c b/drivers/gpu/drm/xen/xen_drm_front_kms.c >>> index c2955d375394..4a984f45555e 100644 >>> --- a/drivers/gpu/drm/xen/xen_drm_front_kms.c >>> +++ b/drivers/gpu/drm/xen/xen_drm_front_kms.c >>> @@ -45,7 +45,7 @@ static void fb_destroy(struct drm_framebuffer *fb) >>> drm_gem_fb_destroy(fb); >>> } >>> -static struct drm_framebuffer_funcs fb_funcs = { >>> +static const struct drm_framebuffer_funcs fb_funcs = { >>> .destroy = fb_destroy, >>> };
diff --git a/drivers/gpu/drm/xen/xen_drm_front_kms.c b/drivers/gpu/drm/xen/xen_drm_front_kms.c index c2955d375394..4a984f45555e 100644 --- a/drivers/gpu/drm/xen/xen_drm_front_kms.c +++ b/drivers/gpu/drm/xen/xen_drm_front_kms.c @@ -45,7 +45,7 @@ static void fb_destroy(struct drm_framebuffer *fb) drm_gem_fb_destroy(fb); } -static struct drm_framebuffer_funcs fb_funcs = { +static const struct drm_framebuffer_funcs fb_funcs = { .destroy = fb_destroy, };
Static structure fb_funcs, of type drm_framebuffer_funcs, is used only when it is passed to drm_gem_fb_create_with_funcs() as its last argument. drm_gem_fb_create_with_funcs does not modify its lst argument (fb_funcs) and hence fb_funcs is never modified. Therefore make fb_funcs constant to protect it from further modification. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> --- drivers/gpu/drm/xen/xen_drm_front_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)