| Message ID | 20190819202507.27735-1-vt@altlinux.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ima-evm-utils: Enable large-file support | expand |
Hi Vitaly, On Mon, Aug 19, 2019 at 11:25:07PM +0300, Vitaly Chikunov wrote: > Some architectures require special measures to access large files (LFS). > Add `AC_SYS_LARGEFILE' to `configure.ac' to handle this. > > It seems that ABI is not changed with this. > > Signed-off-by: Vitaly Chikunov <vt@altlinux.org> > --- > configure.ac | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configure.ac b/configure.ac > index 3f21ba4..02bd6f8 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -8,6 +8,7 @@ AC_CONFIG_MACRO_DIR([m4]) > > AC_CANONICAL_HOST > AC_USE_SYSTEM_EXTENSIONS > +AC_SYS_LARGEFILE > Should we also add AC_FUNC_FSEEKO? I can't see any use of fseek or ftell in the code, but if we are enabling AC_SYS_LARGEFILE by default we also should check for AC_FUNC_FSEEKO in order to allow the use of fseeko/ftello whenever needed. > # Checks for programs. > AC_PROG_CC > -- > 2.11.0 >
Bruno, On Tue, Aug 20, 2019 at 12:19:39PM -0300, Bruno Meneguele wrote: > On Mon, Aug 19, 2019 at 11:25:07PM +0300, Vitaly Chikunov wrote: > > Some architectures require special measures to access large files (LFS). > > Add `AC_SYS_LARGEFILE' to `configure.ac' to handle this. > > > > It seems that ABI is not changed with this. > > > > Signed-off-by: Vitaly Chikunov <vt@altlinux.org> > > --- > > configure.ac | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/configure.ac b/configure.ac > > index 3f21ba4..02bd6f8 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -8,6 +8,7 @@ AC_CONFIG_MACRO_DIR([m4]) > > > > AC_CANONICAL_HOST > > AC_USE_SYSTEM_EXTENSIONS > > +AC_SYS_LARGEFILE > > > > Should we also add AC_FUNC_FSEEKO? > > I can't see any use of fseek or ftell in the code, but if we are > enabling AC_SYS_LARGEFILE by default we also should check for > AC_FUNC_FSEEKO in order to allow the use of fseeko/ftello whenever > needed. I thought about AC_FUNC_FSEEKO, but we don't use fseeko/ftello, so it didn't look useful. Thanks, > > > # Checks for programs. > > AC_PROG_CC > > -- > > 2.11.0 > >
On Tue, Aug 20, 2019 at 10:42:36PM +0300, Vitaly Chikunov wrote: > Bruno, > > On Tue, Aug 20, 2019 at 12:19:39PM -0300, Bruno Meneguele wrote: > > On Mon, Aug 19, 2019 at 11:25:07PM +0300, Vitaly Chikunov wrote: > > > Some architectures require special measures to access large files (LFS). > > > Add `AC_SYS_LARGEFILE' to `configure.ac' to handle this. > > > > > > It seems that ABI is not changed with this. > > > > > > Signed-off-by: Vitaly Chikunov <vt@altlinux.org> > > > --- > > > configure.ac | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/configure.ac b/configure.ac > > > index 3f21ba4..02bd6f8 100644 > > > --- a/configure.ac > > > +++ b/configure.ac > > > @@ -8,6 +8,7 @@ AC_CONFIG_MACRO_DIR([m4]) > > > > > > AC_CANONICAL_HOST > > > AC_USE_SYSTEM_EXTENSIONS > > > +AC_SYS_LARGEFILE > > > > > > > Should we also add AC_FUNC_FSEEKO? > > > > I can't see any use of fseek or ftell in the code, but if we are > > enabling AC_SYS_LARGEFILE by default we also should check for > > AC_FUNC_FSEEKO in order to allow the use of fseeko/ftello whenever > > needed. > > I thought about AC_FUNC_FSEEKO, but we don't use fseeko/ftello, so it > didn't look useful. > > Thanks, > That's fine by me :) Just was wondering if we should consider now that for possible use in future. But indeed, that'll be useful only if we would use fseeko/ftello. Thanks. Reviewed-by: Bruno Meneguele <bmeneg@redhat.com> > > > > > > # Checks for programs. > > > AC_PROG_CC > > > -- > > > 2.11.0 > > > > >
diff --git a/configure.ac b/configure.ac index 3f21ba4..02bd6f8 100644 --- a/configure.ac +++ b/configure.ac @@ -8,6 +8,7 @@ AC_CONFIG_MACRO_DIR([m4]) AC_CANONICAL_HOST AC_USE_SYSTEM_EXTENSIONS +AC_SYS_LARGEFILE # Checks for programs. AC_PROG_CC
Some architectures require special measures to access large files (LFS). Add `AC_SYS_LARGEFILE' to `configure.ac' to handle this. It seems that ABI is not changed with this. Signed-off-by: Vitaly Chikunov <vt@altlinux.org> --- configure.ac | 1 + 1 file changed, 1 insertion(+)