| Message ID | 20190815205420.23852-1-anusha.srivatsa@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] drm/dp/dsc: Add Support for all BPCs supported by TGL | expand |
On Thu, Aug 15, 2019 at 01:54:20PM -0700, Anusha Srivatsa wrote: > DSC engine on ICL supports only 8 and 10 BPC as the input > BPC. But DSC engine in TGL supports 8, 10 and 12 BPC. > Add 12 BPC support for DSC while calculating compression > configuration. > > v2: Remove the separate define TGL_DP_DSC_MAX_SUPPORTED_BPC > and use the value directly.(More such defines can be removed > as part of future patches). (Ville) > > v3: Use values directly instead of accessing the defines > everytime for min and max DSC BPC. > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Manasi Navare <manasi.d.navare@intel.com> > Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com> Looks good to me, Reviewed-by: Manasi Navare <manasi.d.navare@intel.com> Manasi > --- > drivers/gpu/drm/i915/display/intel_dp.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 4884c87c8ed7..f9d2438d7da9 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -70,8 +70,6 @@ > > /* DP DSC small joiner has 2 FIFOs each of 640 x 6 bytes */ > #define DP_DSC_MAX_SMALL_JOINER_RAM_BUFFER 61440 > -#define DP_DSC_MIN_SUPPORTED_BPC 8 > -#define DP_DSC_MAX_SUPPORTED_BPC 10 > > /* DP DSC throughput values used for slice count calculations KPixels/s */ > #define DP_DSC_PEAK_PIXEL_RATE 2720000 > @@ -1915,11 +1913,17 @@ static int intel_dp_dsc_compute_config(struct intel_dp *intel_dp, > if (!intel_dp_supports_dsc(intel_dp, pipe_config)) > return -EINVAL; > > - dsc_max_bpc = min_t(u8, DP_DSC_MAX_SUPPORTED_BPC, > - conn_state->max_requested_bpc); > + /* Max DSC Input BPC for ICL is 10 and for TGL+ is 12 */ > + if (INTEL_GEN(dev_priv) >= 12) > + dsc_max_bpc = min_t(u8, 12, conn_state->max_requested_bpc); > + else > + dsc_max_bpc = min_t(u8, 10, > + conn_state->max_requested_bpc); > > pipe_bpp = intel_dp_dsc_compute_bpp(intel_dp, dsc_max_bpc); > - if (pipe_bpp < DP_DSC_MIN_SUPPORTED_BPC * 3) { > + > + /* Min Input BPC for ICL+ is 8 */ > + if (pipe_bpp < 8 * 3) { > DRM_DEBUG_KMS("No DSC support for less than 8bpc\n"); > return -EINVAL; > } > -- > 2.22.1 >
Hi Anusha, Could you take a look at these failures and make sure they are not caused by this patch so I can merge this? Manasi On Fri, Aug 16, 2019 at 02:24:38PM +0000, Patchwork wrote: > == Series Details == > > Series: drm/dp/dsc: Add Support for all BPCs supported by TGL (rev4) > URL : https://patchwork.freedesktop.org/series/63526/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_6713_full -> Patchwork_14038_full > ==================================================== > > Summary > ------- > > **FAILURE** > > Serious unknown changes coming with Patchwork_14038_full absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_14038_full, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > > > Possible new issues > ------------------- > > Here are the unknown changes that may have been introduced in Patchwork_14038_full: > > ### IGT changes ### > > #### Possible regressions #### > > * igt@gem_exec_create@forked: > - shard-glk: [PASS][1] -> [TIMEOUT][2] +1 similar issue > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-glk7/igt@gem_exec_create@forked.html > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-glk7/igt@gem_exec_create@forked.html > > > Known issues > ------------ > > Here are the changes found in Patchwork_14038_full that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@gem_ctx_isolation@rcs0-s3: > - shard-apl: [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +3 similar issues > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-apl7/igt@gem_ctx_isolation@rcs0-s3.html > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-apl1/igt@gem_ctx_isolation@rcs0-s3.html > > * igt@gem_exec_schedule@independent-render: > - shard-iclb: [PASS][5] -> [INCOMPLETE][6] ([fdo#107713]) +1 similar issue > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-iclb6/igt@gem_exec_schedule@independent-render.html > [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb7/igt@gem_exec_schedule@independent-render.html > > * igt@gem_exec_schedule@preempt-other-chain-bsd: > - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#111325]) +7 similar issues > [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-iclb8/igt@gem_exec_schedule@preempt-other-chain-bsd.html > [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html > > * igt@gem_exec_schedule@preempt-queue-contexts-bsd1: > - shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109276]) +8 similar issues > [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-iclb4/igt@gem_exec_schedule@preempt-queue-contexts-bsd1.html > [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb7/igt@gem_exec_schedule@preempt-queue-contexts-bsd1.html > > * igt@kms_color@pipe-a-ctm-blue-to-red: > - shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([fdo#103558] / [fdo#105602]) +9 similar issues > [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-kbl2/igt@kms_color@pipe-a-ctm-blue-to-red.html > [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-kbl1/igt@kms_color@pipe-a-ctm-blue-to-red.html > > * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy: > - shard-hsw: [PASS][13] -> [FAIL][14] ([fdo#105767]) > [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html > [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-hsw4/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html > > * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible: > - shard-glk: [PASS][15] -> [FAIL][16] ([fdo#105363]) > [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html > [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html > > * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render: > - shard-iclb: [PASS][17] -> [FAIL][18] ([fdo#103167]) +4 similar issues > [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html > [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html > > * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: > - shard-skl: [PASS][19] -> [FAIL][20] ([fdo#108145]) > [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html > [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html > > * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: > - shard-skl: [PASS][21] -> [FAIL][22] ([fdo#108145] / [fdo#110403]) > [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html > [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html > > * igt@kms_psr@psr2_primary_mmap_gtt: > - shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#109441]) > [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html > [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb8/igt@kms_psr@psr2_primary_mmap_gtt.html > > > #### Possible fixes #### > > * igt@gem_ctx_shared@exec-single-timeline-bsd: > - shard-iclb: [SKIP][25] ([fdo#110841]) -> [PASS][26] > [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html > [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd.html > > * igt@gem_exec_schedule@independent-bsd: > - shard-iclb: [SKIP][27] ([fdo#111325]) -> [PASS][28] > [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-iclb2/igt@gem_exec_schedule@independent-bsd.html > [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb6/igt@gem_exec_schedule@independent-bsd.html > > * igt@gem_exec_schedule@independent-bsd2: > - shard-iclb: [SKIP][29] ([fdo#109276]) -> [PASS][30] +8 similar issues > [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-iclb5/igt@gem_exec_schedule@independent-bsd2.html > [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb1/igt@gem_exec_schedule@independent-bsd2.html > > * igt@i915_pm_rc6_residency@rc6-accuracy: > - shard-snb: [SKIP][31] ([fdo#109271]) -> [PASS][32] > [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-snb1/igt@i915_pm_rc6_residency@rc6-accuracy.html > [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-snb4/igt@i915_pm_rc6_residency@rc6-accuracy.html > > * igt@kms_big_fb@x-tiled-8bpp-rotate-0: > - shard-apl: [INCOMPLETE][33] ([fdo#103927]) -> [PASS][34] +1 similar issue > [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-apl3/igt@kms_big_fb@x-tiled-8bpp-rotate-0.html > [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-apl2/igt@kms_big_fb@x-tiled-8bpp-rotate-0.html > > * igt@kms_cursor_crc@pipe-c-cursor-128x128-random: > - shard-skl: [FAIL][35] ([fdo#103232]) -> [PASS][36] +1 similar issue > [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-skl8/igt@kms_cursor_crc@pipe-c-cursor-128x128-random.html > [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-skl2/igt@kms_cursor_crc@pipe-c-cursor-128x128-random.html > > * igt@kms_cursor_legacy@cursor-vs-flip-toggle: > - shard-hsw: [FAIL][37] ([fdo#103355]) -> [PASS][38] > [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-hsw1/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html > [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-hsw5/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html > > * igt@kms_cursor_legacy@pipe-a-forked-move: > - shard-skl: [INCOMPLETE][39] -> [PASS][40] > [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-skl3/igt@kms_cursor_legacy@pipe-a-forked-move.html > [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-skl5/igt@kms_cursor_legacy@pipe-a-forked-move.html > > * igt@kms_flip@plain-flip-ts-check: > - shard-skl: [FAIL][41] ([fdo#100368]) -> [PASS][42] > [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-skl4/igt@kms_flip@plain-flip-ts-check.html > [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-skl6/igt@kms_flip@plain-flip-ts-check.html > > * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite: > - shard-iclb: [FAIL][43] ([fdo#103167]) -> [PASS][44] +3 similar issues > [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html > [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html > > * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min: > - shard-skl: [FAIL][45] ([fdo#108145]) -> [PASS][46] +1 similar issue > [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html > [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html > > * igt@kms_plane_lowres@pipe-a-tiling-y: > - shard-iclb: [FAIL][47] ([fdo#103166]) -> [PASS][48] > [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-y.html > [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-y.html > > * igt@kms_vblank@pipe-c-ts-continuation-suspend: > - shard-apl: [DMESG-WARN][49] ([fdo#108566]) -> [PASS][50] +1 similar issue > [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-apl5/igt@kms_vblank@pipe-c-ts-continuation-suspend.html > [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-apl7/igt@kms_vblank@pipe-c-ts-continuation-suspend.html > > * igt@perf@blocking: > - shard-skl: [FAIL][51] ([fdo#110728]) -> [PASS][52] > [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-skl8/igt@perf@blocking.html > [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-skl2/igt@perf@blocking.html > > * igt@perf_pmu@semaphore-wait-rcs0: > - shard-glk: [INCOMPLETE][53] ([fdo#103359] / [k.org#198133]) -> [PASS][54] > [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-glk9/igt@perf_pmu@semaphore-wait-rcs0.html > [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-glk6/igt@perf_pmu@semaphore-wait-rcs0.html > > > #### Warnings #### > > * igt@gem_mocs_settings@mocs-isolation-bsd2: > - shard-iclb: [FAIL][55] ([fdo#111330]) -> [SKIP][56] ([fdo#109276]) > [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-iclb2/igt@gem_mocs_settings@mocs-isolation-bsd2.html > [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb8/igt@gem_mocs_settings@mocs-isolation-bsd2.html > > * igt@kms_big_fb@linear-8bpp-rotate-90: > - shard-kbl: [SKIP][57] ([fdo#109271]) -> [SKIP][58] ([fdo#105602] / [fdo#109271]) +1 similar issue > [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard-kbl2/igt@kms_big_fb@linear-8bpp-rotate-90.html > [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-kbl1/igt@kms_big_fb@linear-8bpp-rotate-90.html > > > [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368 > [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 > [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 > [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 > [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355 > [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359 > [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558 > [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 > [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 > [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602 > [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767 > [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 > [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 > [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 > [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 > [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 > [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 > [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403 > [fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728 > [fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841 > [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325 > [fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330 > [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133 > > > Participating hosts (10 -> 10) > ------------------------------ > > No changes in participating hosts > > > Build changes > ------------- > > * CI: CI-20190529 -> None > * Linux: CI_DRM_6713 -> Patchwork_14038 > > CI-20190529: 20190529 > CI_DRM_6713: 12afcdd96e32c94a34c0205304772f754b668f8d @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_5138: b9abe0bf6c478c4f6cac56bff286d6926ad8c0ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > Patchwork_14038: 273e6a2bf6e0f19cb2e29fb9450254ab83243bd4 @ git://anongit.freedesktop.org/gfx-ci/linux > piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/ > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Sent the patch again with CI tag, to check the results. Anusha > -----Original Message----- > From: Navare, Manasi D > Sent: Monday, August 19, 2019 4:06 PM > To: intel-gfx@lists.freedesktop.org > Cc: Srivatsa, Anusha <anusha.srivatsa@intel.com> > Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/dp/dsc: Add Support for all > BPCs supported by TGL (rev4) > > Hi Anusha, > > Could you take a look at these failures and make sure they are not caused by this > patch so I can merge this? > > Manasi > > > On Fri, Aug 16, 2019 at 02:24:38PM +0000, Patchwork wrote: > > == Series Details == > > > > Series: drm/dp/dsc: Add Support for all BPCs supported by TGL (rev4) > > URL : https://patchwork.freedesktop.org/series/63526/ > > State : failure > > > > == Summary == > > > > CI Bug Log - changes from CI_DRM_6713_full -> Patchwork_14038_full > > ==================================================== > > > > Summary > > ------- > > > > **FAILURE** > > > > Serious unknown changes coming with Patchwork_14038_full absolutely > need to be > > verified manually. > > > > If you think the reported changes have nothing to do with the changes > > introduced in Patchwork_14038_full, please notify your bug team to allow > them > > to document this new failure mode, which will reduce false positives in CI. > > > > > > > > Possible new issues > > ------------------- > > > > Here are the unknown changes that may have been introduced in > Patchwork_14038_full: > > > > ### IGT changes ### > > > > #### Possible regressions #### > > > > * igt@gem_exec_create@forked: > > - shard-glk: [PASS][1] -> [TIMEOUT][2] +1 similar issue > > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > glk7/igt@gem_exec_create@forked.html > > [2]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-glk7/ig > > t@gem_exec_create@forked.html > > > > > > Known issues > > ------------ > > > > Here are the changes found in Patchwork_14038_full that come from known > issues: > > > > ### IGT changes ### > > > > #### Issues hit #### > > > > * igt@gem_ctx_isolation@rcs0-s3: > > - shard-apl: [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +3 similar > issues > > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > apl7/igt@gem_ctx_isolation@rcs0-s3.html > > [4]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-apl1/ig > > t@gem_ctx_isolation@rcs0-s3.html > > > > * igt@gem_exec_schedule@independent-render: > > - shard-iclb: [PASS][5] -> [INCOMPLETE][6] ([fdo#107713]) +1 similar > issue > > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > iclb6/igt@gem_exec_schedule@independent-render.html > > [6]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb7/i > > gt@gem_exec_schedule@independent-render.html > > > > * igt@gem_exec_schedule@preempt-other-chain-bsd: > > - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#111325]) +7 similar issues > > [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > iclb8/igt@gem_exec_schedule@preempt-other-chain-bsd.html > > [8]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb1/i > > gt@gem_exec_schedule@preempt-other-chain-bsd.html > > > > * igt@gem_exec_schedule@preempt-queue-contexts-bsd1: > > - shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109276]) +8 similar issues > > [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > iclb4/igt@gem_exec_schedule@preempt-queue-contexts-bsd1.html > > [10]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb7/i > > gt@gem_exec_schedule@preempt-queue-contexts-bsd1.html > > > > * igt@kms_color@pipe-a-ctm-blue-to-red: > > - shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([fdo#103558] / > [fdo#105602]) +9 similar issues > > [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > kbl2/igt@kms_color@pipe-a-ctm-blue-to-red.html > > [12]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-kbl1/ig > > t@kms_color@pipe-a-ctm-blue-to-red.html > > > > * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy: > > - shard-hsw: [PASS][13] -> [FAIL][14] ([fdo#105767]) > > [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html > > [14]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-hsw4/ig > > t@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html > > > > * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible: > > - shard-glk: [PASS][15] -> [FAIL][16] ([fdo#105363]) > > [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html > > [16]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-glk9/ig > > t@kms_flip@2x-flip-vs-expired-vblank-interruptible.html > > > > * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render: > > - shard-iclb: [PASS][17] -> [FAIL][18] ([fdo#103167]) +4 similar issues > > [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw- > render.html > > [18]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb2/i > > gt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.h > > tml > > > > * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: > > - shard-skl: [PASS][19] -> [FAIL][20] ([fdo#108145]) > > [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > skl8/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html > > [20]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-skl2/ig > > t@kms_plane_alpha_blend@pipe-a-coverage-7efc.html > > > > * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: > > - shard-skl: [PASS][21] -> [FAIL][22] ([fdo#108145] / [fdo#110403]) > > [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html > > [22]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-skl2/ig > > t@kms_plane_alpha_blend@pipe-c-coverage-7efc.html > > > > * igt@kms_psr@psr2_primary_mmap_gtt: > > - shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#109441]) > > [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html > > [24]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb8/i > > gt@kms_psr@psr2_primary_mmap_gtt.html > > > > > > #### Possible fixes #### > > > > * igt@gem_ctx_shared@exec-single-timeline-bsd: > > - shard-iclb: [SKIP][25] ([fdo#110841]) -> [PASS][26] > > [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html > > [26]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb5/i > > gt@gem_ctx_shared@exec-single-timeline-bsd.html > > > > * igt@gem_exec_schedule@independent-bsd: > > - shard-iclb: [SKIP][27] ([fdo#111325]) -> [PASS][28] > > [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > iclb2/igt@gem_exec_schedule@independent-bsd.html > > [28]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb6/i > > gt@gem_exec_schedule@independent-bsd.html > > > > * igt@gem_exec_schedule@independent-bsd2: > > - shard-iclb: [SKIP][29] ([fdo#109276]) -> [PASS][30] +8 similar issues > > [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > iclb5/igt@gem_exec_schedule@independent-bsd2.html > > [30]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb1/i > > gt@gem_exec_schedule@independent-bsd2.html > > > > * igt@i915_pm_rc6_residency@rc6-accuracy: > > - shard-snb: [SKIP][31] ([fdo#109271]) -> [PASS][32] > > [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > snb1/igt@i915_pm_rc6_residency@rc6-accuracy.html > > [32]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-snb4/ig > > t@i915_pm_rc6_residency@rc6-accuracy.html > > > > * igt@kms_big_fb@x-tiled-8bpp-rotate-0: > > - shard-apl: [INCOMPLETE][33] ([fdo#103927]) -> [PASS][34] +1 similar > issue > > [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > apl3/igt@kms_big_fb@x-tiled-8bpp-rotate-0.html > > [34]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-apl2/ig > > t@kms_big_fb@x-tiled-8bpp-rotate-0.html > > > > * igt@kms_cursor_crc@pipe-c-cursor-128x128-random: > > - shard-skl: [FAIL][35] ([fdo#103232]) -> [PASS][36] +1 similar issue > > [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > skl8/igt@kms_cursor_crc@pipe-c-cursor-128x128-random.html > > [36]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-skl2/ig > > t@kms_cursor_crc@pipe-c-cursor-128x128-random.html > > > > * igt@kms_cursor_legacy@cursor-vs-flip-toggle: > > - shard-hsw: [FAIL][37] ([fdo#103355]) -> [PASS][38] > > [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > hsw1/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html > > [38]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-hsw5/ig > > t@kms_cursor_legacy@cursor-vs-flip-toggle.html > > > > * igt@kms_cursor_legacy@pipe-a-forked-move: > > - shard-skl: [INCOMPLETE][39] -> [PASS][40] > > [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > skl3/igt@kms_cursor_legacy@pipe-a-forked-move.html > > [40]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-skl5/ig > > t@kms_cursor_legacy@pipe-a-forked-move.html > > > > * igt@kms_flip@plain-flip-ts-check: > > - shard-skl: [FAIL][41] ([fdo#100368]) -> [PASS][42] > > [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > skl4/igt@kms_flip@plain-flip-ts-check.html > > [42]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-skl6/ig > > t@kms_flip@plain-flip-ts-check.html > > > > * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite: > > - shard-iclb: [FAIL][43] ([fdo#103167]) -> [PASS][44] +3 similar issues > > [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw- > pwrite.html > > [44]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb8/i > > gt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.h > > tml > > > > * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min: > > - shard-skl: [FAIL][45] ([fdo#108145]) -> [PASS][46] +1 similar issue > > [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > skl8/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html > > [46]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-skl2/ig > > t@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html > > > > * igt@kms_plane_lowres@pipe-a-tiling-y: > > - shard-iclb: [FAIL][47] ([fdo#103166]) -> [PASS][48] > > [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > iclb1/igt@kms_plane_lowres@pipe-a-tiling-y.html > > [48]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb5/i > > gt@kms_plane_lowres@pipe-a-tiling-y.html > > > > * igt@kms_vblank@pipe-c-ts-continuation-suspend: > > - shard-apl: [DMESG-WARN][49] ([fdo#108566]) -> [PASS][50] +1 > similar issue > > [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > apl5/igt@kms_vblank@pipe-c-ts-continuation-suspend.html > > [50]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-apl7/ig > > t@kms_vblank@pipe-c-ts-continuation-suspend.html > > > > * igt@perf@blocking: > > - shard-skl: [FAIL][51] ([fdo#110728]) -> [PASS][52] > > [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > skl8/igt@perf@blocking.html > > [52]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-skl2/ig > > t@perf@blocking.html > > > > * igt@perf_pmu@semaphore-wait-rcs0: > > - shard-glk: [INCOMPLETE][53] ([fdo#103359] / [k.org#198133]) -> > [PASS][54] > > [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > glk9/igt@perf_pmu@semaphore-wait-rcs0.html > > [54]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-glk6/ig > > t@perf_pmu@semaphore-wait-rcs0.html > > > > > > #### Warnings #### > > > > * igt@gem_mocs_settings@mocs-isolation-bsd2: > > - shard-iclb: [FAIL][55] ([fdo#111330]) -> [SKIP][56] ([fdo#109276]) > > [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > iclb2/igt@gem_mocs_settings@mocs-isolation-bsd2.html > > [56]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-iclb8/i > > gt@gem_mocs_settings@mocs-isolation-bsd2.html > > > > * igt@kms_big_fb@linear-8bpp-rotate-90: > > - shard-kbl: [SKIP][57] ([fdo#109271]) -> [SKIP][58] ([fdo#105602] / > [fdo#109271]) +1 similar issue > > [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6713/shard- > kbl2/igt@kms_big_fb@linear-8bpp-rotate-90.html > > [58]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/shard-kbl1/ig > > t@kms_big_fb@linear-8bpp-rotate-90.html > > > > > > [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368 > > [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 > > [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 > > [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 > > [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355 > > [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359 > > [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558 > > [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 > > [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 > > [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602 > > [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767 > > [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 > > [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 > > [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 > > [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 > > [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 > > [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 > > [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403 > > [fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728 > > [fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841 > > [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325 > > [fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330 > > [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133 > > > > > > Participating hosts (10 -> 10) > > ------------------------------ > > > > No changes in participating hosts > > > > > > Build changes > > ------------- > > > > * CI: CI-20190529 -> None > > * Linux: CI_DRM_6713 -> Patchwork_14038 > > > > CI-20190529: 20190529 > > CI_DRM_6713: 12afcdd96e32c94a34c0205304772f754b668f8d @ > git://anongit.freedesktop.org/gfx-ci/linux > > IGT_5138: b9abe0bf6c478c4f6cac56bff286d6926ad8c0ab @ > git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > > Patchwork_14038: 273e6a2bf6e0f19cb2e29fb9450254ab83243bd4 @ > git://anongit.freedesktop.org/gfx-ci/linux > > piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ > > git://anongit.freedesktop.org/piglit > > > > == Logs == > > > > For more details see: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14038/ > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 4884c87c8ed7..f9d2438d7da9 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -70,8 +70,6 @@ /* DP DSC small joiner has 2 FIFOs each of 640 x 6 bytes */ #define DP_DSC_MAX_SMALL_JOINER_RAM_BUFFER 61440 -#define DP_DSC_MIN_SUPPORTED_BPC 8 -#define DP_DSC_MAX_SUPPORTED_BPC 10 /* DP DSC throughput values used for slice count calculations KPixels/s */ #define DP_DSC_PEAK_PIXEL_RATE 2720000 @@ -1915,11 +1913,17 @@ static int intel_dp_dsc_compute_config(struct intel_dp *intel_dp, if (!intel_dp_supports_dsc(intel_dp, pipe_config)) return -EINVAL; - dsc_max_bpc = min_t(u8, DP_DSC_MAX_SUPPORTED_BPC, - conn_state->max_requested_bpc); + /* Max DSC Input BPC for ICL is 10 and for TGL+ is 12 */ + if (INTEL_GEN(dev_priv) >= 12) + dsc_max_bpc = min_t(u8, 12, conn_state->max_requested_bpc); + else + dsc_max_bpc = min_t(u8, 10, + conn_state->max_requested_bpc); pipe_bpp = intel_dp_dsc_compute_bpp(intel_dp, dsc_max_bpc); - if (pipe_bpp < DP_DSC_MIN_SUPPORTED_BPC * 3) { + + /* Min Input BPC for ICL+ is 8 */ + if (pipe_bpp < 8 * 3) { DRM_DEBUG_KMS("No DSC support for less than 8bpc\n"); return -EINVAL; }
DSC engine on ICL supports only 8 and 10 BPC as the input BPC. But DSC engine in TGL supports 8, 10 and 12 BPC. Add 12 BPC support for DSC while calculating compression configuration. v2: Remove the separate define TGL_DP_DSC_MAX_SUPPORTED_BPC and use the value directly.(More such defines can be removed as part of future patches). (Ville) v3: Use values directly instead of accessing the defines everytime for min and max DSC BPC. Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Manasi Navare <manasi.d.navare@intel.com> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com> --- drivers/gpu/drm/i915/display/intel_dp.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-)