| Message ID | 20190823073109.GR3504@valkosipuli.retiisi.org.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [GIT,PULL,for,5.4] A10 CSI driver and atmel-isi fix | expand |
From: builder@linuxtv.org
Pull request: https://patchwork.linuxtv.org/patch/58382/
Build log: https://builder.linuxtv.org/job/patchwork/12895/
Build time: 00:04:55
Link: https://lore.kernel.org/linux-media/20190823073109.GR3504@valkosipuli.retiisi.org.uk
gpg: Signature made Fri 23 Aug 2019 07:25:49 AM UTC
gpg: using DSA key F0D0377A0D4F25A79238EFE56D40361B6E28C193
gpg: issuer "sakari.ailus@linux.intel.com"
gpg: Good signature from "Sakari Ailus <sakari.ailus@linux.intel.com>" [full]
Summary: 2 patches and/or PDF generation with issues, being 0 at build time
Error/warnings:
patches/0003-media-sunxi-Refactor-the-Makefile-and-Kconfig.patch:46: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0003-media-sunxi-Refactor-the-Makefile-and-Kconfig.patch
patches/0004-media-sunxi-Add-A10-CSI-driver.patch:564: CHECK: spinlock_t definition without comment
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0004-media-sunxi-Add-A10-CSI-driver.patch
Hi Maxime, On 8/23/19 9:31 AM, Sakari Ailus wrote: > Hi Mauro, > > Here's a driver for A10 CSI parallel receiver and a fix for atmel-isi. > > There are three checkpatch.pl warnings; two on Makefile / Kconfig on > MAINTAINERS (i.e. not worth mentioning in MAINTAINERS) while the third is > on a spinlock missing a comment. If you'd like the last one to be > addressed, I'm proposing doing that in a separate patch. When running sparse I get this warning: drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c:21:31: warning: symbol 'sun4i_csi_formats' was not declared. Should it be static? Can you post a follow-up patch for this? Regards, Hans > > Please pull. > > > The following changes since commit 01faced6f65d0224bf6ce1262a4137771e28519f: > > media: dt-bindings: media: Convert Allwinner A10 IR to a schema (2019-08-21 18:39:55 -0300) > > are available in the Git repository at: > > git://linuxtv.org/sailus/media_tree.git tags/for-5.4-7-signed > > for you to fetch changes up to 494630237a2ce13f1e0b8fe06b48811ce5254ce4: > > media: sunxi: Add A10 CSI driver (2019-08-23 10:25:33 +0300) > > ---------------------------------------------------------------- > A10 CSI1 driver + sensor fix > > ---------------------------------------------------------------- > Alexandre Kroupski (1): > media: atmel: atmel-isi: fix timeout value for stop streaming > > Maxime Ripard (3): > dt-bindings: media: Add Allwinner A10 CSI binding > media: sunxi: Refactor the Makefile and Kconfig > media: sunxi: Add A10 CSI driver > > .../bindings/media/allwinner,sun4i-a10-csi.yaml | 109 +++++ > MAINTAINERS | 8 + > drivers/media/platform/Kconfig | 2 +- > drivers/media/platform/Makefile | 2 +- > drivers/media/platform/atmel/atmel-isi.c | 2 +- > drivers/media/platform/sunxi/Kconfig | 2 + > drivers/media/platform/sunxi/Makefile | 2 + > drivers/media/platform/sunxi/sun4i-csi/Kconfig | 11 + > drivers/media/platform/sunxi/sun4i-csi/Makefile | 5 + > drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c | 314 ++++++++++++++ > drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.h | 160 ++++++++ > drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c | 454 +++++++++++++++++++++ > .../media/platform/sunxi/sun4i-csi/sun4i_v4l2.c | 385 +++++++++++++++++ > 13 files changed, 1453 insertions(+), 3 deletions(-) > create mode 100644 Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml > create mode 100644 drivers/media/platform/sunxi/Kconfig > create mode 100644 drivers/media/platform/sunxi/Makefile > create mode 100644 drivers/media/platform/sunxi/sun4i-csi/Kconfig > create mode 100644 drivers/media/platform/sunxi/sun4i-csi/Makefile > create mode 100644 drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c > create mode 100644 drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.h > create mode 100644 drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c > create mode 100644 drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c >
Hi Hans, On Fri, Aug 23, 2019 at 01:55:07PM +0200, Hans Verkuil wrote: > Hi Maxime, > > On 8/23/19 9:31 AM, Sakari Ailus wrote: > > Hi Mauro, > > > > Here's a driver for A10 CSI parallel receiver and a fix for atmel-isi. > > > > There are three checkpatch.pl warnings; two on Makefile / Kconfig on > > MAINTAINERS (i.e. not worth mentioning in MAINTAINERS) while the third is > > on a spinlock missing a comment. If you'd like the last one to be > > addressed, I'm proposing doing that in a separate patch. > > When running sparse I get this warning: > > drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c:21:31: warning: symbol 'sun4i_csi_formats' was not declared. Should it be static? > > Can you post a follow-up patch for this? Sorry for that, I just sent a patch fixing it. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Hi Mauro, Here's a driver for A10 CSI parallel receiver and a fix for atmel-isi. There are three checkpatch.pl warnings; two on Makefile / Kconfig on MAINTAINERS (i.e. not worth mentioning in MAINTAINERS) while the third is on a spinlock missing a comment. If you'd like the last one to be addressed, I'm proposing doing that in a separate patch. Please pull. The following changes since commit 01faced6f65d0224bf6ce1262a4137771e28519f: media: dt-bindings: media: Convert Allwinner A10 IR to a schema (2019-08-21 18:39:55 -0300) are available in the Git repository at: git://linuxtv.org/sailus/media_tree.git tags/for-5.4-7-signed for you to fetch changes up to 494630237a2ce13f1e0b8fe06b48811ce5254ce4: media: sunxi: Add A10 CSI driver (2019-08-23 10:25:33 +0300) ---------------------------------------------------------------- A10 CSI1 driver + sensor fix ---------------------------------------------------------------- Alexandre Kroupski (1): media: atmel: atmel-isi: fix timeout value for stop streaming Maxime Ripard (3): dt-bindings: media: Add Allwinner A10 CSI binding media: sunxi: Refactor the Makefile and Kconfig media: sunxi: Add A10 CSI driver .../bindings/media/allwinner,sun4i-a10-csi.yaml | 109 +++++ MAINTAINERS | 8 + drivers/media/platform/Kconfig | 2 +- drivers/media/platform/Makefile | 2 +- drivers/media/platform/atmel/atmel-isi.c | 2 +- drivers/media/platform/sunxi/Kconfig | 2 + drivers/media/platform/sunxi/Makefile | 2 + drivers/media/platform/sunxi/sun4i-csi/Kconfig | 11 + drivers/media/platform/sunxi/sun4i-csi/Makefile | 5 + drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c | 314 ++++++++++++++ drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.h | 160 ++++++++ drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c | 454 +++++++++++++++++++++ .../media/platform/sunxi/sun4i-csi/sun4i_v4l2.c | 385 +++++++++++++++++ 13 files changed, 1453 insertions(+), 3 deletions(-) create mode 100644 Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml create mode 100644 drivers/media/platform/sunxi/Kconfig create mode 100644 drivers/media/platform/sunxi/Makefile create mode 100644 drivers/media/platform/sunxi/sun4i-csi/Kconfig create mode 100644 drivers/media/platform/sunxi/sun4i-csi/Makefile create mode 100644 drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c create mode 100644 drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.h create mode 100644 drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c create mode 100644 drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c