| Message ID | 20190826104636.19324-5-i.mikhaylov@yadro.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | add dual-boot support | expand |
On Mon, 26 Aug 2019, at 20:17, Ivan Mikhaylov wrote: > The option for the ast2400/2500 to get access to CS0 at runtime. > > Signed-off-by: Ivan Mikhaylov <i.mikhaylov@yadro.com> > --- > Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > index c5077a1f5cb3..023a9b578df6 100644 > --- a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > @@ -34,6 +34,13 @@ Optional properties: > engine is responsible for this. > > - aspeed,alt-boot: If property is present then boot from alternate > block. > + At alternate side 'access_cs0' sysfs file > provides: Why are we talking about sysfs in the devicetree binding? This patch doesn't seem right to me. Also if we're not supporting the aspeed,alt-boot property we should probably document it as deprecated rather than making it disappear, unless you're going to fix the systems that are using it. Andrew
On 8/26/19 4:57 PM, Andrew Jeffery wrote: > > > On Mon, 26 Aug 2019, at 20:17, Ivan Mikhaylov wrote: >> The option for the ast2400/2500 to get access to CS0 at runtime. >> >> Signed-off-by: Ivan Mikhaylov <i.mikhaylov@yadro.com> >> --- >> Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt >> b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt >> index c5077a1f5cb3..023a9b578df6 100644 >> --- a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt >> +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt >> @@ -34,6 +34,13 @@ Optional properties: >> engine is responsible for this. >> >> - aspeed,alt-boot: If property is present then boot from alternate >> block. >> + At alternate side 'access_cs0' sysfs file >> provides: > > Why are we talking about sysfs in the devicetree binding? This patch > doesn't seem right to me. > Correct; this is the wrong document. The attribute also will need to be better explained. "At alternate side" does not explain (at least not at all clearly enough) that the attribute only exists if the system has booted from the alternate flash / block. > Also if we're not supporting the aspeed,alt-boot property we should > probably document it as deprecated rather than making it disappear, > unless you're going to fix the systems that are using it. > Sorry, you lost me here. Where is it made to disappear ? Guenter
On Tue, 27 Aug 2019, at 09:38, Guenter Roeck wrote: > On 8/26/19 4:57 PM, Andrew Jeffery wrote: > > > > > > On Mon, 26 Aug 2019, at 20:17, Ivan Mikhaylov wrote: > >> The option for the ast2400/2500 to get access to CS0 at runtime. > >> > >> Signed-off-by: Ivan Mikhaylov <i.mikhaylov@yadro.com> > >> --- > >> Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > >> b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > >> index c5077a1f5cb3..023a9b578df6 100644 > >> --- a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > >> +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > >> @@ -34,6 +34,13 @@ Optional properties: > >> engine is responsible for this. > >> > >> - aspeed,alt-boot: If property is present then boot from alternate > >> block. > >> + At alternate side 'access_cs0' sysfs file > >> provides: > > > > Why are we talking about sysfs in the devicetree binding? This patch > > doesn't seem right to me. > > > > Correct; this is the wrong document. The attribute also will need > to be better explained. "At alternate side" does not explain (at > least not at all clearly enough) that the attribute only exists > if the system has booted from the alternate flash / block. > > > Also if we're not supporting the aspeed,alt-boot property we should > > probably document it as deprecated rather than making it disappear, > > unless you're going to fix the systems that are using it. > > > Sorry, you lost me here. Where is it made to disappear ? Oh, hah, I read the bullet '-' as a diff marker. Maybe I should go back to bed! Andrew
On Mon, Aug 26, 2019 at 01:46:36PM +0300, Ivan Mikhaylov wrote: > The option for the ast2400/2500 to get access to CS0 at runtime. > > Signed-off-by: Ivan Mikhaylov <i.mikhaylov@yadro.com> > --- > Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > index c5077a1f5cb3..023a9b578df6 100644 > --- a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > @@ -34,6 +34,13 @@ Optional properties: > engine is responsible for this. > > - aspeed,alt-boot: If property is present then boot from alternate block. > + At alternate side 'access_cs0' sysfs file provides: What's sysfs? Don't put Linux stuff in bindings. > + ast2400: a way to get access to the primary SPI flash > + chip at CS0 after booting from the alternate > + chip at CS1. > + ast2500: a way to restore the normal address mapping from > + (CS0->CS1, CS1->CS0) to (CS0->CS0, CS1->CS1). > + > - aspeed,external-signal: If property is present then signal is sent to > external reset counter (only WDT1 and WDT2). If not > specified no external signal is sent. > -- > 2.20.1 >
diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt index c5077a1f5cb3..023a9b578df6 100644 --- a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt @@ -34,6 +34,13 @@ Optional properties: engine is responsible for this. - aspeed,alt-boot: If property is present then boot from alternate block. + At alternate side 'access_cs0' sysfs file provides: + ast2400: a way to get access to the primary SPI flash + chip at CS0 after booting from the alternate + chip at CS1. + ast2500: a way to restore the normal address mapping from + (CS0->CS1, CS1->CS0) to (CS0->CS0, CS1->CS1). + - aspeed,external-signal: If property is present then signal is sent to external reset counter (only WDT1 and WDT2). If not specified no external signal is sent.
The option for the ast2400/2500 to get access to CS0 at runtime. Signed-off-by: Ivan Mikhaylov <i.mikhaylov@yadro.com> --- Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 7 +++++++ 1 file changed, 7 insertions(+)