| Message ID | 20190827070623.15776-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] media: sun6i: Make sun4i_csi_formats static | expand |
Hi Yue, On Tue, Aug 27, 2019 at 03:06:23PM +0800, YueHaibing wrote: > Fix sparse warning: > > drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c:21:31: > warning: symbol 'sun4i_csi_formats' was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Thanks for the patch. This has been already addressed by another patch: <URL:https://patchwork.linuxtv.org/patch/58395/>
On 2019/8/27 15:20, Sakari Ailus wrote: > Hi Yue, > > On Tue, Aug 27, 2019 at 03:06:23PM +0800, YueHaibing wrote: >> Fix sparse warning: >> >> drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c:21:31: >> warning: symbol 'sun4i_csi_formats' was not declared. Should it be static? >> >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > Thanks for the patch. > > This has been already addressed by another patch: > > <URL:https://patchwork.linuxtv.org/patch/58395/> OK, thank you! >
diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c b/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c index 772b0fc..83a3a02 100644 --- a/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c +++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c @@ -18,7 +18,7 @@ #define CSI_DEFAULT_WIDTH 640 #define CSI_DEFAULT_HEIGHT 480 -const struct sun4i_csi_format sun4i_csi_formats[] = { +static const struct sun4i_csi_format sun4i_csi_formats[] = { /* YUV422 inputs */ { .mbus = MEDIA_BUS_FMT_YUYV8_2X8,
Fix sparse warning: drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c:21:31: warning: symbol 'sun4i_csi_formats' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)