[v2,0/3] soc: qcom: llcc cleanups

Message ID	20190718130238.11324-1-vivek.gautam@codeaurora.org (mailing list archive)
Headers	show Return-Path: <linux-arm-msm-owner@kernel.org> sender: vivek.gautam@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 56EBD6063A; Thu, 18 Jul 2019 13:02:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 56EBD6063A From: Vivek Gautam <vivek.gautam@codeaurora.org> To: agross@kernel.org, linux-arm-msm@vger.kernel.org Cc: bjorn.andersson@linaro.org, jcrouse@codeaurora.org, rishabhb@codeaurora.org, evgreen@chromium.org, linux-kernel@vger.kernel.org, Vivek Gautam <vivek.gautam@codeaurora.org> Subject: [PATCH v2 0/3] soc: qcom: llcc cleanups Date: Thu, 18 Jul 2019 18:32:35 +0530 Message-Id: <20190718130238.11324-1-vivek.gautam@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk
Series	soc: qcom: llcc cleanups \| expand [v2,0/3] soc: qcom: llcc cleanups [1/3] soc: qcom: llcc cleanup to get rid of sdm845 specific driver file [2/3] soc: qcom: Rename llcc-slice to llcc-qcom [3/3] soc: qcom: Make llcc-qcom a generic driver

Message ID

20190718130238.11324-1-vivek.gautam@codeaurora.org (mailing list archive)

Headers

DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 56EBD6063A
From: Vivek Gautam <vivek.gautam@codeaurora.org>
To: agross@kernel.org, linux-arm-msm@vger.kernel.org
Cc: bjorn.andersson@linaro.org, jcrouse@codeaurora.org,
        rishabhb@codeaurora.org, evgreen@chromium.org,
        linux-kernel@vger.kernel.org,
        Vivek Gautam <vivek.gautam@codeaurora.org>
Subject: [PATCH v2 0/3] soc: qcom: llcc cleanups
Date: Thu, 18 Jul 2019 18:32:35 +0530
Message-Id: <20190718130238.11324-1-vivek.gautam@codeaurora.org>
Sender: linux-arm-msm-owner@vger.kernel.org
Precedence: bulk

Series

soc: qcom: llcc cleanups | expand

Message

Vivek Gautam July 18, 2019, 1:02 p.m. UTC

To better support future versions of llcc, consolidating the
driver to llcc-qcom driver file, and taking care of the dependencies.
v1 series is availale at:
https://lore.kernel.org/patchwork/patch/1099573/

Changes since v1:
Addressing Bjorn's comments -
 * Not using llcc-plat as the platform driver rather using a single
   driver file now - llcc-qcom.
 * Removed SCT_ENTRY macro.
 * Moved few structure definitions from include/linux path to llcc-qcom
   driver as they are not exposed to other subsystems.

Vivek Gautam (3):
  soc: qcom: llcc cleanup to get rid of sdm845 specific driver file
  soc: qcom: Rename llcc-slice to llcc-qcom
  soc: qcom: Make llcc-qcom a generic driver

 drivers/soc/qcom/Kconfig                       |  14 +--
 drivers/soc/qcom/Makefile                      |   3 +-
 drivers/soc/qcom/{llcc-slice.c => llcc-qcom.c} | 155 +++++++++++++++++++++++--
 drivers/soc/qcom/llcc-sdm845.c                 | 100 ----------------
 include/linux/soc/qcom/llcc-qcom.h             | 104 -----------------
 5 files changed, 152 insertions(+), 224 deletions(-)
 rename drivers/soc/qcom/{llcc-slice.c => llcc-qcom.c} (64%)
 delete mode 100644 drivers/soc/qcom/llcc-sdm845.c

Comments

Vivek Gautam Aug. 2, 2019, 6:13 a.m. UTC | #1

On Thu, Jul 18, 2019 at 6:33 PM Vivek Gautam
<vivek.gautam@codeaurora.org> wrote:
>
> To better support future versions of llcc, consolidating the
> driver to llcc-qcom driver file, and taking care of the dependencies.
> v1 series is availale at:
> https://lore.kernel.org/patchwork/patch/1099573/
>
> Changes since v1:
> Addressing Bjorn's comments -
>  * Not using llcc-plat as the platform driver rather using a single
>    driver file now - llcc-qcom.
>  * Removed SCT_ENTRY macro.
>  * Moved few structure definitions from include/linux path to llcc-qcom
>    driver as they are not exposed to other subsystems.

Hi Bjorn,

How does this cleanup look now? Let me know if there are any
improvements to make here.

Best Regards
Vivek
>
> Vivek Gautam (3):
>   soc: qcom: llcc cleanup to get rid of sdm845 specific driver file
>   soc: qcom: Rename llcc-slice to llcc-qcom
>   soc: qcom: Make llcc-qcom a generic driver
>
>  drivers/soc/qcom/Kconfig                       |  14 +--
>  drivers/soc/qcom/Makefile                      |   3 +-
>  drivers/soc/qcom/{llcc-slice.c => llcc-qcom.c} | 155 +++++++++++++++++++++++--
>  drivers/soc/qcom/llcc-sdm845.c                 | 100 ----------------
>  include/linux/soc/qcom/llcc-qcom.h             | 104 -----------------
>  5 files changed, 152 insertions(+), 224 deletions(-)
>  rename drivers/soc/qcom/{llcc-slice.c => llcc-qcom.c} (64%)
>  delete mode 100644 drivers/soc/qcom/llcc-sdm845.c
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>

Vivek Gautam Aug. 27, 2019, 11:01 a.m. UTC | #2

On Fri, Aug 2, 2019 at 11:43 AM Vivek Gautam
<vivek.gautam@codeaurora.org> wrote:
>
> On Thu, Jul 18, 2019 at 6:33 PM Vivek Gautam
> <vivek.gautam@codeaurora.org> wrote:
> >
> > To better support future versions of llcc, consolidating the
> > driver to llcc-qcom driver file, and taking care of the dependencies.
> > v1 series is availale at:
> > https://lore.kernel.org/patchwork/patch/1099573/
> >
> > Changes since v1:
> > Addressing Bjorn's comments -
> >  * Not using llcc-plat as the platform driver rather using a single
> >    driver file now - llcc-qcom.
> >  * Removed SCT_ENTRY macro.
> >  * Moved few structure definitions from include/linux path to llcc-qcom
> >    driver as they are not exposed to other subsystems.
>
> Hi Bjorn,
>
> How does this cleanup look now? Let me know if there are any
> improvements to make here.
>

Hi Bjorn,

Are you planning to pull this series in the next merge window?
There's a dt patch as well for llcc on sdm845 [1] that has been lying around.

Let me know if you have concerns with this series. I will be happy to
incorporate the suggestions.

[1] https://lore.kernel.org/patchwork/patch/1099318/

Thanks & Regards
Vivek

> Best Regards
> Vivek
> >
> > Vivek Gautam (3):
> >   soc: qcom: llcc cleanup to get rid of sdm845 specific driver file
> >   soc: qcom: Rename llcc-slice to llcc-qcom
> >   soc: qcom: Make llcc-qcom a generic driver
> >
> >  drivers/soc/qcom/Kconfig                       |  14 +--
> >  drivers/soc/qcom/Makefile                      |   3 +-
> >  drivers/soc/qcom/{llcc-slice.c => llcc-qcom.c} | 155 +++++++++++++++++++++++--
> >  drivers/soc/qcom/llcc-sdm845.c                 | 100 ----------------
> >  include/linux/soc/qcom/llcc-qcom.h             | 104 -----------------
> >  5 files changed, 152 insertions(+), 224 deletions(-)
> >  rename drivers/soc/qcom/{llcc-slice.c => llcc-qcom.c} (64%)
> >  delete mode 100644 drivers/soc/qcom/llcc-sdm845.c
> >

Bjorn Andersson Sept. 4, 2019, 4:42 a.m. UTC | #3

On Tue 27 Aug 04:01 PDT 2019, Vivek Gautam wrote:

> On Fri, Aug 2, 2019 at 11:43 AM Vivek Gautam
> <vivek.gautam@codeaurora.org> wrote:
> >
> > On Thu, Jul 18, 2019 at 6:33 PM Vivek Gautam
> > <vivek.gautam@codeaurora.org> wrote:
> > >
> > > To better support future versions of llcc, consolidating the
> > > driver to llcc-qcom driver file, and taking care of the dependencies.
> > > v1 series is availale at:
> > > https://lore.kernel.org/patchwork/patch/1099573/
> > >
> > > Changes since v1:
> > > Addressing Bjorn's comments -
> > >  * Not using llcc-plat as the platform driver rather using a single
> > >    driver file now - llcc-qcom.
> > >  * Removed SCT_ENTRY macro.
> > >  * Moved few structure definitions from include/linux path to llcc-qcom
> > >    driver as they are not exposed to other subsystems.
> >
> > Hi Bjorn,
> >
> > How does this cleanup look now? Let me know if there are any
> > improvements to make here.
> >
> 
> Hi Bjorn,
> 
> Are you planning to pull this series in the next merge window?
> There's a dt patch as well for llcc on sdm845 [1] that has been lying around.
> 
> Let me know if you have concerns with this series. I will be happy to
> incorporate the suggestions.
> 

No concerns, this is exactly what we discussed before. Sorry for missing
it. I've picked the patches now.

> [1] https://lore.kernel.org/patchwork/patch/1099318/
> 

This is part of the v5.4 pull request.

Thanks,
Bjorn

> Thanks & Regards
> Vivek
> 
> > Best Regards
> > Vivek
> > >
> > > Vivek Gautam (3):
> > >   soc: qcom: llcc cleanup to get rid of sdm845 specific driver file
> > >   soc: qcom: Rename llcc-slice to llcc-qcom
> > >   soc: qcom: Make llcc-qcom a generic driver
> > >
> > >  drivers/soc/qcom/Kconfig                       |  14 +--
> > >  drivers/soc/qcom/Makefile                      |   3 +-
> > >  drivers/soc/qcom/{llcc-slice.c => llcc-qcom.c} | 155 +++++++++++++++++++++++--
> > >  drivers/soc/qcom/llcc-sdm845.c                 | 100 ----------------
> > >  include/linux/soc/qcom/llcc-qcom.h             | 104 -----------------
> > >  5 files changed, 152 insertions(+), 224 deletions(-)
> > >  rename drivers/soc/qcom/{llcc-slice.c => llcc-qcom.c} (64%)
> > >  delete mode 100644 drivers/soc/qcom/llcc-sdm845.c
> > >
> 
> 
> 
> -- 
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation

Vivek Gautam Sept. 4, 2019, 7:53 a.m. UTC | #4

On Wed, Sep 4, 2019 at 10:13 AM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> On Tue 27 Aug 04:01 PDT 2019, Vivek Gautam wrote:
>
> > On Fri, Aug 2, 2019 at 11:43 AM Vivek Gautam
> > <vivek.gautam@codeaurora.org> wrote:
> > >
> > > On Thu, Jul 18, 2019 at 6:33 PM Vivek Gautam
> > > <vivek.gautam@codeaurora.org> wrote:
> > > >
> > > > To better support future versions of llcc, consolidating the
> > > > driver to llcc-qcom driver file, and taking care of the dependencies.
> > > > v1 series is availale at:
> > > > https://lore.kernel.org/patchwork/patch/1099573/
> > > >
> > > > Changes since v1:
> > > > Addressing Bjorn's comments -
> > > >  * Not using llcc-plat as the platform driver rather using a single
> > > >    driver file now - llcc-qcom.
> > > >  * Removed SCT_ENTRY macro.
> > > >  * Moved few structure definitions from include/linux path to llcc-qcom
> > > >    driver as they are not exposed to other subsystems.
> > >
> > > Hi Bjorn,
> > >
> > > How does this cleanup look now? Let me know if there are any
> > > improvements to make here.
> > >
> >
> > Hi Bjorn,
> >
> > Are you planning to pull this series in the next merge window?
> > There's a dt patch as well for llcc on sdm845 [1] that has been lying around.
> >
> > Let me know if you have concerns with this series. I will be happy to
> > incorporate the suggestions.
> >
>
> No concerns, this is exactly what we discussed before. Sorry for missing
> it. I've picked the patches now.
>
> > [1] https://lore.kernel.org/patchwork/patch/1099318/
> >
>
> This is part of the v5.4 pull request.

Thanks a lot Bjorn.

Best regards
Vivek

>
> Thanks,
> Bjorn
>
> > Thanks & Regards
> > Vivek
> >
> > > Best Regards
> > > Vivek
> > > >
> > > > Vivek Gautam (3):
> > > >   soc: qcom: llcc cleanup to get rid of sdm845 specific driver file
> > > >   soc: qcom: Rename llcc-slice to llcc-qcom
> > > >   soc: qcom: Make llcc-qcom a generic driver
> > > >
> > > >  drivers/soc/qcom/Kconfig                       |  14 +--
> > > >  drivers/soc/qcom/Makefile                      |   3 +-
> > > >  drivers/soc/qcom/{llcc-slice.c => llcc-qcom.c} | 155 +++++++++++++++++++++++--
> > > >  drivers/soc/qcom/llcc-sdm845.c                 | 100 ----------------
> > > >  include/linux/soc/qcom/llcc-qcom.h             | 104 -----------------
> > > >  5 files changed, 152 insertions(+), 224 deletions(-)
> > > >  rename drivers/soc/qcom/{llcc-slice.c => llcc-qcom.c} (64%)
> > > >  delete mode 100644 drivers/soc/qcom/llcc-sdm845.c
> > > >
> >
> >
> >
> > --
> > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> > of Code Aurora Forum, hosted by The Linux Foundation