| Message ID | 1565235473-28461-2-git-send-email-rayagonda.kokatanur@broadcom.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Remove smbus quick cmd and update adapter name | expand |
On 8/7/19 8:37 PM, Rayagonda Kokatanur wrote: > From: Lori Hikichi <lori.hikichi@broadcom.com> > > The driver does not support the SMBUS Quick command so remove the > flag that indicates that level of support. > By default the i2c_detect tool uses the quick command to try and > detect devices at some bus addresses. If the quick command is used > then we will not detect the device, even though it is present. > > Fixes: e6e5dd3566e0 (i2c: iproc: Add Broadcom iProc I2C Driver) > > Signed-off-by: Lori Hikichi <lori.hikichi@broadcom.com> > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com> > --- > drivers/i2c/busses/i2c-bcm-iproc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c > index d7fd76b..19ef2b0 100644 > --- a/drivers/i2c/busses/i2c-bcm-iproc.c > +++ b/drivers/i2c/busses/i2c-bcm-iproc.c > @@ -790,7 +790,10 @@ static int bcm_iproc_i2c_xfer(struct i2c_adapter *adapter, > > static uint32_t bcm_iproc_i2c_functionality(struct i2c_adapter *adap) > { > - u32 val = I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; > + u32 val; > + > + /* We do not support the SMBUS Quick command */ > + val = I2C_FUNC_I2C | (I2C_FUNC_SMBUS_EMUL & ~I2C_FUNC_SMBUS_QUICK); > > if (adap->algo->reg_slave) > val |= I2C_FUNC_SLAVE; > Change looks good to me. Thanks. Reviewed-by: Ray Jui <ray.jui@broadcom.com>
On Thu, Aug 08, 2019 at 09:07:52AM +0530, Rayagonda Kokatanur wrote: > From: Lori Hikichi <lori.hikichi@broadcom.com> > > The driver does not support the SMBUS Quick command so remove the > flag that indicates that level of support. > By default the i2c_detect tool uses the quick command to try and > detect devices at some bus addresses. If the quick command is used > then we will not detect the device, even though it is present. > > Fixes: e6e5dd3566e0 (i2c: iproc: Add Broadcom iProc I2C Driver) > > Signed-off-by: Lori Hikichi <lori.hikichi@broadcom.com> > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com> Applied to for-current, thanks!
diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c index d7fd76b..19ef2b0 100644 --- a/drivers/i2c/busses/i2c-bcm-iproc.c +++ b/drivers/i2c/busses/i2c-bcm-iproc.c @@ -790,7 +790,10 @@ static int bcm_iproc_i2c_xfer(struct i2c_adapter *adapter, static uint32_t bcm_iproc_i2c_functionality(struct i2c_adapter *adap) { - u32 val = I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; + u32 val; + + /* We do not support the SMBUS Quick command */ + val = I2C_FUNC_I2C | (I2C_FUNC_SMBUS_EMUL & ~I2C_FUNC_SMBUS_QUICK); if (adap->algo->reg_slave) val |= I2C_FUNC_SLAVE;