diff mbox series

[v3,12/12] btrfs-progs: add test-case for mkfs with xxhash64

Message ID 20190830113234.16615-13-jthumshirn@suse.de (mailing list archive)
State New, archived
Headers show
Series btrfs-progs: support xxhash64 checksums | expand

Commit Message

Johannes Thumshirn Aug. 30, 2019, 11:32 a.m. UTC
Add test-cases for creating a file-system xxhash64 as checksumming
algorithm.

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
---
 tests/mkfs-tests/001-basic-profiles/test.sh | 2 ++
 1 file changed, 2 insertions(+)

Comments

Nikolay Borisov Sept. 2, 2019, 12:44 p.m. UTC | #1
On 30.08.19 г. 14:32 ч., Johannes Thumshirn wrote:
> Add test-cases for creating a file-system xxhash64 as checksumming
> algorithm.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>

Reviewed-by: Nikolay Borisov <nborisov@suse.com>, one improvement to
testing could be to include new test under cli-tests to test for invalid
values to -C param. But it's not critical.

> ---
>  tests/mkfs-tests/001-basic-profiles/test.sh | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/mkfs-tests/001-basic-profiles/test.sh b/tests/mkfs-tests/001-basic-profiles/test.sh
> index 6e295274119d..3fa3c8ad42d1 100755
> --- a/tests/mkfs-tests/001-basic-profiles/test.sh
> +++ b/tests/mkfs-tests/001-basic-profiles/test.sh
> @@ -46,6 +46,8 @@ test_mkfs_single  -d  single  -m  dup
>  test_mkfs_single  -d  dup     -m  single
>  test_mkfs_single  -d  dup     -m  dup
>  test_mkfs_single  -d  dup     -m  dup     --mixed
> +test_mkfs_single  -C xxhash64
> +test_mkfs_single  -C xxhash
>  
>  test_mkfs_multi
>  test_mkfs_multi   -d  single  -m  single
>
diff mbox series

Patch

diff --git a/tests/mkfs-tests/001-basic-profiles/test.sh b/tests/mkfs-tests/001-basic-profiles/test.sh
index 6e295274119d..3fa3c8ad42d1 100755
--- a/tests/mkfs-tests/001-basic-profiles/test.sh
+++ b/tests/mkfs-tests/001-basic-profiles/test.sh
@@ -46,6 +46,8 @@  test_mkfs_single  -d  single  -m  dup
 test_mkfs_single  -d  dup     -m  single
 test_mkfs_single  -d  dup     -m  dup
 test_mkfs_single  -d  dup     -m  dup     --mixed
+test_mkfs_single  -C xxhash64
+test_mkfs_single  -C xxhash
 
 test_mkfs_multi
 test_mkfs_multi   -d  single  -m  single