| Message ID | 20190901225827.12301-2-david@lechnology.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | counter: new TI eQEP driver | expand |
On Sun, Sep 01, 2019 at 05:58:22PM -0500, David Lechner wrote: > The TI PWMSS driver is a simple bus driver for providing power > power management for the PWM peripherals on TI AM33xx SoCs, namely > eCAP, eHRPWM and eQEP. The eQEP is a counter rather than a PWM, so > it does not make sense to have the bus driver in the PWM subsystem > since the PWMSS is not exclusive to PWM devices. > > Signed-off-by: David Lechner <david@lechnology.com> > --- > > v3 changes: > - none > v2 changes: > - new patch > > drivers/bus/Kconfig | 9 +++++++++ > drivers/bus/Makefile | 1 + > drivers/{pwm/pwm-tipwmss.c => bus/ti-pwmss.c} | 0 > drivers/pwm/Kconfig | 9 --------- > drivers/pwm/Makefile | 1 - > 5 files changed, 10 insertions(+), 10 deletions(-) > rename drivers/{pwm/pwm-tipwmss.c => bus/ti-pwmss.c} (100%) Acked-by: Thierry Reding <thierry.reding@gmail.com>
On Mon, 2 Sep 2019 17:02:45 +0200 Thierry Reding <thierry.reding@gmail.com> wrote: > On Sun, Sep 01, 2019 at 05:58:22PM -0500, David Lechner wrote: > > The TI PWMSS driver is a simple bus driver for providing power > > power management for the PWM peripherals on TI AM33xx SoCs, namely > > eCAP, eHRPWM and eQEP. The eQEP is a counter rather than a PWM, so > > it does not make sense to have the bus driver in the PWM subsystem > > since the PWMSS is not exclusive to PWM devices. > > > > Signed-off-by: David Lechner <david@lechnology.com> > > --- > > > > v3 changes: > > - none > > v2 changes: > > - new patch > > > > drivers/bus/Kconfig | 9 +++++++++ > > drivers/bus/Makefile | 1 + > > drivers/{pwm/pwm-tipwmss.c => bus/ti-pwmss.c} | 0 > > drivers/pwm/Kconfig | 9 --------- > > drivers/pwm/Makefile | 1 - > > 5 files changed, 10 insertions(+), 10 deletions(-) > > rename drivers/{pwm/pwm-tipwmss.c => bus/ti-pwmss.c} (100%) > > Acked-by: Thierry Reding <thierry.reding@gmail.com> Do we need an immutable branch for these precursor patches to the driver addition? It's not going to make 5.4 via my tree as cutting it too fine so we'll be in the position of holding these in a non obvious tree for a whole cycle. Thanks, Jonathan
* Jonathan Cameron <jic23@jic23.retrosnub.co.uk> [190908 11:16]: > On Mon, 2 Sep 2019 17:02:45 +0200 > Thierry Reding <thierry.reding@gmail.com> wrote: > > > On Sun, Sep 01, 2019 at 05:58:22PM -0500, David Lechner wrote: > > > The TI PWMSS driver is a simple bus driver for providing power > > > power management for the PWM peripherals on TI AM33xx SoCs, namely > > > eCAP, eHRPWM and eQEP. The eQEP is a counter rather than a PWM, so > > > it does not make sense to have the bus driver in the PWM subsystem > > > since the PWMSS is not exclusive to PWM devices. > > > > > > Signed-off-by: David Lechner <david@lechnology.com> > > > --- > > > > > > v3 changes: > > > - none > > > v2 changes: > > > - new patch > > > > > > drivers/bus/Kconfig | 9 +++++++++ > > > drivers/bus/Makefile | 1 + > > > drivers/{pwm/pwm-tipwmss.c => bus/ti-pwmss.c} | 0 > > > drivers/pwm/Kconfig | 9 --------- > > > drivers/pwm/Makefile | 1 - > > > 5 files changed, 10 insertions(+), 10 deletions(-) > > > rename drivers/{pwm/pwm-tipwmss.c => bus/ti-pwmss.c} (100%) > > > > Acked-by: Thierry Reding <thierry.reding@gmail.com> > > Do we need an immutable branch for these precursor patches to the > driver addition? It's not going to make 5.4 via my tree as cutting it > too fine so we'll be in the position of holding these in a non obvious > tree for a whole cycle. Sure an immutable branch would be nice in case of unlikely dts file conflicts. And yeah no need to try to rush to v5.4. Regards, Tony
On Sun, 8 Sep 2019 12:44:48 -0700 Tony Lindgren <tony@atomide.com> wrote: > * Jonathan Cameron <jic23@jic23.retrosnub.co.uk> [190908 11:16]: > > On Mon, 2 Sep 2019 17:02:45 +0200 > > Thierry Reding <thierry.reding@gmail.com> wrote: > > > > > On Sun, Sep 01, 2019 at 05:58:22PM -0500, David Lechner wrote: > > > > The TI PWMSS driver is a simple bus driver for providing power > > > > power management for the PWM peripherals on TI AM33xx SoCs, namely > > > > eCAP, eHRPWM and eQEP. The eQEP is a counter rather than a PWM, so > > > > it does not make sense to have the bus driver in the PWM subsystem > > > > since the PWMSS is not exclusive to PWM devices. > > > > > > > > Signed-off-by: David Lechner <david@lechnology.com> > > > > --- > > > > > > > > v3 changes: > > > > - none > > > > v2 changes: > > > > - new patch > > > > > > > > drivers/bus/Kconfig | 9 +++++++++ > > > > drivers/bus/Makefile | 1 + > > > > drivers/{pwm/pwm-tipwmss.c => bus/ti-pwmss.c} | 0 > > > > drivers/pwm/Kconfig | 9 --------- > > > > drivers/pwm/Makefile | 1 - > > > > 5 files changed, 10 insertions(+), 10 deletions(-) > > > > rename drivers/{pwm/pwm-tipwmss.c => bus/ti-pwmss.c} (100%) > > > > > > Acked-by: Thierry Reding <thierry.reding@gmail.com> > > > > Do we need an immutable branch for these precursor patches to the > > driver addition? It's not going to make 5.4 via my tree as cutting it > > too fine so we'll be in the position of holding these in a non obvious > > tree for a whole cycle. > > Sure an immutable branch would be nice in case of unlikely > dts file conflicts. And yeah no need to try to rush to v5.4. > > Regards, > > Tony immutable branch created based on 5.4-rc1 at: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/log/?h=ib-ti-eqep-5.4-rc1 I'll pull it into IIO in a few minutes as have one more of these to do at the same time. Includes patches 1-4 of this series. Thanks, Jonathan
diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig index 1851112ccc29..4eeb15839ce0 100644 --- a/drivers/bus/Kconfig +++ b/drivers/bus/Kconfig @@ -140,6 +140,15 @@ config TEGRA_GMI Driver for the Tegra Generic Memory Interface bus which can be used to attach devices such as NOR, UART, FPGA and more. +config TI_PWMSS + bool + default y if (ARCH_OMAP2PLUS) && (PWM_TIECAP || PWM_TIEHRPWM) + help + PWM Subsystem driver support for AM33xx SOC. + + PWM submodules require PWM config space access from submodule + drivers and require common parent driver support. + config TI_SYSC bool "TI sysc interconnect target module driver" depends on ARCH_OMAP2PLUS diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile index ca300b1914ce..a2d13cf4a877 100644 --- a/drivers/bus/Makefile +++ b/drivers/bus/Makefile @@ -26,6 +26,7 @@ obj-$(CONFIG_SUNXI_RSB) += sunxi-rsb.o obj-$(CONFIG_SIMPLE_PM_BUS) += simple-pm-bus.o obj-$(CONFIG_TEGRA_ACONNECT) += tegra-aconnect.o obj-$(CONFIG_TEGRA_GMI) += tegra-gmi.o +obj-$(CONFIG_TI_PWMSS) += ti-pwmss.o obj-$(CONFIG_TI_SYSC) += ti-sysc.o obj-$(CONFIG_TS_NBUS) += ts-nbus.o obj-$(CONFIG_UNIPHIER_SYSTEM_BUS) += uniphier-system-bus.o diff --git a/drivers/pwm/pwm-tipwmss.c b/drivers/bus/ti-pwmss.c similarity index 100% rename from drivers/pwm/pwm-tipwmss.c rename to drivers/bus/ti-pwmss.c diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig index a7e57516959e..300396564769 100644 --- a/drivers/pwm/Kconfig +++ b/drivers/pwm/Kconfig @@ -497,15 +497,6 @@ config PWM_TIEHRPWM To compile this driver as a module, choose M here: the module will be called pwm-tiehrpwm. -config PWM_TIPWMSS - bool - default y if (ARCH_OMAP2PLUS) && (PWM_TIECAP || PWM_TIEHRPWM) - help - PWM Subsystem driver support for AM33xx SOC. - - PWM submodules require PWM config space access from submodule - drivers and require common parent driver support. - config PWM_TWL tristate "TWL4030/6030 PWM support" depends on TWL4030_CORE diff --git a/drivers/pwm/Makefile b/drivers/pwm/Makefile index 76b555b51887..f67eb6e9294d 100644 --- a/drivers/pwm/Makefile +++ b/drivers/pwm/Makefile @@ -49,7 +49,6 @@ obj-$(CONFIG_PWM_SUN4I) += pwm-sun4i.o obj-$(CONFIG_PWM_TEGRA) += pwm-tegra.o obj-$(CONFIG_PWM_TIECAP) += pwm-tiecap.o obj-$(CONFIG_PWM_TIEHRPWM) += pwm-tiehrpwm.o -obj-$(CONFIG_PWM_TIPWMSS) += pwm-tipwmss.o obj-$(CONFIG_PWM_TWL) += pwm-twl.o obj-$(CONFIG_PWM_TWL_LED) += pwm-twl-led.o obj-$(CONFIG_PWM_VT8500) += pwm-vt8500.o
The TI PWMSS driver is a simple bus driver for providing power power management for the PWM peripherals on TI AM33xx SoCs, namely eCAP, eHRPWM and eQEP. The eQEP is a counter rather than a PWM, so it does not make sense to have the bus driver in the PWM subsystem since the PWMSS is not exclusive to PWM devices. Signed-off-by: David Lechner <david@lechnology.com> --- v3 changes: - none v2 changes: - new patch drivers/bus/Kconfig | 9 +++++++++ drivers/bus/Makefile | 1 + drivers/{pwm/pwm-tipwmss.c => bus/ti-pwmss.c} | 0 drivers/pwm/Kconfig | 9 --------- drivers/pwm/Makefile | 1 - 5 files changed, 10 insertions(+), 10 deletions(-) rename drivers/{pwm/pwm-tipwmss.c => bus/ti-pwmss.c} (100%)