| Message ID | HE1PR06MB40117D0EE96E6FA638A04B78ACBF0@HE1PR06MB4011.eurprd06.prod.outlook.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | media: hantro: H264 fixes and improvements | expand |
Hi Jonas, Thanks for the series, I'll be reviewing this shortly. On Sun, 2019-09-01 at 12:42 +0000, Jonas Karlman wrote: > This series contains fixes and improvements for the hantro H264 decoder. > > Patch 1-6 fixes issues and limitations observed when preparing support > for field encoded content. > > Patch 7 introduce new DPB entry flags that is used to signal how a reference > frame is referenced. This information is needed to correctly build a > reference list for field encoded content. > > Patch 8 adds bits to handle field encoded content, this is a rough patch > and should be reworked with proper code style and formatting. > Please get back with feedback on how to improve this. > > The following samples from [1] are now playable with patch 1-8 > - H264_1080i-25-interlace_Kaesescheibchen.mkv > - H264_10_1080i_50_AC3-Astra19.2_ProSieben_HD.ts > - big_buck_bunny_1080p_H264_AAC_25fps_7200K.mp4 > - h264_tivo_sample.ts > > The rest of the patches refactors G1 H264 code to more closely match > the code generated by my rockchip-vpu-regtool at [2] and then adds > support for H264 decoding on RK3399/RK3328 using the VPU2 block. > This code is early work and needs proper code style and formatting, > I just wanted to share the early work and get some initial feedback. > > This series has been tested using ffmpeg v4l2 request hwaccel at [3] [4] > What boards have you tested this on? Thanks, Ezequiel
On 2019-09-02 15:02, Ezequiel Garcia wrote: > Hi Jonas, > > Thanks for the series, I'll be reviewing this shortly. > > On Sun, 2019-09-01 at 12:42 +0000, Jonas Karlman wrote: >> This series contains fixes and improvements for the hantro H264 decoder. >> >> Patch 1-6 fixes issues and limitations observed when preparing support >> for field encoded content. >> >> Patch 7 introduce new DPB entry flags that is used to signal how a reference >> frame is referenced. This information is needed to correctly build a >> reference list for field encoded content. >> >> Patch 8 adds bits to handle field encoded content, this is a rough patch >> and should be reworked with proper code style and formatting. >> Please get back with feedback on how to improve this. >> >> The following samples from [1] are now playable with patch 1-8 >> - H264_1080i-25-interlace_Kaesescheibchen.mkv >> - H264_10_1080i_50_AC3-Astra19.2_ProSieben_HD.ts >> - big_buck_bunny_1080p_H264_AAC_25fps_7200K.mp4 >> - h264_tivo_sample.ts >> >> The rest of the patches refactors G1 H264 code to more closely match >> the code generated by my rockchip-vpu-regtool at [2] and then adds >> support for H264 decoding on RK3399/RK3328 using the VPU2 block. >> This code is early work and needs proper code style and formatting, >> I just wanted to share the early work and get some initial feedback. >> >> This series has been tested using ffmpeg v4l2 request hwaccel at [3] [4] >> > What boards have you tested this on? Main testing has been done on a Tinker Board S (RK3288) and a Rock64 (RK3328) device. Very limited testing on a Rock Pi 4 (RK3399) using earlier version of the patchset, I will redo some RK3399 testing to make sure it is not only VPU2 on RK3328 that works. Regards, Jonas > > Thanks, > Ezequiel >