[V2,1/2] brcmfmac: add stub version of brcmf_debugfs_get_devdir()

Commit Message

Rafał Miłecki Sept. 1, 2019, 11:34 a.m. UTC

From: Rafał Miłecki <[e-mail]>

In case of compiling driver without DEBUG expose a stub function to make
writing debug code much simpler (no extra conditions). This will allow
e.g. using debugfs_create_file() without any magic if or #ifdef.

Signed-off-by: Rafał Miłecki <[e-mail]>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Kalle Valo Sept. 6, 2019, 2:09 p.m. UTC | #1

Rafał Miłecki wrote:

> From: Rafał Miłecki <[e-mail]>
> 
> In case of compiling driver without DEBUG expose a stub function to make
> writing debug code much simpler (no extra conditions). This will allow
> e.g. using debugfs_create_file() without any magic if or #ifdef.
> 
> Signed-off-by: Rafał Miłecki <[e-mail]>

2 patches applied to wireless-drivers-next.git, thanks.

cb34212b1c25 brcmfmac: add stub version of brcmf_debugfs_get_devdir()
2f8c8e62cd50 brcmfmac: add "reset" debugfs entry for testing reset

Patch

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h
index ea6e8e839cae..9b221b509ade 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h
@@ -121,6 +121,10 @@  int brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
 int brcmf_debug_create_memdump(struct brcmf_bus *bus, const void *data,
 			       size_t len);
 #else
+static inline struct dentry *brcmf_debugfs_get_devdir(struct brcmf_pub *drvr)
+{
+	return ERR_PTR(-ENOENT);
+}
 static inline
 int brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
 			    int (*read_fn)(struct seq_file *seq, void *data))