| Message ID | 1567802352.26275.3.camel@HansenPartnership.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 0622800d2ebccead42b3a85e255f7d473a36ec99 |
| Headers | show |
| Series | [GIT,PULL] SCSI fixes for 5.3-rc7 | expand |
On Fri, Sep 6, 2019 at 1:39 PM James Bottomley <James.Bottomley@hansenpartnership.com> wrote: > > > diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c > index 8d8c495b5b60..d65558619ab0 100644 > --- a/drivers/scsi/lpfc/lpfc_attr.c > +++ b/drivers/scsi/lpfc/lpfc_attr.c > @@ -5715,7 +5715,7 @@ LPFC_ATTR_RW(nvme_embed_cmd, 1, 0, 2, > * 0 = Set nr_hw_queues by the number of CPUs or HW queues. > * 1,128 = Manually specify the maximum nr_hw_queue value to be set, > * > - * Value range is [0,128]. Default value is 8. > + * Value range is [0,256]. Default value is 8. > */ Shouldn't that "1,128 = Manually specify.." line also have been updated? Not that I really care, and I'll pul this, but.. Linus
The pull request you sent on Fri, 06 Sep 2019 16:39:12 -0400:
> git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/1e3778cb223e861808ae0daccf353536e7573eed
Thank you!
On 9/6/2019 4:18 PM, Linus Torvalds wrote: > On Fri, Sep 6, 2019 at 1:39 PM James Bottomley > <James.Bottomley@hansenpartnership.com> wrote: >> >> diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c >> index 8d8c495b5b60..d65558619ab0 100644 >> --- a/drivers/scsi/lpfc/lpfc_attr.c >> +++ b/drivers/scsi/lpfc/lpfc_attr.c >> @@ -5715,7 +5715,7 @@ LPFC_ATTR_RW(nvme_embed_cmd, 1, 0, 2, >> * 0 = Set nr_hw_queues by the number of CPUs or HW queues. >> * 1,128 = Manually specify the maximum nr_hw_queue value to be set, >> * >> - * Value range is [0,128]. Default value is 8. >> + * Value range is [0,256]. Default value is 8. >> */ > Shouldn't that "1,128 = Manually specify.." line also have been updated? > > Not that I really care, and I'll pul this, but.. > > Linus Yes - thanks -- james
diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index 8d8c495b5b60..d65558619ab0 100644 --- a/drivers/scsi/lpfc/lpfc_attr.c +++ b/drivers/scsi/lpfc/lpfc_attr.c @@ -5715,7 +5715,7 @@ LPFC_ATTR_RW(nvme_embed_cmd, 1, 0, 2, * 0 = Set nr_hw_queues by the number of CPUs or HW queues. * 1,128 = Manually specify the maximum nr_hw_queue value to be set, * - * Value range is [0,128]. Default value is 8. + * Value range is [0,256]. Default value is 8. */ LPFC_ATTR_R(fcp_mq_threshold, LPFC_FCP_MQ_THRESHOLD_DEF, LPFC_FCP_MQ_THRESHOLD_MIN, LPFC_FCP_MQ_THRESHOLD_MAX, diff --git a/drivers/scsi/lpfc/lpfc_sli4.h b/drivers/scsi/lpfc/lpfc_sli4.h index 329f7aa7e169..a81ef0293696 100644 --- a/drivers/scsi/lpfc/lpfc_sli4.h +++ b/drivers/scsi/lpfc/lpfc_sli4.h @@ -46,7 +46,7 @@ /* FCP MQ queue count limiting */ #define LPFC_FCP_MQ_THRESHOLD_MIN 0 -#define LPFC_FCP_MQ_THRESHOLD_MAX 128 +#define LPFC_FCP_MQ_THRESHOLD_MAX 256 #define LPFC_FCP_MQ_THRESHOLD_DEF 8 /* Common buffer size to accomidate SCSI and NVME IO buffers */
Just a single lpfc fix adjusting the number of available queues for high CPU count systems. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: James Smart (1): scsi: lpfc: Raise config max for lpfc_fcp_mq_threshold variable And the diffstat: drivers/scsi/lpfc/lpfc_attr.c | 2 +- drivers/scsi/lpfc/lpfc_sli4.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) With full diff below. James ---