| Message ID | 20190906045659.20621-1-vkoul@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 593020811cb0903141649fb6c7c53c442baae90a |
| Headers | show |
| Series | clk: qcom: gcc-qcs404: Use floor ops for sdcc clks | expand |
On Thu 05 Sep 21:56 PDT 2019, Vinod Koul wrote: > Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As > disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we > dont want the clock rates to do round up. > > [1]: https://lore.kernel.org/linux-arm-msm/20190830195142.103564-1-swboyd@chromium.org/ > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- > drivers/clk/qcom/gcc-qcs404.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c > index e12c04c09a6a..bd32212f37e6 100644 > --- a/drivers/clk/qcom/gcc-qcs404.c > +++ b/drivers/clk/qcom/gcc-qcs404.c > @@ -1057,7 +1057,7 @@ static struct clk_rcg2 sdcc1_apps_clk_src = { > .name = "sdcc1_apps_clk_src", > .parent_names = gcc_parent_names_13, > .num_parents = 5, > - .ops = &clk_rcg2_ops, > + .ops = &clk_rcg2_floor_ops, > }, > }; > > @@ -1103,7 +1103,7 @@ static struct clk_rcg2 sdcc2_apps_clk_src = { > .name = "sdcc2_apps_clk_src", > .parent_names = gcc_parent_names_14, > .num_parents = 4, > - .ops = &clk_rcg2_ops, > + .ops = &clk_rcg2_floor_ops, > }, > }; > > -- > 2.20.1 >
Quoting Vinod Koul (2019-09-05 21:56:59) > Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As > disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we > dont want the clock rates to do round up. > > [1]: https://lore.kernel.org/linux-arm-msm/20190830195142.103564-1-swboyd@chromium.org/ > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- Is Taniya writing the rest? Please don't dribble it out over the next few weeks! > drivers/clk/qcom/gcc-qcs404.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >
On 06-09-19, 13:38, Stephen Boyd wrote: > Quoting Vinod Koul (2019-09-05 21:56:59) > > Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As > > disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we > > dont want the clock rates to do round up. > > > > [1]: https://lore.kernel.org/linux-arm-msm/20190830195142.103564-1-swboyd@chromium.org/ > > > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > --- > > Is Taniya writing the rest? Please don't dribble it out over the next > few weeks! Taniya is Cced. Since I upstream qcs404 driver and have a board handy to test, did that :) Thanks
Hi Stephen, Vinod, On 9/7/2019 2:08 AM, Stephen Boyd wrote: > Quoting Vinod Koul (2019-09-05 21:56:59) >> Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As >> disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we >> dont want the clock rates to do round up. >> >> [1]: https://lore.kernel.org/linux-arm-msm/20190830195142.103564-1-swboyd@chromium.org/ >> >> Signed-off-by: Vinod Koul <vkoul@kernel.org> >> --- > > Is Taniya writing the rest? Please don't dribble it out over the next > few weeks! I have pushed the patch : https://patchwork.kernel.org/patch/11137393/ Vinod, I have taken care of the QCS404 in the same patch, so as to keep the change in one patch. > >> drivers/clk/qcom/gcc-qcs404.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >>
Quoting Taniya Das (2019-09-09 00:48:39) > Hi Stephen, Vinod, > > On 9/7/2019 2:08 AM, Stephen Boyd wrote: > > Quoting Vinod Koul (2019-09-05 21:56:59) > >> Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As > >> disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we > >> dont want the clock rates to do round up. > >> > >> [1]: https://lore.kernel.org/linux-arm-msm/20190830195142.103564-1-swboyd@chromium.org/ > >> > >> Signed-off-by: Vinod Koul <vkoul@kernel.org> > >> --- > > > > Is Taniya writing the rest? Please don't dribble it out over the next > > few weeks! > > I have pushed the patch : https://patchwork.kernel.org/patch/11137393/ > > Vinod, I have taken care of the QCS404 in the same patch, so as to keep > the change in one patch. > Cool thanks.
Quoting Vinod Koul (2019-09-05 21:56:59) > Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As > disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we > dont want the clock rates to do round up. > > [1]: https://lore.kernel.org/linux-arm-msm/20190830195142.103564-1-swboyd@chromium.org/ > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- Applied to clk-next
diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c index e12c04c09a6a..bd32212f37e6 100644 --- a/drivers/clk/qcom/gcc-qcs404.c +++ b/drivers/clk/qcom/gcc-qcs404.c @@ -1057,7 +1057,7 @@ static struct clk_rcg2 sdcc1_apps_clk_src = { .name = "sdcc1_apps_clk_src", .parent_names = gcc_parent_names_13, .num_parents = 5, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, }; @@ -1103,7 +1103,7 @@ static struct clk_rcg2 sdcc2_apps_clk_src = { .name = "sdcc2_apps_clk_src", .parent_names = gcc_parent_names_14, .num_parents = 4, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };
Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we dont want the clock rates to do round up. [1]: https://lore.kernel.org/linux-arm-msm/20190830195142.103564-1-swboyd@chromium.org/ Signed-off-by: Vinod Koul <vkoul@kernel.org> --- drivers/clk/qcom/gcc-qcs404.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)