| Message ID | 20190823184826.14525-6-volodymyr_babchuk@epam.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arch/arm: optee: fix TODOs and remove "experimental" status | expand |
Hi, On 8/23/19 7:48 PM, Volodymyr Babchuk wrote: > As all TODOs and potential security issues are resolved now, > remove experimental status from OP-TEE mediator. Looking at SUPPORT.MD, I think OP-TEE without this series would be considered as "Experimental". With this series applied, I still think we should keep the Kconfig behind EXPERT but mark it as "Technical Preview" for at least a release. This would encourage people to test and report any potential issues with OP-TEE. We can re-discuss about the state in a few months for future release. BTW, SUPPORT.MD should be updated to reflect the state of OP-TEE in Xen. Cheers,
Hi Julien, Julien Grall writes: > Hi, > > On 8/23/19 7:48 PM, Volodymyr Babchuk wrote: >> As all TODOs and potential security issues are resolved now, >> remove experimental status from OP-TEE mediator. > > Looking at SUPPORT.MD, I think OP-TEE without this series would be > considered as "Experimental". Right. > > With this series applied, I still think we should keep the Kconfig > behind EXPERT but mark it as "Technical Preview" for at least a > release. This would encourage people to test and report any potential > issues with OP-TEE. > > We can re-discuss about the state in a few months for future release. > > BTW, SUPPORT.MD should be updated to reflect the state of OP-TEE in Xen. Fair enough. In the next version I'll replace this patch with patch to SUPPORT.md. Or it is better to push separate patch for the documentation?
On 8/23/19 8:20 PM, Volodymyr Babchuk wrote: > > Hi Julien, Hi, Apologies for the delay. > > Julien Grall writes: > >> Hi, >> >> On 8/23/19 7:48 PM, Volodymyr Babchuk wrote: >>> As all TODOs and potential security issues are resolved now, >>> remove experimental status from OP-TEE mediator. >> >> Looking at SUPPORT.MD, I think OP-TEE without this series would be >> considered as "Experimental". > Right. > >> >> With this series applied, I still think we should keep the Kconfig >> behind EXPERT but mark it as "Technical Preview" for at least a >> release. This would encourage people to test and report any potential >> issues with OP-TEE. >> >> We can re-discuss about the state in a few months for future release. >> >> BTW, SUPPORT.MD should be updated to reflect the state of OP-TEE in Xen. > Fair enough. In the next version I'll replace this patch with patch to > SUPPORT.md. Or it is better to push separate patch for the documentation? I think the patch in SUPPORT.MD should go regardless of the state of the rest. It is fine to keep it in this series. Cheers,
Julien Grall writes: > On 8/23/19 8:20 PM, Volodymyr Babchuk wrote: >> >> Hi Julien, > > Hi, > > Apologies for the delay. It is okay. I myself was busy a bit. > >> >> Julien Grall writes: >> >>> Hi, >>> >>> On 8/23/19 7:48 PM, Volodymyr Babchuk wrote: >>>> As all TODOs and potential security issues are resolved now, >>>> remove experimental status from OP-TEE mediator. >>> >>> Looking at SUPPORT.MD, I think OP-TEE without this series would be >>> considered as "Experimental". >> Right. >> >>> >>> With this series applied, I still think we should keep the Kconfig >>> behind EXPERT but mark it as "Technical Preview" for at least a >>> release. This would encourage people to test and report any potential >>> issues with OP-TEE. >>> >>> We can re-discuss about the state in a few months for future release. >>> >>> BTW, SUPPORT.MD should be updated to reflect the state of OP-TEE in Xen. >> Fair enough. In the next version I'll replace this patch with patch to >> SUPPORT.md. Or it is better to push separate patch for the documentation? > > I think the patch in SUPPORT.MD should go regardless of the state of > the rest. It is fine to keep it in this series. Okay. By the way, I skimmed thru SUPPORT.MD and I'm not sure what is the best place to describe mediator. So I could use some advice there.
Hi Volodymyr, On 9/11/19 7:41 PM, Volodymyr Babchuk wrote: > > Julien Grall writes: > >> On 8/23/19 8:20 PM, Volodymyr Babchuk wrote: >>> >>> Hi Julien, >> >> Hi, >> >> Apologies for the delay. > It is okay. I myself was busy a bit. > >> >>> >>> Julien Grall writes: >>> >>>> Hi, >>>> >>>> On 8/23/19 7:48 PM, Volodymyr Babchuk wrote: >>>>> As all TODOs and potential security issues are resolved now, >>>>> remove experimental status from OP-TEE mediator. >>>> >>>> Looking at SUPPORT.MD, I think OP-TEE without this series would be >>>> considered as "Experimental". >>> Right. >>> >>>> >>>> With this series applied, I still think we should keep the Kconfig >>>> behind EXPERT but mark it as "Technical Preview" for at least a >>>> release. This would encourage people to test and report any potential >>>> issues with OP-TEE. >>>> >>>> We can re-discuss about the state in a few months for future release. >>>> >>>> BTW, SUPPORT.MD should be updated to reflect the state of OP-TEE in Xen. >>> Fair enough. In the next version I'll replace this patch with patch to >>> SUPPORT.md. Or it is better to push separate patch for the documentation? >> >> I think the patch in SUPPORT.MD should go regardless of the state of >> the rest. It is fine to keep it in this series. > Okay. By the way, I skimmed thru SUPPORT.MD and I'm not sure what is the > best place to describe mediator. So I could use some advice there. Good question. I would put it under "## Virtual Hardware, Hypervisor". Maybe after the subsection "### ARM: Guest ACPI support"? Cheers,
diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index c2db2a6953..9b35783f68 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -107,7 +107,7 @@ config HARDEN_BRANCH_PREDICTOR If unsure, say Y. config TEE - bool "Enable TEE mediators support" if EXPERT = "y" + bool "Enable TEE mediators support" default n help This option enables generic TEE mediators support. It allows guests diff --git a/xen/arch/arm/tee/Kconfig b/xen/arch/arm/tee/Kconfig index b4b6aa2610..0b463ba368 100644 --- a/xen/arch/arm/tee/Kconfig +++ b/xen/arch/arm/tee/Kconfig @@ -3,7 +3,7 @@ config OPTEE default n depends on TEE help - Enable experimental OP-TEE mediator. It allows guests to access + Enable OP-TEE mediator. It allows guests to access OP-TEE running on your platform. This requires virtualization-enabled OP-TEE present. You can learn more about virtualization for OP-TEE at https://optee.readthedocs.io/architecture/virtualization.html
As all TODOs and potential security issues are resolved now, remove experimental status from OP-TEE mediator. Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com> --- Note for maintainer: obviously this patch should be committed only if all other patches in this series are committed as well --- xen/arch/arm/Kconfig | 2 +- xen/arch/arm/tee/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)