| Message ID | 20190906152250.1450649-2-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | [1/2] crypto: inside-secure - fix uninitialized-variable warning | expand |
On Fri, Sep 06, 2019 at 05:22:30PM +0200, Arnd Bergmann wrote: > The only caller of hisi_zip_vf_q_assign() is hidden in an #ifdef, > so the function causes a warning when CONFIG_PCI_IOV is disabled: > > drivers/crypto/hisilicon/zip/zip_main.c:740:12: error: unused function 'hisi_zip_vf_q_assign' [-Werror,-Wunused-function] > > Move it into the same #ifdef. > > Fixes: 79e09f30eeba ("crypto: hisilicon - add SRIOV support for ZIP") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/crypto/hisilicon/zip/zip_main.c | 2 ++ > 1 file changed, 2 insertions(+) Please find a way to fix this warning without reducing compiler coverage. I prefer to see any compile issues immediately rather than through automated build testing. Thanks,
On 2019/9/13 17:17, Herbert Xu wrote: > On Fri, Sep 06, 2019 at 05:22:30PM +0200, Arnd Bergmann wrote: >> The only caller of hisi_zip_vf_q_assign() is hidden in an #ifdef, >> so the function causes a warning when CONFIG_PCI_IOV is disabled: >> >> drivers/crypto/hisilicon/zip/zip_main.c:740:12: error: unused function 'hisi_zip_vf_q_assign' [-Werror,-Wunused-function] >> >> Move it into the same #ifdef. >> >> Fixes: 79e09f30eeba ("crypto: hisilicon - add SRIOV support for ZIP") >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> --- >> drivers/crypto/hisilicon/zip/zip_main.c | 2 ++ >> 1 file changed, 2 insertions(+) > > Please find a way to fix this warning without reducing compiler > coverage. I prefer to see any compile issues immediately rather > than through automated build testing. > > Thanks, > Sorry for missing this patch. Seems other drivers also do like using #ifdef. Do you mean something like this: #ifdef CONFIG_PCI_IOV sriov_enable() ... #else /* stub */ sriov_enable() ... #endif Best, Zhou
On Thu, Sep 19, 2019 at 04:11:13PM +0800, Zhou Wang wrote: > On 2019/9/13 17:17, Herbert Xu wrote: > > On Fri, Sep 06, 2019 at 05:22:30PM +0200, Arnd Bergmann wrote: > >> The only caller of hisi_zip_vf_q_assign() is hidden in an #ifdef, > >> so the function causes a warning when CONFIG_PCI_IOV is disabled: > >> > >> drivers/crypto/hisilicon/zip/zip_main.c:740:12: error: unused function 'hisi_zip_vf_q_assign' [-Werror,-Wunused-function] > >> > >> Move it into the same #ifdef. > >> > >> Fixes: 79e09f30eeba ("crypto: hisilicon - add SRIOV support for ZIP") > >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > >> --- > >> drivers/crypto/hisilicon/zip/zip_main.c | 2 ++ > >> 1 file changed, 2 insertions(+) > > > > Please find a way to fix this warning without reducing compiler > > coverage. I prefer to see any compile issues immediately rather > > than through automated build testing. > > > > Thanks, > > > > Sorry for missing this patch. > > Seems other drivers also do like using #ifdef. Do you mean something like this: > #ifdef CONFIG_PCI_IOV > sriov_enable() > ... > #else > /* stub */ > sriov_enable() > ... > #endif For an unused warning the unused compiler attribute would seem to be the way to go. Cheers,
On Thu, Sep 19, 2019 at 3:48 PM Herbert Xu <herbert@gondor.apana.org.au> wrote: > > On Thu, Sep 19, 2019 at 04:11:13PM +0800, Zhou Wang wrote: > > On 2019/9/13 17:17, Herbert Xu wrote: > > > On Fri, Sep 06, 2019 at 05:22:30PM +0200, Arnd Bergmann wrote: > > >> The only caller of hisi_zip_vf_q_assign() is hidden in an #ifdef, > > >> so the function causes a warning when CONFIG_PCI_IOV is disabled: > > >> > > >> drivers/crypto/hisilicon/zip/zip_main.c:740:12: error: unused function 'hisi_zip_vf_q_assign' [-Werror,-Wunused-function] > > >> > > >> Move it into the same #ifdef. > > >> > > >> Fixes: 79e09f30eeba ("crypto: hisilicon - add SRIOV support for ZIP") > > >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > >> --- > > >> drivers/crypto/hisilicon/zip/zip_main.c | 2 ++ > > >> 1 file changed, 2 insertions(+) > > > > > > Please find a way to fix this warning without reducing compiler > > > coverage. I prefer to see any compile issues immediately rather > > > than through automated build testing. > > > > > > Thanks, > > > > > > > Sorry for missing this patch. > > > > Seems other drivers also do like using #ifdef. Do you mean something like this: > > #ifdef CONFIG_PCI_IOV > > sriov_enable() > > ... > > #else > > /* stub */ > > sriov_enable() > > ... > > #endif > > For an unused warning the unused compiler attribute would seem > to be the way to go. I sent an update patch now that also removes the first #ifdef, plus one that enables compile-testing on x86 (with some caveats). Arnd
diff --git a/drivers/crypto/hisilicon/zip/zip_main.c b/drivers/crypto/hisilicon/zip/zip_main.c index 6e0ca75585d4..bd0283c2fa87 100644 --- a/drivers/crypto/hisilicon/zip/zip_main.c +++ b/drivers/crypto/hisilicon/zip/zip_main.c @@ -736,6 +736,7 @@ static int hisi_zip_probe(struct pci_dev *pdev, const struct pci_device_id *id) return ret; } +#ifdef CONFIG_PCI_IOV /* Currently we only support equal assignment */ static int hisi_zip_vf_q_assign(struct hisi_zip *hisi_zip, int num_vfs) { @@ -764,6 +765,7 @@ static int hisi_zip_vf_q_assign(struct hisi_zip *hisi_zip, int num_vfs) return 0; } +#endif static int hisi_zip_clear_vft_config(struct hisi_zip *hisi_zip) {
The only caller of hisi_zip_vf_q_assign() is hidden in an #ifdef, so the function causes a warning when CONFIG_PCI_IOV is disabled: drivers/crypto/hisilicon/zip/zip_main.c:740:12: error: unused function 'hisi_zip_vf_q_assign' [-Werror,-Wunused-function] Move it into the same #ifdef. Fixes: 79e09f30eeba ("crypto: hisilicon - add SRIOV support for ZIP") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/crypto/hisilicon/zip/zip_main.c | 2 ++ 1 file changed, 2 insertions(+)