| Message ID | 1568376720-7402-4-git-send-email-gareth.williams.jx@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | spi: dw: Add basic runtime PM support | expand |
On Fri, Sep 13, 2019 at 3:14 PM Gareth Williams <gareth.williams.jx@renesas.com> wrote: > > From: Phil Edworthy <phil.edworthy@renesas.com> > > The Renesas RZ/N1 SPI Controller is based on the Synopsys DW SSI, but has > additional registers for software CS control and DMA. This patch does not > address the changes required for DMA support, it simply adds the compatible > string. The CS registers are not needed as Linux can use gpios for the CS > signals. > + { .compatible = "renesas,rzn1-spi", }, Can't you simple use in DT something like compatible = "renesas,rzn1-spi", "snps,dw-apb-ssi" ?
On Sun, Sep 15, 2019 at 02:00:33PM +0300, Andy Shevchenko wrote: > On Fri, Sep 13, 2019 at 3:14 PM Gareth Williams > > The Renesas RZ/N1 SPI Controller is based on the Synopsys DW SSI, but has > > additional registers for software CS control and DMA. This patch does not > > address the changes required for DMA support, it simply adds the compatible > > string. The CS registers are not needed as Linux can use gpios for the CS > > signals. > > + { .compatible = "renesas,rzn1-spi", }, > Can't you simple use in DT something like > compatible = "renesas,rzn1-spi", "snps,dw-apb-ssi" > ? Yes, you can and should do that but it's still nice to list the compatibles explicitly in the driver in case someone leaves out the fallback compatible for whatever reason - if both the driver and the DT list things then there's a bit more robustness.
diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c index edb3cf6..3640b01 100644 --- a/drivers/spi/spi-dw-mmio.c +++ b/drivers/spi/spi-dw-mmio.c @@ -225,6 +225,7 @@ static const struct of_device_id dw_spi_mmio_of_match[] = { { .compatible = "mscc,ocelot-spi", .data = dw_spi_mscc_ocelot_init}, { .compatible = "mscc,jaguar2-spi", .data = dw_spi_mscc_jaguar2_init}, { .compatible = "amazon,alpine-dw-apb-ssi", .data = dw_spi_alpine_init}, + { .compatible = "renesas,rzn1-spi", }, { /* end of table */} }; MODULE_DEVICE_TABLE(of, dw_spi_mmio_of_match);