| Message ID | 20190912213257.24147-2-andreas@kemnade.info (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | backlight_lm3630a: add enable_gpios property | expand |
Andreas On 9/12/19 4:32 PM, Andreas Kemnade wrote: > add enable-gpios to describe HWEN pin > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > Acked-by: Daniel Thompson <daniel.thompson@linaro.org> Reviewed-by: Dan Murphy <dmurphy@ti.com> > --- > changes in v2: added example > changes in v3: added Acked-by > changes in v4: moved enable-gpios to the right position > in the example > .../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > index dc129d9a329e..c8470628fe02 100644 > --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > @@ -29,6 +29,10 @@ properties: > '#size-cells': > const: 0 > > + enable-gpios: > + description: GPIO to use to enable/disable the backlight (HWEN pin). > + maxItems: 1 > + > required: > - compatible > - reg > @@ -96,6 +100,7 @@ examples: > led-controller@38 { > compatible = "ti,lm3630a"; > reg = <0x38>; > + enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; > > #address-cells = <1>; > #size-cells = <0>;
On Thu, 12 Sep 2019 23:32:56 +0200, Andreas Kemnade wrote: > add enable-gpios to describe HWEN pin > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > Acked-by: Daniel Thompson <daniel.thompson@linaro.org> > --- > changes in v2: added example > changes in v3: added Acked-by > changes in v4: moved enable-gpios to the right position > in the example > .../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
On Thu, 12 Sep 2019, Andreas Kemnade wrote: > Provide DT documentation for enable-gpios. > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > Acked-by: Daniel Thompson <daniel.thompson@linaro.org> > Reviewed-by: Rob Herring <robh@kernel.org> > Reviewed-by: Dan Murphy <dmurphy@ti.com> > --- > changes in v2: added example > changes in v3: added Acked-by > changes in v4: moved enable-gpios to the right position > in the example > .../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++ > 1 file changed, 5 insertions(+) Applied, thanks.
On Thu, Sep 12, 2019 at 4:33 PM Andreas Kemnade <andreas@kemnade.info> wrote: > > add enable-gpios to describe HWEN pin > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > Acked-by: Daniel Thompson <daniel.thompson@linaro.org> This breaking linux-next now... > --- > changes in v2: added example > changes in v3: added Acked-by > changes in v4: moved enable-gpios to the right position > in the example > .../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > index dc129d9a329e..c8470628fe02 100644 > --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > @@ -29,6 +29,10 @@ properties: > '#size-cells': > const: 0 > > + enable-gpios: > + description: GPIO to use to enable/disable the backlight (HWEN pin). > + maxItems: 1 > + > required: > - compatible > - reg > @@ -96,6 +100,7 @@ examples: > led-controller@38 { > compatible = "ti,lm3630a"; > reg = <0x38>; > + enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; Error: Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dts:24.46-47 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml] Error 1 scripts/Makefile.lib:314: recipe for target 'Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml' failed You need the include for the define. Rob
Hi, On Mon, 28 Oct 2019 18:25:56 -0500 Rob Herring <robh+dt@kernel.org> wrote: > On Thu, Sep 12, 2019 at 4:33 PM Andreas Kemnade <andreas@kemnade.info> wrote: > > > > add enable-gpios to describe HWEN pin > > > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > > Acked-by: Daniel Thompson <daniel.thompson@linaro.org> > > This breaking linux-next now... > oops, sorry. > > --- > > changes in v2: added example > > changes in v3: added Acked-by > > changes in v4: moved enable-gpios to the right position > > in the example > > .../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > > index dc129d9a329e..c8470628fe02 100644 > > --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > > +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > > @@ -29,6 +29,10 @@ properties: > > '#size-cells': > > const: 0 > > > > + enable-gpios: > > + description: GPIO to use to enable/disable the backlight (HWEN pin). > > + maxItems: 1 > > + > > required: > > - compatible > > - reg > > @@ -96,6 +100,7 @@ examples: > > led-controller@38 { > > compatible = "ti,lm3630a"; > > reg = <0x38>; > > + enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; > > Error: Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dts:24.46-47 > syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml] > Error 1 > scripts/Makefile.lib:314: recipe for target > 'Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml' > failed > > You need the include for the define. gpio/gpio.h is missing. Yes, was not aware of that these things will be compiled and the automatic check did not work on my system at all. So I decided not to fix that for just this simple thing which was a not so good idea. Will send a fixup. Regards, Andreas
diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml index dc129d9a329e..c8470628fe02 100644 --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml @@ -29,6 +29,10 @@ properties: '#size-cells': const: 0 + enable-gpios: + description: GPIO to use to enable/disable the backlight (HWEN pin). + maxItems: 1 + required: - compatible - reg @@ -96,6 +100,7 @@ examples: led-controller@38 { compatible = "ti,lm3630a"; reg = <0x38>; + enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; #address-cells = <1>; #size-cells = <0>;