| Message ID | 1568043491-20680-1-git-send-email-peng.fan@nxp.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | clk: imx8m: fix glitch/mux | expand |
Hi Stephen, Shawn, > Subject: [PATCH V3 0/4] clk: imx8m: fix glitch/mux Sorry to ping early. Is there a chance to land this patchset in 5.3 release? Thanks, Peng. > > From: Peng Fan <peng.fan@nxp.com> > > V3: > Add cover-letter > > V2: > Added patch [2,3,4]/4 and avoid glitch when prepare > > There is two bypass bit in the pll, BYPASS and EXT_BYPASS. > There is also a restriction that to avoid glitch, need set BYPASS bit when > RESETB changed from 0 to 1, otherwise there will be glitch. > > However the BYPASS bit is also used as mux bit in imx8mm/imx8mn clk driver. > > This means two paths touch the same bit which is wrong. So switch to use > EXT_BYPASS bit as the mux. > > Peng Fan (4): > clk: imx: pll14xx: avoid glitch when set rate > clk: imx: clk-pll14xx: unbypass PLL by default > clk: imx: imx8mm: fix pll mux bit > clk: imx: imx8mn: fix pll mux bit > > drivers/clk/imx/clk-imx8mm.c | 32 ++++++++++---------------------- > drivers/clk/imx/clk-imx8mn.c | 32 ++++++++++---------------------- > drivers/clk/imx/clk-pll14xx.c | 27 ++++++++++++++++++++++++++- > 3 files changed, 46 insertions(+), 45 deletions(-) > > -- > 2.16.4
Quoting Peng Fan (2019-09-16 23:20:15) > Hi Stephen, Shawn, > > > Subject: [PATCH V3 0/4] clk: imx8m: fix glitch/mux > > Sorry to ping early. Is there a chance to land this patchset in 5.3 release? > No, it won't be in 5.3 because that version is released. Shawn already sent the PR for 5.4 too so this will most likely be in v5.5 at the earliest.
Hi Stephen, > Subject: RE: [PATCH V3 0/4] clk: imx8m: fix glitch/mux > > Quoting Peng Fan (2019-09-16 23:20:15) > > Hi Stephen, Shawn, > > > > > Subject: [PATCH V3 0/4] clk: imx8m: fix glitch/mux > > > > Sorry to ping early. Is there a chance to land this patchset in 5.3 release? > > > > No, it won't be in 5.3 because that version is released. Shawn already sent the > PR for 5.4 too so this will most likely be in v5.5 at the earliest. Thanks for the info. But this patchset is bugfix, so hope this could be accepted in 5.4. Thanks, Peng.
Quoting Peng Fan (2019-09-17 22:45:20) > Hi Stephen, > > > Subject: RE: [PATCH V3 0/4] clk: imx8m: fix glitch/mux > > > > Quoting Peng Fan (2019-09-16 23:20:15) > > > Hi Stephen, Shawn, > > > > > > > Subject: [PATCH V3 0/4] clk: imx8m: fix glitch/mux > > > > > > Sorry to ping early. Is there a chance to land this patchset in 5.3 release? > > > > > > > No, it won't be in 5.3 because that version is released. Shawn already sent the > > PR for 5.4 too so this will most likely be in v5.5 at the earliest. > > Thanks for the info. But this patchset is bugfix, so hope this could be accepted in 5.4. > Ok. Then let's throw it into 5.4 PR and see what goes wrong.
From: Peng Fan <peng.fan@nxp.com> V3: Add cover-letter V2: Added patch [2,3,4]/4 and avoid glitch when prepare There is two bypass bit in the pll, BYPASS and EXT_BYPASS. There is also a restriction that to avoid glitch, need set BYPASS bit when RESETB changed from 0 to 1, otherwise there will be glitch. However the BYPASS bit is also used as mux bit in imx8mm/imx8mn clk driver. This means two paths touch the same bit which is wrong. So switch to use EXT_BYPASS bit as the mux. Peng Fan (4): clk: imx: pll14xx: avoid glitch when set rate clk: imx: clk-pll14xx: unbypass PLL by default clk: imx: imx8mm: fix pll mux bit clk: imx: imx8mn: fix pll mux bit drivers/clk/imx/clk-imx8mm.c | 32 ++++++++++---------------------- drivers/clk/imx/clk-imx8mn.c | 32 ++++++++++---------------------- drivers/clk/imx/clk-pll14xx.c | 27 ++++++++++++++++++++++++++- 3 files changed, 46 insertions(+), 45 deletions(-)